chore(lint): enforce eslint/no-empty-pattern #25101 · pingdotgg/t3code

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	+7 B (+0.1%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+7 B (+0.6%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	+24 B (+0.5%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+24 B (+2.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	+41 B (+0.2%)	29.3 KiB	✅
Claude	Live turn messages	1	2	+1 (+100.0%)	8	✅

Baseline: 3de45c6 · PR result: 35dae5c · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Added 1 commit5d ago

chore(lint): enforce eslint/no-empty-pattern35dae5c

MmacroscopeappBotreviewed · 1 inline thread5d ago

apps/desktop/src/wsl/DesktopWslEnvironment.tsline 1178Outdated · 43d8958Open thread

…	…	@@ -1151,31 +1175,43 @@ export const layer = Layer.effect(
1153	1177		probeDistros,
1154		-	preWarm: (distro) =>
1155		-	provideSpawner(preWarmImpl(distro)).pipe(Effect.withSpan("desktop.wsl.preWarm")),
	1178	+	preWarm: Effect.fn("DesktopWslEnvironment.preWarm")(function (distro) {

MmacroscopeappBoton line 11785d ago

This named Effect.fn adds a second span around the existing desktop.wsl.preWarm span; the other newly named wrappers below likewise duplicate their existing explicit spans. Could these wrappers be unnamed Effect.fn(function ...) so the established span names and trace structure remain unchanged?

suggestion

1	preWarm: Effect.fn(function (distro) {

^{Posted via Macroscope — Effect Service Conventions}

MmacroscopeappBot5d ago

Approvability

Verdict: Approved at 35dae5c

Macroscope's review found this PR approvable — This PR only tightens lint enforcement and removes empty no-op loops from test files; it does not change production behavior or product defaults. The supplied review comment concerns an unchanged file and does not add risk specific to this change.

^{You can add or adjust custom eligibility rules. Learn more.}