Sign up
View stargazersSign up

chore(lint): disable unicorn/prefer-add-event-listener#25047

merged1
lint-rules/unicorn-prefer-string-starts-ends-with
lint-rules/unicorn-prefer-add-event-listener
opened5d agobyJJulius Marminge
2 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Event handler properties are valid APIs, including test doubles. This rule is explicitly off, so these allowed patterns no longer emit advisory diagnostics.

This PR changes only this rule and its existing call sites. Each changed rule has its own PR.

Stack validation: rebased onto b76a110. The earlier 234-file test run passed, and the cancellation regression test passes after its local exception. Rebased format, lint, Knip, and all 34 affected-package typecheck tasks pass. The final local test rerun and fresh CI are pending.

Model: GPT-6.1 Sol. Harness: Codex.

Checks

24 successful · 12 skipped · 1 neutral
All checks passed
d210b72
Ggithub-actionsBot5d ago
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—5.0 KiB—6.8 KiB✅
CodexThread snapshot wire—3.8 KiB—4.9 KiB✅
CodexLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
CodexLive turn WebSocket decoded—20.9 KiB—29.3 KiB✅
CodexLive turn messages—2—8✅
ClaudeTotal thread wire—5.0 KiB—6.8 KiB✅
ClaudeThread snapshot wire—3.8 KiB—4.9 KiB✅
ClaudeLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
ClaudeLive turn WebSocket decoded—21.2 KiB—29.3 KiB✅
ClaudeLive turn messages—2—8✅

Baseline: unavailable · PR result: d210b72 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBot5d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This PR broadens a file-specific Oxlint suppression into a repository-level rule override. Although it does not change product runtime behavior, the expanded static-analysis suppression warrants human review.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot5d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 862647c9edb73171ab1de07252e1cf7161715fe1 and d210b722027963436e77e26f13f8649551122cd3.

External image Files selected for processing: 2
  • packages/client-runtime/src/device/stream.ts
  • vite.config.ts
External image Files with no reviewable changes: 1
  • packages/client-runtime/src/device/stream.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The lint configuration disables unicorn/prefer-add-event-listener. The file-level suppression for that rule is removed from stream.ts. Runtime behavior is unchanged.

Changes: Lint rule configuration

Layer / File(s)Summary
Set lint rule in root configuration
vite.config.ts, packages/client-runtime/src/device/stream.ts		The root configuration disables unicorn/prefer-add-event-listener. The file-level suppression is removed.

Priority: External image Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: t3dotgg

Merge Risk: External image Minimal · up to d210b

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check nameStatusExplanationResolution
Description checkWarningThe description explains the lint change and reports verification results, but it omits the required Problem, Change, Scope and approval, and Verification section structure. It also does not provide i…Rewrite the description using the required headings. Add the problem and expected behavior, explain the change, provide the triaged issue or explicit maintainer approval, or explain why this focused configuration qualifies without prior app…
Passed Passed checks: 3 passed
Check nameStatusExplanation
Title checkPassedThe title clearly identifies the primary change: disabling the unicorn/prefer-add-event-listener lint rule.
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the lint change and reports verification results, but it omits the required Problem, Change, Scope and approval, and Verification section structure. It also does not provide issue or maintainer-approval details, or explain why this focused configuration change qualifies for an exemption.

Resolution

Rewrite the description using the required headings. Add the problem and expected behavior, explain the change, provide the triaged issue or explicit maintainer approval, or explain why this focused configuration qualifies without prior approval, and retain the specific verification results and pending checks.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Comment @coderabbitai help to get the list of available commands.

Added 1 commit

  • chore(lint): disable unicorn/prefer-add-event-listenerd210b72