Sign up
View stargazersSign up

chore(lint): disable unicorn/prefer-set-has#25044

merged1
lint-rules/unicorn-prefer-array-find
lint-rules/unicorn-prefer-set-has
opened5d agobyJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Array or Set membership is a contextual choice. This rule is explicitly off, so these allowed patterns no longer emit advisory diagnostics.

This PR changes only this rule and its existing call sites. Each changed rule has its own PR.

Stack validation: rebased onto b76a110. The earlier 234-file test run passed, and the cancellation regression test passes after its local exception. Rebased format, lint, Knip, and all 34 affected-package typecheck tasks pass. The final local test rerun and fresh CI are pending.

Model: GPT-6.1 Sol. Harness: Codex.

Checks

23 successful · 13 skipped
All checks passed
6c29816
Ggithub-actionsBot5d ago
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—5.0 KiB—6.8 KiB✅
CodexThread snapshot wire—3.8 KiB—4.9 KiB✅
CodexLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
CodexLive turn WebSocket decoded—20.9 KiB—29.3 KiB✅
CodexLive turn messages—2—8✅
ClaudeTotal thread wire—5.0 KiB—6.8 KiB✅
ClaudeThread snapshot wire—3.8 KiB—4.9 KiB✅
ClaudeLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
ClaudeLive turn WebSocket decoded—21.2 KiB—29.3 KiB✅
ClaudeLive turn messages—2—8✅

Baseline: unavailable · PR result: 6c29816 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBot5d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This one-line change disables the unicorn/prefer-set-has lint diagnostic globally through the repository configuration. Although it has no apparent production runtime impact, lint-suppression configuration changes require human review.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

No code changes detected at 6c29816. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot5d ago
Synced from GitHub

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 0aa7721979ee88ecf6e8b0648acdb1691636383e and 6c29816d8698352da63eb8acb44d9dba0d2a701b.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 21fff5a0f38a2cab2439237f388fd8208d9e6527 and 0aa7721979ee88ecf6e8b0648acdb1691636383e.

External image Files selected for processing: 1
  • vite.config.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The Vite+ lint configuration now disables the unicorn/prefer-set-has rule.

Changes: Lint configuration

Layer / File(s)Summary
Lint rule setting
vite.config.ts		The configuration disables unicorn/prefer-set-has.

Priority: External image Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested labels: size:S

Suggested reviewers: t3dotgg

Merge Risk: External image Minimal · up to 0aa77

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely identifies the primary change: disabling the unicorn/prefer-set-has lint rule.
Description checkPassedThe description explains the problem, change, scope, and verification status. It provides specific validation results and identifies pending checks. Although it does not use the template headings and …
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, change, scope, and verification status. It provides specific validation results and identifies pending checks. Although it does not use the template headings and does not link to an issue or approval discussion, it gives sufficient context for this focused configuration change.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Added 1 commit

  • chore(lint): disable unicorn/prefer-set-has6c29816