Sign up
View stargazersSign up

chore(lint): disable react/jsx-no-constructed-context-values#25039

merged1
lint-rules/react-immutability
lint-rules/react-jsx-no-constructed-context-values
opened5d agobyJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

React Compiler owns context-value memoization. This rule is explicitly off, so these allowed patterns no longer emit advisory diagnostics.

This PR changes only this rule and its existing call sites. Each changed rule has its own PR.

Stack validation: rebased onto b76a110. The earlier 234-file test run passed, and the cancellation regression test passes after its local exception. Rebased format, lint, Knip, and all 34 affected-package typecheck tasks pass. The final local test rerun and fresh CI are pending.

Model: GPT-6.1 Sol. Harness: Codex.

Checks

24 successful · 11 skipped · 1 neutral
All checks passed
901f071
Ggithub-actionsBot5d ago
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—5.0 KiB—6.8 KiB✅
CodexThread snapshot wire—3.8 KiB—4.9 KiB✅
CodexLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
CodexLive turn WebSocket decoded—20.9 KiB—29.3 KiB✅
CodexLive turn messages—2—8✅
ClaudeTotal thread wire—5.0 KiB—6.8 KiB✅
ClaudeThread snapshot wire—3.8 KiB—4.9 KiB✅
ClaudeLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
ClaudeLive turn WebSocket decoded—21.2 KiB—29.3 KiB✅
ClaudeLive turn messages—2—8✅

Baseline: unavailable · PR result: 901f071 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBot5d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This one-line repository configuration change disables the React jsx-no-constructed-context-values lint diagnostic. It has no direct product runtime impact, but the lint-suppression directive requires human review under the applicable policy.

You can add or adjust custom eligibility rules. Learn more.

Added 1 commit

  • chore(lint): disable react/jsx-no-constructed-context-values901f071
CcoderabbitaiBot5d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 7a2472545e3a05795367d82636ae9705d44be05c and 901f0712c57237463fde6ce64b8dd540c5c5988d.

External image Files selected for processing: 1
  • vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The lint configuration now sets react/jsx-no-constructed-context-values to off at the base rule level.

Changes: Lint Rule Configuration

Layer / File(s)Summary
Disable the lint rule
vite.config.ts		The base lint configuration sets react/jsx-no-constructed-context-values to off.

Priority: External image Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: macroscopeapp, t3dotgg

Merge Risk: External image Minimal · up to 901f0

This lint-rule change is ready to merge after normal checks; no actionable compatibility or runtime risk is established.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check nameStatusExplanationResolution
Description checkWarningThe description explains the problem and the change. It says React Compiler owns context-value memoization, so the rule is explicitly off and the allowed patterns no longer emit advisory diagnostics. …Add a Scope and approval section. Link the triaged issue or the maintainer-approved discussion, with the approval comment. If no prior issue exists, explain why this focused configuration change of an established lint capability qualifies. …
Passed Passed checks: 3 passed
Check nameStatusExplanation
Title checkPassedThe title "chore(lint): disable react/jsx-no-constructed-context-values" matches the main change. The raw summary and PR objectives both say the change disables this lint rule at the base level. It us…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(lint): disable react/jsx-no-constructed-context-values" matches the main change. The raw summary and PR objectives both say the change disables this lint rule at the base level. It uses a conventional commit format and names the specific rule. The title is 60 characters and 3 words, so it is concise.

Full details: Description check

Explanation

The description explains the problem and the change. It says React Compiler owns context-value memoization, so the rule is explicitly off and the allowed patterns no longer emit advisory diagnostics. It also states the PR changes only this rule and its existing call sites. The Scope and approval section is missing. The template asks for a linked triaged issue or maintainer-approved discussion, or an explanation of why the focused configuration change qualifies. The Verification section gives some results, such as a 234-file test run and affected-package typecheck tasks. It does not state the final local test rerun or fresh CI results, which are still pending. The template also asks for the model and harness, and the description includes them.

Resolution

Add a Scope and approval section. Link the triaged issue or the maintainer-approved discussion, with the approval comment. If no prior issue exists, explain why this focused configuration change of an established lint capability qualifies. Explain what the rule option controls and why its effects stay within that capability. Use the Problem and Change headings from the template. Add a Problem section that states the expected behavior and reproduction steps or environment. Add a Change section that explains how disabling the rule fixes the problem. Complete the Verification section by listing the focused checks run and their observed results. Then state the pending final test rerun and CI checks, or report their results.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.