Sign up
View stargazersSign up

chore(lint): disable unicorn/no-new-array#25042

merged1
lint-rules/unicorn-no-array-reverse
lint-rules/unicorn-no-new-array
opened5d agobyJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Explicit array preallocation is allowed, including terminal hot paths. This rule is explicitly off, so these allowed patterns no longer emit advisory diagnostics.

This PR changes only this rule and its existing call sites. Each changed rule has its own PR.

Stack validation: rebased onto b76a110. The earlier 234-file test run passed, and the cancellation regression test passes after its local exception. Rebased format, lint, Knip, and all 34 affected-package typecheck tasks pass. The final local test rerun and fresh CI are pending.

Model: GPT-6.1 Sol. Harness: Codex.

Checks

23 successful · 13 skipped
All checks passed
add7df8
Ggithub-actionsBot5d ago
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—5.0 KiB—6.8 KiB✅
CodexThread snapshot wire—3.8 KiB—4.9 KiB✅
CodexLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
CodexLive turn WebSocket decoded—20.9 KiB—29.3 KiB✅
CodexLive turn messages—2—8✅
ClaudeTotal thread wire—5.0 KiB—6.8 KiB✅
ClaudeThread snapshot wire—3.8 KiB—4.9 KiB✅
ClaudeLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
ClaudeLive turn WebSocket decoded—21.2 KiB—29.3 KiB✅
ClaudeLive turn messages—1—8✅

Baseline: unavailable · PR result: add7df8 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBot5d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This PR globally disables the unicorn/no-new-array lint diagnostic in the shared lint configuration. Although it does not alter product runtime behavior, the added static-analysis suppression requires human review.

No code changes detected at add7df8. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Added 1 commit

  • chore(lint): disable unicorn/no-new-arrayadd7df8
CcoderabbitaiBot5d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 6f255673787febfb25e7e1a93b17e39eaefd8744 and add7df8261c9c09abf8bb56f23b4a50b17d36ba8.

External image Files selected for processing: 1
  • vite.config.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The lint configuration now disables unicorn/no-new-array.

Changes: Lint Configuration

Layer / File(s)Summary
Disable the array rule
vite.config.ts		The lint rules now disable unicorn/no-new-array.

Priority: External image Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: t3dotgg

Merge Risk: External image Minimal · up to add7d

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely identifies the main change: disabling the unicorn/no-new-array lint rule.
Description checkPassedThe description explains the problem, the change, the focused scope, and the verification performed. It also identifies pending final local tests and CI. The content is complete enough despite not usi…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the change, the focused scope, and the verification performed. It also identifies pending final local tests and CI. The content is complete enough despite not using the template headings.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Comment @coderabbitai help to get the list of available commands.