Sign up
View stargazersSign up

chore(lint): disable react/no-object-type-as-default-prop#25040

merged1
lint-rules/react-jsx-no-constructed-context-values
lint-rules/react-no-object-type-as-default-prop
opened5d agobyJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Default object values are allowed; compiler coverage and behavior checks govern memoization. This rule is explicitly off, so these allowed patterns no longer emit advisory diagnostics.

This PR changes only this rule and its existing call sites. Each changed rule has its own PR.

Stack validation: rebased onto b76a110. The earlier 234-file test run passed, and the cancellation regression test passes after its local exception. Rebased format, lint, Knip, and all 34 affected-package typecheck tasks pass. The final local test rerun and fresh CI are pending.

Model: GPT-6.1 Sol. Harness: Codex.

Checks

24 successful · 11 skipped · 1 neutral
All checks passed
e77c827
Ggithub-actionsBot5d ago
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—5.0 KiB—6.8 KiB✅
CodexThread snapshot wire—3.8 KiB—4.9 KiB✅
CodexLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
CodexLive turn WebSocket decoded—20.9 KiB—29.3 KiB✅
CodexLive turn messages—2—8✅
ClaudeTotal thread wire—5.0 KiB—6.8 KiB✅
ClaudeThread snapshot wire—3.8 KiB—4.9 KiB✅
ClaudeLive turn WebSocket wire—1.2 KiB—2.0 KiB✅
ClaudeLive turn WebSocket decoded—21.2 KiB—29.3 KiB✅
ClaudeLive turn messages—1—8✅

Baseline: unavailable · PR result: e77c827 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBot5d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This one-line configuration change disables a React lint diagnostic across the repository, reducing static-analysis coverage while leaving application runtime behavior unchanged. Human review is warranted for the global suppression of this diagnostic.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot5d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 901f0712c57237463fde6ce64b8dd540c5c5988d and e77c827a81e312ef4bd7ae1fa92a6ff339d8b1b5.

External image Files selected for processing: 1
  • vite.config.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The Vite+ lint configuration now disables the react/no-object-type-as-default-prop rule.

Changes: Lint configuration

Layer / File(s)Summary
Disable React lint rule
vite.config.ts		The lint configuration sets react/no-object-type-as-default-prop to off.

Priority: External image Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: size:XS

Suggested reviewers: t3dotgg, macroscopeapp

Merge Risk: External image Minimal · up to e77c8

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check nameStatusExplanationResolution
Description checkWarningThe description explains the rule change and its effect: default object values are allowed, and the advisory diagnostics for those patterns no longer appear. It also reports rebase, lint, Knip, typech…Add or revise these template sections:
1. Problem: state the problem in one or two sentences. Explain why the advisory diagnostics on default object values are unwanted, and give a reproduction or example file if one applies.
2. Change: sta…
Passed Passed checks: 3 passed
Check nameStatusExplanation
Title checkPassedThe title "chore(lint): disable react/no-object-type-as-default-prop" names the single change in the changeset: the Vite+ lint config now turns off react/no-object-type-as-default-prop. It is a conven…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(lint): disable react/no-object-type-as-default-prop" names the single change in the changeset: the Vite+ lint config now turns off react/no-object-type-as-default-prop. It is a conventional commit title, specific, and concise. It does not mention the existing call-site updates, but that detail is secondary.

Full details: Description check

Explanation

The description explains the rule change and its effect: default object values are allowed, and the advisory diagnostics for those patterns no longer appear. It also reports rebase, lint, Knip, typecheck, and test status, and names the model and harness. It does not follow the repository template. The Problem section is missing, and the Change, Scope and approval, and Verification sections are only partly covered. There is no linked triaged issue or maintainer approval, and the author does not explain why the focused configuration change qualifies without one. The verification is also incomplete: the earlier 234-file run and the regression test are reported, but the final local test rerun and CI are still pending.

Resolution

Add or revise these template sections:

  1. Problem: state the problem in one or two sentences. Explain why the advisory diagnostics on default object values are unwanted, and give a reproduction or example file if one applies.
  2. Change: state that the change disables react/no-object-type-as-default-prop in vite.config.ts and updates the existing call sites. Explain why those call-site edits are needed for this change.
  3. Scope and approval: link the triaged issue or the maintainer discussion that approved this direction. If none exists, explain why this focused configuration of an established lint capability qualifies without prior approval. Explain what the rule option controls and why its effects stay within the lint capability.
  4. Verification: list the focused checks you ran and their observed results. State which checks are still pending, namely the final local test rerun and the CI run. Remove the wording that reports the earlier run as current if the rebase changed the results.
  5. Keep the model and harness line at the end, as the template requests.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Comment @coderabbitai help to get the list of available commands.

Added 1 commit

  • chore(lint): disable react/no-object-type-as-default-prope77c827