refactor(android): every header goes through AppBar, so the filter stays put#26741

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: t3/fix-android-filter-icon-shift
• File: .coderabbit.config.ts
• Commit: 41db677
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 6f9623fe-9a57-4f7e-a4e5-f8ac1c133f4b

External image Commits

Reviewing files that changed from the base of the PR and between 338ac790992f968e13206cc489626d0abeca2773 and 41db6777aa386590dd9e383d00294e9ac2943a10.

External image Files selected for processing: 5

• apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
• apps/mobile/src/features/pull-requests/guide/PullRequestGuideScreen.tsx
• apps/mobile/src/features/threads/git/GitBranchesSheet.occupancy.test.tsx
• apps/mobile/vite.config.ts
• vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

The changes extend Android AppBar with search, menu, native-action, and workspace-header support. Android screens and sheets switch to AppBar. Settings routes pass environment filters as menus.

Changes: Shared Android AppBar

Layer / File(s)	Summary
AppBar contracts and rendering apps/mobile/src/components/ui/AppBar.types.ts, apps/mobile/src/components/ui/AppBar.android.tsx, apps/mobile/src/components/ui/AppBar.tsx, apps/mobile/src/components/ui/NativeAppBar.android.tsx, apps/mobile/src/components/ui/menuActionItems.ts, apps/mobile/src/components/ui/headerMenu.android.ts, apps/mobile/assets/icons/*, apps/mobile/src/components/ui/*test*	AppBar adds controlled search state, title and leading content, embedded and sheet options, menu fields, native action slots, search overlays, and menu conversion. Tests and Android icon assets are added.
Workspace app bar and toolbar integration apps/mobile/src/components/ui/WorkspaceAppBar.android.tsx, apps/mobile/src/features/workspace/*, apps/mobile/src/features/home/ThreadListToolbar*, apps/mobile/src/features/pull-requests/PullRequestToolbar.android.tsx, apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx, apps/mobile/src/features/home/HomeHeader.android.tsx	Workspace tabs publish header content to a scoped app bar. Home and pull-request toolbars provide search and filter actions. The thread sidebar updates filter callbacks and sticky-header sizing.
Settings environment menus apps/mobile/src/features/settings/components/*, apps/mobile/src/features/settings/*RouteScreen.tsx, apps/mobile/src/features/usage/UsageRouteScreen.tsx	Settings screens receive environment filters through the AppBar menus prop. The environment-menu hook returns selectable items, and scheduled-task creation uses a SettingsScreen action on Android.
Screen and sheet header migration apps/mobile/src/components/ui/AndroidScreenHeader.tsx, apps/mobile/src/components/ui/Sheet*.tsx, apps/mobile/src/features/{connection,files,home,pull-requests,review,settings,threads,workspace}/*, apps/mobile/src/Stack.tsx, vite.config.ts, apps/mobile/vite.config.ts	Android screen and sheet headers switch to AppBar with embedded or sheet options. The AndroidSheetHeader wrapper is removed, and lint rules restrict imports of the retired headers.

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Refactor

Sequence Diagram(s)

mermaid

1	sequenceDiagram
2	participant WorkspaceAppBar
3	participant WorkspaceAppBarStore
4	participant WorkspaceAppBarScope
5	WorkspaceAppBar->>WorkspaceAppBarStore: Publish header props and owner
6	WorkspaceAppBarStore-->>WorkspaceAppBarScope: Notify of updated props
7	WorkspaceAppBarScope->>WorkspaceAppBarStore: Read current header props

Suggested labels: bugfix, 📱 Native Change

Suggested reviewers: maria-rcks, t3dotgg

Android toolbar paths remain within their required scope, and migrated pull-request headers retain their actions.

Check name	Status	Explanation
Title check	Passed	The title names the main change: Android headers now route through AppBar, which keeps the filter in a fixed position. It follows the conventional commit form and is one sentence. It is a little dense…
Description check	Passed	The description follows the template sections (Problem, Change, Scope and approval, Verification). It explains the inconsistent Android header layouts and the filter position drift, and describes the …
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: Android headers now route through AppBar, which keeps the filter in a fixed position. It follows the conventional commit form and is one sentence. It is a little dense, but it matches the changeset, which converts Android headers, sheets, and filters to AppBar.

Full details: Description check

Explanation

The description follows the template sections (Problem, Change, Scope and approval, Verification). It explains the inconsistent Android header layouts and the filter position drift, and describes the AppBar contract, the workspace bar, menus, search, the lint rule, and iOS impact. Verification includes device-specific frame results, screenshots, and the tests added. The Scope and approval section is missing: it gives no linked issue, maintainer discussion, or justification for a change of this size, which the template requires. The Problem section is also not separated from the Change section under its own heading. The description is mostly complete, but these gaps are notable.

Resolution

Add the links to the triaged issue or maintainer-approved discussion under a "Scope and approval" heading. The template asks for this. Label the opening paragraph as "Problem" and move the Change bullets under a "Change" heading. The template also asks for the model and harness used, which the description covers in its last line.

Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB