perf(server): index active thread sweep expressions #21777 · pingdotgg/t3code

MmacroscopeappBotreviewed · review dismissed8d ago

Approvability

Verdict: Approved at e1e8523

Macroscope's review found this PR approvable — This is a focused performance optimization that adds a partial expression index and avoids repeated JSON parsing on existing active-thread queries. Migration coverage verifies index behavior and preserves existing paths without changing product defaults or introducing new user-facing capability.

^{You can add or adjust custom eligibility rules. Learn more.}

Ggithub-actionsBot8d ago

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	4.9 KiB	—	6.8 KiB	✅
Codex	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Codex	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Codex	Live turn WebSocket decoded	—	20.8 KiB	—	29.3 KiB	✅
Codex	Live turn messages	—	1	—	8	✅
Claude	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Claude	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Claude	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Claude	Live turn WebSocket decoded	—	21.2 KiB	—	29.3 KiB	✅
Claude	Live turn messages	—	2	—	8	✅

Baseline: unavailable · PR result: e1e8523 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

CcoderabbitaiBot8d ago

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Team
Run ID: 8d51a3ec-ec30-4b3f-be01-faa5902b210f

📥 Commits

Reviewing files that changed from the base of the PR and between 64bf54a31659dd8038203f3550d550eef0615241 and e1e852385850be20ab6740fa0d4608495027b7d3.

📒 Files selected for processing: 3

apps/server/src/persistence/Migrations/055_OrchestrationV2.test.ts
apps/server/src/persistence/Migrations/064_CanonicalizeThreadPullRequestLinks.test.ts
apps/server/src/persistence/reconcileV2PreviewMigration.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Migration 65 adds a partial index for active projection threads. Three queries now use archived_at to filter archived threads. Migration tests cover the query behavior, migration registration, and rerun expectations.

Changes: Active projection thread sweep

Layer / File(s)	Summary
Register the active-thread index `apps/server/src/persistence/Migrations/065_ProjectionThreadSweepIndexes.ts`, `apps/server/src/persistence/Migrations.ts`, `apps/server/src/persistence/Migrations/055_OrchestrationV2.test.ts`, `apps/server/src/persistence/Migrations/064_CanonicalizeThreadPullRequestLinks.test.ts`, `apps/server/src/persistence/reconcileV2PreviewMigration.test.ts`	Migration 65 creates a composite index for rows where `deleted_at` and `archived_at` are `NULL`. The migration registry and migration tests include migration 65.
Use the archive column in active-thread queries `apps/server/src/orchestration-v2/ProjectionStore.ts`, `apps/server/src/persistence/Migrations.test.ts`	Three queries use `archived_at` to exclude archived threads. The migration test checks sweep query results, JSON function opcodes, archive and override changes, and migration idempotency.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: yash-singh1

Merge Risk: ⚪ Minimal · up to e1e85

The change preserves sweep eligibility for supported data paths and updates migration expectations. No merge-blocking behavior risk was identified; normal CI checks and required approvals remain outstanding.

Pre-merge checks: ^Passed 4

Check name	Status	Explanation
Title check	Passed	The title is concise, conventional, and clearly identifies the primary change: adding an index for active thread sweep expressions.
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.
Description check	Passed	The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the issue, implementation, scope, linked investigation and takeover approval, focused…

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the issue, implementation, scope, linked investigation and takeover approval, focused validation, performance measurements, outstanding approvals, and agent details. It also clearly states that the pull request is not merge-ready.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

MmacroscopeappBotapproved these changes8d ago

perf(server): index active thread sweep expressions#21777

Problem

Change

Scope and approval

Verification

Checks

Approvability

Thread transfer impact