[codex] Prevent background Git fetches from leaking temp packs#3537

closed7

main

codex/fix-git-fetch-temp-pack-leaks

openedJun 23, 2026byJJulius Marminge

View on GitHubTwo-way sync enabledPR last imported 3d ago

16 unresolved threads · Jump to file

Selected thread: apps/server/src/resourceTelemetry/Model.ts:456 — 🟡 **Medium** `resourceTelemetry/Model.ts:456` `mergeProcesses` classifies a process as `electron-main` solely because its PID is in `electronRootPids`, without validating the process start time against the desktop metric's `creationTimeMs`. When a stale desktop snapshot is replayed and the PID has been reused by an unrelated process (e.g. a server child), that process and its descendants are misattributed to Electron. The same stale PID is correctly rejected by `metricsByPid` via the `ELECTRON_IDENTITY_TOLERANCE_MS` check, but the `explicitElectronRootPids.has(process.pid)` branch bypasses that validation. Consider keying `electronRootPids` by process identity (PID + start time) or validating the start time before classifying a root as `electron-main`. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary> ```text In file @apps/server/src/resourceTelemetry/Model.ts around line 456: `mergeProcesses` classifies a process as `electron-main` solely because its PID is in `electronRootPids`, without validating the process start time against the desktop metric's `creationTimeMs`. When a stale desktop snapshot is replayed and the PID has been reused by an unrelated process (e.g. a server child), that process and its descendants are misattributed to Electron. The same stale PID is correctly rejected by `metricsByPid` via the `ELECTRON_IDENTITY_TOLERANCE_MS` check, but the `explicitElectronRootPids.has(process.pid)` branch bypasses that validation. Consider keying `electronRootPids` by process identity (PID + start time) or validating the start time before classifying a root as `electron-main`. ``` </details>

0 / 100 viewed100 files changedLine totals unavailable

apps/server/src/diagnostics/ProcessDiagnostics.ts · File comment

macroscopeappBotJul 29, 2026

🟡 Medium

https://github.com/pingdotgg/t3code/blob/58340604f0b7967e7a5a3e532993f3443442d14e/apps/server/src/diagnostics/ProcessDiagnostics.ts#L1

The read function filters only the server PID out of snapshot.processes, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates processCount, totalRssBytes, and totalCpuPercent, and their depth is clamped to 0 via Math.max(0, entry.depth - 1) even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

text

1	In file @apps/server/src/diagnostics/ProcessDiagnostics.ts around line 1:
2
3	The `read` function filters only the server PID out of `snapshot.processes`, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates `processCount`, `totalRssBytes`, and `totalCpuPercent`, and their `depth` is clamped to `0` via `Math.max(0, entry.depth - 1)` even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.