[codex] Prevent background Git fetches from leaking temp packs#3537

closed7

main

codex/fix-git-fetch-temp-pack-leaks

openedJun 23, 2026byJJulius Marminge

View on GitHubTwo-way sync enabledPR last imported 3d ago

16 unresolved threads · Jump to file

Selected thread: apps/server/src/resourceTelemetry/NativeTelemetryClient.ts:652 — 🟡 **Medium** `resourceTelemetry/NativeTelemetryClient.ts:652` `setHostPowerState` and `changeLiveSubscriberCount` both atomically update `collectionControl` and then send commands to the sidecar, but the read-modify-send sequence is not protected across the two operations. When they run concurrently, the one whose `Ref.modify` executes first can have its commands delivered second, so the sidecar ends up with stale settings. For example, if a subscriber arrives while a host-power update is in flight, the power update's stale `sampleIntervalMs`/`setStreaming` commands can overwrite the subscriber's newer commands, leaving the sidecar at the wrong interval or with streaming disabled despite an active subscriber. Consider serializing the full read-modify-send sequence (e.g., with a dedicated mutex around both the `Ref.modify` and the `applyCollectionControl` call) so command delivery order always matches control-update order. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary> ```text In file @apps/server/src/resourceTelemetry/NativeTelemetryClient.ts around line 652: `setHostPowerState` and `changeLiveSubscriberCount` both atomically update `collectionControl` and then send commands to the sidecar, but the read-modify-send sequence is not protected across the two operations. When they run concurrently, the one whose `Ref.modify` executes first can have its commands delivered second, so the sidecar ends up with stale settings. For example, if a subscriber arrives while a host-power update is in flight, the power update's stale `sampleIntervalMs`/`setStreaming` commands can overwrite the subscriber's newer commands, leaving the sidecar at the wrong interval or with streaming disabled despite an active subscriber. Consider serializing the full read-modify-send sequence (e.g., with a dedicated mutex around both the `Ref.modify` and the `applyCollectionControl` call) so command delivery order always matches control-update order. ``` </details>

0 / 100 viewed100 files changedLine totals unavailable

apps/server/src/diagnostics/ProcessDiagnostics.ts · File comment

macroscopeappBotJul 29, 2026

🟡 Medium

https://github.com/pingdotgg/t3code/blob/58340604f0b7967e7a5a3e532993f3443442d14e/apps/server/src/diagnostics/ProcessDiagnostics.ts#L1

The read function filters only the server PID out of snapshot.processes, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates processCount, totalRssBytes, and totalCpuPercent, and their depth is clamped to 0 via Math.max(0, entry.depth - 1) even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

text

1	In file @apps/server/src/diagnostics/ProcessDiagnostics.ts around line 1:
2
3	The `read` function filters only the server PID out of `snapshot.processes`, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates `processCount`, `totalRssBytes`, and `totalCpuPercent`, and their `depth` is clamped to `0` via `Math.max(0, entry.depth - 1)` even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.