Sign up
View stargazers13Sign up

[codex] Prevent background Git fetches from leaking temp packs#3537

closed7
main
codex/fix-git-fetch-temp-pack-leaks
openedJun 23, 2026byJJulius Marminge
100+ files changed
View on GitHubTwo-way sync enabledPR last imported 3d ago
16 unresolved threads · Jump to file
Selected thread: apps/server/src/resourceTelemetry/ResourceTelemetryHistory.ts:149 — 🟡 **Medium** `resourceTelemetry/ResourceTelemetryHistory.ts:149` `buildResourceTelemetryHistory` filters snapshots only with a lower bound (`>= windowStartMs`), so snapshots with `sampledAtUnixMs > readAtMs` pass through. Those snapshots are excluded from every bucket by `buildBuckets` (which caps each bucket's end at `nowMs`), but they are still iterated into `processSamples` and counted in `retainedSampleCount`, so the returned history has buckets that omit the latest snapshots while `topProcesses` includes them — and the process "current" values can be later than `readAt`. Add an upper-bound filter (`sampledAtUnixMs <= readAtMs`) alongside the existing lower-bound filter. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary> ```text In file @apps/server/src/resourceTelemetry/ResourceTelemetryHistory.ts around line 149: `buildResourceTelemetryHistory` filters snapshots only with a lower bound (`>= windowStartMs`), so snapshots with `sampledAtUnixMs > readAtMs` pass through. Those snapshots are excluded from every bucket by `buildBuckets` (which caps each bucket's end at `nowMs`), but they are still iterated into `processSamples` and counted in `retainedSampleCount`, so the returned history has buckets that omit the latest snapshots while `topProcesses` includes them — and the process "current" values can be later than `readAt`. Add an upper-bound filter (`sampledAtUnixMs <= readAtMs`) alongside the existing lower-bound filter. ``` </details>
0 / 100 viewed100 files changedLine totals unavailable

apps/server/src/diagnostics/ProcessDiagnostics.ts · File comment

M
macroscopeappBotJul 29, 2026

🟡 Medium

https://github.com/pingdotgg/t3code/blob/58340604f0b7967e7a5a3e532993f3443442d14e/apps/server/src/diagnostics/ProcessDiagnostics.ts#L1

The read function filters only the server PID out of snapshot.processes, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates processCount, totalRssBytes, and totalCpuPercent, and their depth is clamped to 0 via Math.max(0, entry.depth - 1) even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
text
1In file @apps/server/src/diagnostics/ProcessDiagnostics.ts around line 1:
2
3The `read` function filters only the server PID out of `snapshot.processes`, so independent Electron roots and the resource-monitor process are returned as server child processes. This inflates `processCount`, `totalRssBytes`, and `totalCpuPercent`, and their `depth` is clamped to `0` via `Math.max(0, entry.depth - 1)` even though they are not descendants of the server. The filter at line 78 should restrict the list to the server/backend descendant tree rather than all telemetry processes.