The server export audit was clean locally but was not part of the long-term Knip gate. This adds apps/server to the runtime-export check and documents the explicit rules for exported types, Effect schemas, and canonical Effect service construction APIs.
This is layer 9 of 9 in the server Knip cleanup stack.
Verification after rebasing onto current main: server typecheck and the server-only Knip export audit pass. Changed-file lint and formatting pass, with one existing lint warning. Focused auth, provider, source-control, preview toolkit, orchestration, and Knip preprocessor tests pass: 90 tests across 9 files. This changes server export visibility and static analysis; screenshots do not apply.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Documentation
Chores
Note
apps/serverapps/server to the export-analysis portion of the root knip:check script in package.json and documents the expanded coverage in development.md.makeWithProviders function in SourceControlProviderRegistry.ts with a @public JSDoc tag so Knip recognizes it as a canonical public API.PreviewStatusTool, PreviewOpenTool, etc.) will break; in-tree usages are already updated.Macroscope summarized 1535b27.
Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.
A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.
Verdict: Approved at 6e9b8ad
Macroscope's review found this PR approvable — This PR only expands an existing Knip export check to the server workspace and documents the convention; it does not change product runtime behavior or defaults. Its impact is limited to CI and developer validation failures for newly detected unused exports.
No code changes detected at 1535b27. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 13.6 KiB | 13.6 KiB | −16 B (−0.1%) | 15.1 KiB | ✅ |
| Codex | Thread snapshot wire | 7.0 KiB | 7.0 KiB | −10 B (−0.1%) | 7.3 KiB | ✅ |
| Codex | Live turn WebSocket wire | 6.6 KiB | 6.6 KiB | −6 B (−0.1%) | 7.8 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 57.1 KiB | 57.1 KiB | 0 B (0.0%) | 66.4 KiB | ✅ |
| Codex | Live turn messages | 10 | 10 | 0 (0.0%) | 21 | ✅ |
| Claude | Total thread wire | 13.6 KiB | 13.6 KiB | +33 B (+0.2%) | 15.1 KiB | ✅ |
| Claude | Thread snapshot wire | 7.1 KiB | 7.1 KiB | 0 B (0.0%) | 7.3 KiB | ✅ |
| Claude | Live turn WebSocket wire | 6.5 KiB | 6.5 KiB | +33 B (+0.5%) | 7.8 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 57.8 KiB | 57.8 KiB | +44 B (+0.1%) | 66.4 KiB | ✅ |
| Claude | Live turn messages | 8 | 9 | +1 (+12.5%) | 21 | ✅ |
Baseline: 1f0a14c · PR result: 1535b27 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.
A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.
Review Change StackReview Change Stack
No actionable comments were generated in the recent review. 🎉
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 634465cb-dee1-4939-8b93-2a283b71868b
Reviewing files that changed from the base of the PR and between 72f32c81d5c3a5a09acbd0da96dd0d2299c5e789 and e7ec5ca95f447307914a87a89f02774ed74b86de.
docs/operations/development.mdpackage.jsonIncluded review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.
The Knip check now scans apps/server. The development guide documents the expanded scan and the @public exemption for canonical Effect service construction APIs.
Knip coverage
| Layer / File(s) | Summary |
|---|---|
Configure and document Knip coverage package.json, docs/operations/development.md | The knip:check script adds apps/server. The development guide documents runtime-export checks and @public annotations. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Merge Risk: ⚪ Minimal · up to 1535b
This expands unused-export checking to the server workspace and documents the existing public API annotation convention. The change does not alter runtime behavior and is ready to merge.
Suggested reviewers: t3dotgg
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | ✅ Passed | The title clearly identifies the primary change: enforcing server export checks with Knip. |
| Description check | ✅ Passed | The description explains what changed, why it changed, verification results, test coverage, and why screenshots do not apply. It does not use the template headings or include the checklist, but the re… |
cleanup-server/knip-gateComment @coderabbitai help to get the list of available commands.
Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.
A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.
Added 1 commit
All clear
Posted via Macroscope — Effect Service Conventions
All clear
Posted via Macroscope — Effect Service Conventions