refactor(server): classify telemetry exports #10277 · pingdotgg/t3code

MmacroscopeappBotreviewed · review dismissedSep 6, 2026

MmacroscopeappBotSep 6, 2026

Approvability

A prior Macroscope approval was dismissed. Re-evaluating 40fea11…

No code changes detected at 71d237b. Prior analysis still applies.

Ggithub-actionsBotSep 6, 2026

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	13.6 KiB	—	15.1 KiB	✅
Codex	Thread snapshot wire	—	7.0 KiB	—	7.3 KiB	✅
Codex	Live turn WebSocket wire	—	6.5 KiB	—	7.8 KiB	✅
Codex	Live turn WebSocket decoded	—	57.0 KiB	—	66.4 KiB	✅
Codex	Live turn messages	—	8	—	21	✅
Claude	Total thread wire	—	13.6 KiB	—	15.1 KiB	✅
Claude	Thread snapshot wire	—	7.0 KiB	—	7.3 KiB	✅
Claude	Live turn WebSocket wire	—	6.5 KiB	—	7.8 KiB	✅
Claude	Live turn WebSocket decoded	—	57.8 KiB	—	66.4 KiB	✅
Claude	Live turn messages	—	9	—	21	✅

Baseline: unavailable · PR result: 71d237b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.9 KiB
Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

CcursorBotSep 8, 2026

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

CcoderabbitaiBotSep 8, 2026

Review Change Stack Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 70066dd7-f1be-4492-8b52-a21465f36956

📥 Commits

Reviewing files that changed from the base of the PR and between 4f890a2689834d586693264eb984b6392359c77d and 71d237b15304d483225aa9c5136618396b38db12.

📒 Files selected for processing (16)

apps/server/integration/NetworkTransferMeasurement.integration.ts
apps/server/integration/TransferBudgetReport.integration.ts
apps/server/integration/TransferBudgetScenario.integration.ts
apps/server/src/diagnostics/ProcessDiagnostics.ts
apps/server/src/diagnostics/ProcessResourceMonitor.ts
apps/server/src/diagnostics/TraceDiagnostics.ts
apps/server/src/resourceTelemetry/DesktopTelemetryReceiver.ts
apps/server/src/resourceTelemetry/Model.ts
apps/server/src/resourceTelemetry/NativeTelemetryClient.ts
apps/server/src/resourceTelemetry/ResourceMonitorBinary.ts
apps/server/src/resourceTelemetry/ResourceTelemetry.ts
apps/server/src/telemetry/AnalyticsService.ts
apps/server/src/usage/UsageLimitSources.ts
apps/server/src/usage/usageAggregation.ts
apps/server/src/usage/usageScanCache.ts
apps/server/src/usage/usageTranscripts.ts

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

Walkthrough

The changes narrow module exports for internal helpers and constants. They also add public API documentation to canonical Effect service constructors.

Changes

API surface cleanup

Layer / File(s)	Summary
Integration helper visibility `apps/server/integration/*`	WebSocket measurement helpers and transfer budget constants are now module-private.
Diagnostics and resource telemetry API `apps/server/src/diagnostics/`, `apps/server/src/resourceTelemetry/`	Resource telemetry helpers are narrowed to module scope, and service constructors receive public API documentation.
Analytics and usage API `apps/server/src/telemetry/AnalyticsService.ts`, `apps/server/src/usage/*`	Analytics and usage helpers are narrowed to module scope, while service construction receives public API documentation.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 71d23

This refactor makes internal telemetry, diagnostics, resource-monitoring, and usage helpers private while documenting canonical service constructors. No current-head runtime or contract regression is identified, so the change is ready to merge.

Suggested reviewers: t3dotgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 16 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: classifying server telemetry-related exports.
Description check	✅ Passed	The description explains the export classification, scope, rationale, verification, and UI applicability. It does not use the template headings or include the checklist, but the required information i…

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cleanup-server/telemetry-usage-internals

_{Comment @coderabbitai help to get the list of available commands.}

refactor(server): classify telemetry exports#10277

Summary by CodeRabbit