Source-control and pull-request modules had 26 unclassified runtime exports. This marks 13 canonical Effect service constructors as intentionally public, narrows local parsing and formatting helpers, and removes four redundant generic provider layers whose modules do not own the service tag.
This is layer 6 of 9 in the server Knip cleanup stack.
Verification after rebasing onto current main: server typecheck and the server-only Knip export audit pass. Changed-file lint and formatting pass, with one existing lint warning. Focused auth, provider, source-control, preview toolkit, orchestration, and Knip preprocessor tests pass: 90 tests across 9 files. This changes server export visibility and static analysis; screenshots do not apply.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Documentation
Refactor
Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.
A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.
✅ Thread transfer remains within every enforced ceiling.
ℹ️ No successful
mainbaseline artifact is available yet. This run establishes the initial measurement.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | — | 13.6 KiB | — | 15.1 KiB | ✅ |
| Codex | Thread snapshot wire | — | 7.0 KiB | — | 7.3 KiB | ✅ |
| Codex | Live turn WebSocket wire | — | 6.6 KiB | — | 7.8 KiB | ✅ |
| Codex | Live turn WebSocket decoded | — | 57.1 KiB | — | 66.4 KiB | ✅ |
| Codex | Live turn messages | — | 10 | — | 21 | ✅ |
| Claude | Total thread wire | — | 13.6 KiB | — | 15.1 KiB | ✅ |
| Claude | Thread snapshot wire | — | 7.0 KiB | — | 7.3 KiB | ✅ |
| Claude | Live turn WebSocket wire | — | 6.5 KiB | — | 7.8 KiB | ✅ |
| Claude | Live turn WebSocket decoded | — | 57.8 KiB | — | 66.4 KiB | ✅ |
| Claude | Live turn messages | — | 9 | — | 21 | ✅ |
Baseline: unavailable · PR result: 3006c87 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Verdict: Approved at 0f3e28d
Macroscope's review found this PR approvable — This is a bounded internal server export cleanup: active provider construction and source-control behavior remain unchanged, while unused wrappers and helpers are made private or removed. No product defaults, static-analysis suppressions, schema changes, or production behavior changes are involved.
No code changes detected at 3006c87. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
Added 1 commit
Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.
A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.
Review Change StackReview Change Stack
No actionable comments were generated in the recent review. 🎉
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: d5647126-4e5b-4e08-a946-dc9ea539234f
Reviewing files that changed from the base of the PR and between 375ccee2e02f7813c81301724d12be054af1e5b1 and 3006c8731afadb92c6bda06891c29bfe01387539.
![cursor[bot]](https://avatars.githubusercontent.com/u/206951365?s=80)
apps/server/src/pullRequest/AzureDevOpsPullRequestCli.tsapps/server/src/pullRequest/BitbucketPullRequestApi.tsapps/server/src/pullRequest/GitHubPullRequestCli.tsapps/server/src/pullRequest/GitLabPullRequestCli.tsapps/server/src/pullRequest/PullRequestProviderRegistry.tsapps/server/src/sourceControl/AzureDevOpsCli.tsapps/server/src/sourceControl/AzureDevOpsSourceControlProvider.tsapps/server/src/sourceControl/BitbucketApi.tsapps/server/src/sourceControl/BitbucketSourceControlProvider.tsapps/server/src/sourceControl/GitHubCli.tsapps/server/src/sourceControl/GitHubSourceControlProvider.tsapps/server/src/sourceControl/GitLabCli.tsapps/server/src/sourceControl/GitLabSourceControlProvider.tsapps/server/src/sourceControl/SourceControlDiscovery.tsapps/server/src/sourceControl/SourceControlProvider.tsapps/server/src/sourceControl/SourceControlProviderDiscovery.tsapps/server/src/sourceControl/SourceControlRateLimit.tsapps/server/src/sourceControl/SourceControlRepositoryService.tsapps/server/src/sourceControl/azureDevOpsPullRequests.tsapps/server/src/sourceControl/gitHubPullRequests.tsapps/server/src/sourceControl/gitLabMergeRequests.tsapps/server/src/sourceControl/githubGraphQlBudget.tsIncluded review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.
The change documents Effect service constructors as public APIs and narrows module exports. It removes selected helper exports, schema error aliases, and prebuilt source-control provider layers without changing provider or helper behavior.
Effect API surface cleanup
| Layer / File(s) | Summary |
|---|---|
Document public service constructors apps/server/src/pullRequest/*, apps/server/src/sourceControl/* | Adds @public documentation to service-construction exports. |
Internalize helper and formatting exports apps/server/src/pullRequest/GitHubPullRequestCli.ts, apps/server/src/sourceControl/* | Makes selected helpers module-private and removes schema error formatting aliases and unused imports. |
Remove provider layer exports apps/server/src/sourceControl/*SourceControlProvider.ts | Removes exported provider layer values and their unused Layer imports. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk: ⚪ Minimal · up to 3006c
This change narrows server module exports and documents intended public service constructors without a described runtime behavior change. No concrete merge-blocking risk remains.
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 15.79% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 18 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title is concise and accurately summarizes the primary change: classifying source-control exports in the server. |
| Description check | ✅ Passed | The description clearly explains what changed, why it changed, scope, verification results, and why screenshots do not apply. It does not use the template headings or checklist, but it provides the re… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
cleanup-server/source-control-internalsComment @coderabbitai help to get the list of available commands.