The source-control registry's alternate constructor is part of the module-owned Effect service API even though the runtime currently uses the default constructor. This marks it explicitly public so Knip preserves the construction seam without a broad ignore.
This is layer 7 of 9 in the server Knip cleanup stack.
Verification after rebasing onto current main: server typecheck and the server-only Knip export audit pass. Changed-file lint and formatting pass, with one existing lint warning. Focused auth, provider, source-control, preview toolkit, orchestration, and Knip preprocessor tests pass: 90 tests across 9 files. This changes server export visibility and static analysis; screenshots do not apply.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Note
sourceControl servicesexport from many internal helpers, constants, error guards, and factory functions across the server, making them module-private. The public service constructors and manifest exports remain.apps/server/src, especially in sourceControl provider and registry modules.Layer imports and the exported layer wrappers in AzureDevOpsSourceControlProvider.ts, BitbucketSourceControlProvider.ts, GitHubSourceControlProvider.ts, and GitLabSourceControlProvider.ts; the provider constructors themselves remain exported.formatSchemaError imports and the exported format*JsonDecodeError aliases in the Azure DevOps, GitHub, and GitLab pull-request JSON helper modules.defaultTextGenerationPolicy, makeServerLayer, isGitLabCliError, defaultInstanceIdForDriver) will fail to compile. All in-tree references are updated, but out-of-tree or downstream code relying on these exports will break.Macroscope summarized b0e2bc4.
Verdict: Approved at 7569305
Macroscope's review found this PR approvable — The PR only adds an established @public documentation annotation to an existing Effect service constructor. It changes API metadata rather than executable behavior, configuration, defaults, or production workflows.
No code changes detected at c0a3f57. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 13.6 KiB | 13.6 KiB | −12 B (−0.1%) | 15.1 KiB | ✅ |
| Codex | Thread snapshot wire | 7.0 KiB | 7.1 KiB | +9 B (+0.1%) | 7.3 KiB | ✅ |
| Codex | Live turn WebSocket wire | 6.6 KiB | 6.6 KiB | −21 B (−0.3%) | 7.8 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 57.1 KiB | 57.1 KiB | 0 B (0.0%) | 66.4 KiB | ✅ |
| Codex | Live turn messages | 10 | 10 | 0 (0.0%) | 21 | ✅ |
| Claude | Total thread wire | 13.6 KiB | 13.6 KiB | −18 B (−0.1%) | 15.1 KiB | ✅ |
| Claude | Thread snapshot wire | 7.0 KiB | 7.0 KiB | −6 B (−0.1%) | 7.3 KiB | ✅ |
| Claude | Live turn WebSocket wire | 6.6 KiB | 6.6 KiB | −12 B (−0.2%) | 7.8 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 57.9 KiB | 57.9 KiB | 0 B (0.0%) | 66.4 KiB | ✅ |
| Claude | Live turn messages | 10 | 10 | 0 (0.0%) | 21 | ✅ |
Baseline: 3b6ce93 · PR result: c0a3f57 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Review Change StackReview Change Stack
No actionable comments were generated in the recent review. 🎉
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: a546249f-ed43-44af-87ab-8b5ab40eb60d
Reviewing files that changed from the base of the PR and between 3006c8731afadb92c6bda06891c29bfe01387539 and b0e2bc4a9f407af4b55224e32a61e04060d0747e.
apps/server/src/sourceControl/SourceControlProviderRegistry.tsIncluded review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.
The change adds a JSDoc @public comment above the exported makeWithProviders function. Runtime behavior and exported declarations remain unchanged.
Source control API documentation
| Layer / File(s) | Summary |
|---|---|
Document makeWithProviders construction apps/server/src/sourceControl/SourceControlProviderRegistry.ts | The exported function now documents service construction as part of the canonical Effect module API. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Merge Risk: ⚪ Minimal · up to c0a3f
This change documents the source-control registry construction API without changing runtime behavior or exported declarations. It is ready to merge.
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | ✅ Passed | The title clearly identifies the source-control registry API classification and matches the main change. |
| Description check | ✅ Passed | The description explains what changed, why it changed, scope, verification results, and why UI evidence does not apply. It does not use the template headings, but it provides the required information … |
cleanup-server/source-control-registryComment @coderabbitai help to get the list of available commands.
Added 1 commit