ci: enforce runtime exports while allowing types and schemas#10171

merged3
cleanup-packages/domain-contracts
cleanup-packages/knip-gate
openedSep 5, 2026byJJulius Marminge
View on GitHubTwo-way sync enabledPR last imported 4d ago

Unused runtime exports should fail CI across all internal packages without forcing us to hide exported types or Effect schemas.

Expand the export gate to all seven packages under packages/. Set Knip's types/nsTypes rules to off so the --exports CLI option cannot re-enable them. Wire a repo-local preprocessor into the standard audit, production audit, and CI export command. It uses TypeScript's Effect schema marker to filter only schema export/duplicate findings and their counters, without executing application modules. Decoders, factories, ordinary constants, unused files, and dependencies remain checked.

The scripts workspace declares the existing TypeScript 6.0.3 catalog dependency. The lockfile adds only that importer entry, with no new dependency version or OXC package. No whole schema files or packages are ignored.

Verification on the integrated, rebased stack:

  • vp run knip:check passes for all seven internal packages.
  • One real-CLI integration test proves types, schema aliases/defaults/re-exports, namespace exports, schema classes, and pipelines pass. It proves runtime helpers, ordinary duplicates, unused files, and dependencies still fail with exit code 1. An import-time throw verifies that application modules are never evaluated.
  • 2,321 focused tests pass. No existing test files were changed or removed.
  • Shared, contracts, client-runtime, scripts, and web typechecks pass; focused lint/format checks pass.

The preceding cleanup PRs were reworked to preserve exported types and schemas. The six open PRs now total 69 files, +523/-548, including this preprocessor and its integration coverage. The already-merged ACP PR is unchanged. Tooling-only change; screenshots are not applicable.

Follows #10170.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Synced from GitHub

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a tooling-only change that expands Knip export checks and adds a TypeScript preprocessor, without changing product runtime behavior. Human review is required because it also adds configuration- and file-level suppressions for static-analysis diagnostics.

No code changes detected at a5c20f2. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—13.6 KiB—15.1 KiB✅
CodexThread snapshot wire—7.0 KiB—7.3 KiB✅
CodexLive turn WebSocket wire—6.6 KiB—7.8 KiB✅
CodexLive turn WebSocket decoded—57.1 KiB—66.4 KiB✅
CodexLive turn messages—10—21✅
ClaudeTotal thread wire—13.6 KiB—15.1 KiB✅
ClaudeThread snapshot wire—7.0 KiB—7.3 KiB✅
ClaudeLive turn WebSocket wire—6.6 KiB—7.8 KiB✅
ClaudeLive turn WebSocket decoded—57.9 KiB—66.4 KiB✅
ClaudeLive turn messages—10—21✅

Baseline: unavailable · PR result: a5c20f2 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Synced from GitHub

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Synced from GitHub

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Added 3 commits

  • ci: allow exported types and Effect schemas in Knip8554254
  • ci: preserve schema aliases and type policy in export auditsa5c20f2
  • ci: enforce unused exports across all internal packagesaea17b5