Sign up
View stargazers13Sign up

refactor(contracts): keep unused settings and relay exports private#10170

merged2
cleanup-packages/client-contracts
cleanup-packages/domain-contracts
openedSep 5, 2026byJJulius Marminge
2 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Settings defaults, a schema factory, and assembled relay HTTP groups are exported without external consumers.

Keep those runtime implementation values private. Preserve the settings and relay schemas and all exported types. No schema aliases or checkpoint consumers change. This PR now touches only settings.ts and relay.ts.

Verification: contracts and consumer typechecks pass; existing contracts tests and the integrated Knip gate pass. No existing tests were changed or removed.

Follows #10169.

Note

Make relay API groups and settings defaults module-local in contracts

Changes the seven relay HTTP API groups in relay.ts from exported bindings to module-local bindings; their endpoints, annotations, and middleware are unchanged. Also makes the default settings constants and the makeProviderSettingsSchema factory in settings.ts module-local; types and values are unchanged.

  • Risk: removes these symbols from the package's public API; any out-of-tree code importing RelayHealthGroup, RelayMetadataGroup, RelayMobileGroup, RelayClientGroup, RelayTokenGroup, RelayDpopClientGroup, RelayServerGroup, DEFAULT_TIMESTAMP_FORMAT, DEFAULT_DIFF_LAYOUT, DEFAULT_SIDEBAR_PROJECT_GROUPING_MODE, DEFAULT_SIDEBAR_THREAD_PREVIEW_COUNT, DEFAULT_SIDEBAR_AUTO_SETTLE_AFTER_DAYS, DEFAULT_GLASS_OPACITY, DEFAULT_APPEARANCE_CONTRAST, DEFAULT_PANEL_ANIMATION_DURATION_MS, DEFAULT_TERMINAL_FONT_SIZE, DEFAULT_QUIT_CONFIRMATION_MODE, or makeProviderSettingsSchema will fail to compile.

Macroscope summarized b37eb8e.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Ggithub-actionsBotSep 5, 2026
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—13.5 KiB—15.1 KiB✅
CodexThread snapshot wire—7.0 KiB—7.3 KiB✅
CodexLive turn WebSocket wire—6.5 KiB—7.8 KiB✅
CodexLive turn WebSocket decoded—57.0 KiB—66.4 KiB✅
CodexLive turn messages—8—21✅
ClaudeTotal thread wire—13.6 KiB—15.1 KiB✅
ClaudeThread snapshot wire—7.0 KiB—7.3 KiB✅
ClaudeLive turn WebSocket wire—6.5 KiB—7.8 KiB✅
ClaudeLive turn WebSocket decoded—57.8 KiB—66.4 KiB✅
ClaudeLive turn messages—9—21✅

Baseline: unavailable · PR result: b37eb8e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBotSep 5, 2026
Synced from GitHub

Approvability

Verdict: Approved at 3e0c9e7

Macroscope's review found this PR approvable — This is a narrow internal-export cleanup: relay groups, settings defaults, provider schemas, HTTP contracts, and runtime behavior remain unchanged. The private package has no in-repository consumers of the removed implementation exports.

No code changes detected at b37eb8e. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

CcursorBotSep 5, 2026
Synced from GitHub

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Added 2 commits

  • refactor(contracts): keep domain schema internals private8fa6454
  • refactor(contracts): retain domain schemas and typesb37eb8e