Sign up
View stargazers13Sign up

refactor(contracts): trim unused client API runtime exports#10169

merged2
cleanup-packages/contracts-internals
cleanup-packages/client-contracts
openedSep 5, 2026byJJulius Marminge
5 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

Client API modules export implementation constants and HTTP groups that have no external consumers.

Keep those runtime values private and remove the unused isExternalLauncherError predicate and its server re-export. Preserve client schemas, auth schemas, and API types, including EnvironmentApi. This is now five files, not the previous schema/type cleanup.

Verification: contracts and consumer typechecks pass; existing contracts tests and the integrated Knip gate pass. No existing tests were changed or removed.

Follows #10168.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Ggithub-actionsBotSep 5, 2026
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—13.6 KiB—15.1 KiB✅
CodexThread snapshot wire—7.0 KiB—7.3 KiB✅
CodexLive turn WebSocket wire—6.6 KiB—7.8 KiB✅
CodexLive turn WebSocket decoded—57.1 KiB—66.4 KiB✅
CodexLive turn messages—10—21✅
ClaudeTotal thread wire—13.6 KiB—15.1 KiB✅
ClaudeThread snapshot wire—7.0 KiB—7.3 KiB✅
ClaudeLive turn WebSocket wire—6.5 KiB—7.8 KiB✅
ClaudeLive turn WebSocket decoded—57.9 KiB—66.4 KiB✅
ClaudeLive turn messages—10—21✅

Baseline: unavailable · PR result: 83986b0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBotSep 5, 2026
Synced from GitHub

Approvability

Verdict: Approved at 83986b0

Macroscope's review found this PR approvable — This is a contained cleanup of unused runtime exports from a private contracts package. Existing schemas, endpoint groups, keybinding values, and server behavior remain unchanged.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Added 2 commits

  • refactor(contracts): prune obsolete desktop API declarations54c6a98
  • refactor(contracts): retain client schemas and API types83986b0