fix(server): clean up deleted threads worktrees with subagents#23900

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-17812
• File: .coderabbit.config.ts
• Commit: ad34e6c
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 370e5f07-6bfe-4f69-ba52-9a0dfc7e9945

📥 Commits

Reviewing files that changed from the base of the PR and between 23bd753806eb9db5a315fbf9ac6563d355f20b3a and ad34e6c92ce601be54aff7c5c22901c8100503e9.

📒 Files selected for processing: 2

• apps/server/src/storageCleanup.test.ts
• apps/server/src/storageCleanup.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Storage cleanup now evaluates a deleted thread and its surviving subagents as a shared worktree group. It applies idle and settled-grace checks to live group members and revalidates ownership and activity before removal. Tests cover cleanup settings and recently settled subagents.

Changes: Deleted-thread worktree cleanup

Layer / File(s)	Summary
Deleted owner candidate selection apps/server/src/storageCleanup.ts	Cleanup can select a deleted thread as the worktree owner when deletion cleanup is enabled and the deleted thread owns the shared subagent chain.
Cleanup checks and regression cases apps/server/src/storageCleanup.ts, apps/server/src/storageCleanup.test.ts	Cleanup applies idle and settled-grace checks to surviving subagents and revalidates group ownership and activity. Tests cover deletion cleanup enabled and disabled, including a recently settled subagent.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: maria-rcks

No actionable merge-blocking issue was established for deleted-thread worktree cleanup. The change is ready for normal merge checks.

Check name	Status	Explanation
Title check	Passed	The title clearly and concisely identifies the server fix for cleaning up worktrees associated with deleted threads and subagents.
Description check	Passed	The description includes complete Problem, Change, Scope and approval, and Verification sections. It links the related issue, explains the server-only scope, reports focused test and runtime results, …
Linked Issues check	Passed	Requirement [#17812]: with "Delete worktrees with deleted threads" enabled, a deleted thread's worktree must be removed even when its subagent threads remain. The diff implements this in apps/server/s…
Out of Scope Changes check	Passed	All changes are in apps/server/src/storageCleanup.ts and apps/server/src/storageCleanup.test.ts. Each hunk maps to the issue. The worktreeOwner generic widening lets deleted threads, which carry only …

Full details: Description check

Explanation

The description includes complete Problem, Change, Scope and approval, and Verification sections. It links the related issue, explains the server-only scope, reports focused test and runtime results, and discloses verification limitations.

Full details: Linked Issues check

Explanation

Requirement [#17812]: with "Delete worktrees with deleted threads" enabled, a deleted thread's worktree must be removed even when its subagent threads remain. The diff implements this in apps/server/src/storageCleanup.ts. Candidate selection now picks a deleted thread as owner when its project has worktreeOnDelete enabled and worktreeOwner([deleted, ...group]) returns that thread. Previously, live subagents on the path blocked the deleted thread. The final revalidation no longer blocks deleted candidates when remaining members still share the worktree. Remaining subagents must pass the same idle, settle-grace, branch, and local-change checks as other candidates. The new tests in storageCleanup.test.ts cover: a deleted thread with no subagents (removed); a deleted thread with one completed native subagent (removed, reason "Thread was deleted", directory absent); a deleted thread whose subagent settled at the current time (kept, "Settled moments ago"); and deletion cleanup off with a remaining subagent (live inactivity rule applies). Residual gaps: the issue's two-subagent case (child-1 and child-2) is not a new test. The code path should handle it because both children share the deleted parent as the single top of the chain, but I did not read the full worktreeOwner body, so this is inferred. The issue's web delete-prompt concern (apps/web/src/worktreeCleanup.ts) is not changed. The issue reports it from code reading only, untested, and the PR states it is server-only. I did not run the test suite. Assessment relies on the diff and test diff.

Full details: Out of Scope Changes check

Explanation

All changes are in apps/server/src/storageCleanup.ts and apps/server/src/storageCleanup.test.ts. Each hunk maps to the issue. The worktreeOwner generic widening lets deleted threads, which carry only id and lineage, be passed to the same ownership logic. The candidate selection hunk adds deleted-owner selection for shared subagent chains. The !deleted && removals apply idle and settle-grace checks to deleted candidates' subagents, as the issue requires. The revalidation hunk moves the latest-state check out of the else branch so that deleted candidates are checked too. The members and deletedByPath additions support those changes. The test fixture changes (deleted thread storage and setDeletedThreads) support the new tests. The deletion-off path keeps the live owner and the previous rules, as the PR states. No unrelated files or behavior changes appear in the diff.

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR