fix(server): let Claude steer interrupt a running Bash command#23892

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-15720
• File: .coderabbit.config.ts
• Commit: 9223781
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 4cab2c20-21e5-482d-bf19-787590ceafb2

📥 Commits

Reviewing files that changed from the base of the PR and between 133b3edd4f116fd6fc57b6758ea8d5e8fe4001ff and 9223781a8782ad19f504a78dadb03772196dbc7a.

📒 Files selected for processing: 2

• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

🚧 Files skipped from review as they are similar to previous changes: 2

• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts
• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Claude steering now interrupts a running Bash command when no runtime requests are pending. The adapter checks that the active turn and live query remain active before offering the steer. Tests cover pending requests, turn completion, interruption errors, and automatic-delivery abort behavior.

Changes: Claude steering

Layer / File(s)	Summary
Interrupt active Bash during steering apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts, apps/server/src/orchestration-v2/ClaudeAutomaticDelivery.integration.test.ts	steerTurn interrupts a running Bash command when no runtime requests are pending. It checks the active turn and live query after backgrounding foreground subagents and after interruption. Tests cover pending requests, turn completion, interruption errors or timeouts, and aborted tool results.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

mermaid

1	sequenceDiagram
2	participant User
3	participant Adapter as ClaudeAdapterV2.steerTurn
4	participant Query as Claude query
5	participant CLI as Claude CLI
6	User->>Adapter: Request steering
7	Adapter->>Query: Interrupt active Bash when no runtime requests are pending
8	Query-->>Adapter: Interruption completes, fails, or times out
9	Adapter->>Adapter: Check active turn and live query
10	Adapter->>CLI: Offer steer if the turn and query remain active

Possibly related issues

• Issue 15720: The change interrupts a running foreground Bash command before delivering the steer.
• Issue 23403: The adapter checks turn ownership after interruption and uses the existing fallback if the turn ends before steer delivery.
• Issue 10955: The change applies interrupt-without-close behavior to explicit steering, but does not change the Stop path.

The bounded interrupt wait allows steering to proceed if the interrupt goes unanswered. No concrete issue remains that calls for delaying the merge beyond normal checks.

Check name	Status	Explanation
Title check	Passed	The title is concise, specific, and accurately describes the primary server fix: allowing Claude steering to interrupt a running Bash command.
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.
Description check	Passed	The description follows the required structure and clearly explains the problem, change, scope, approval context, verification results, evidence, environment, limitations, and agent usage. It provides…

Full details: Description check

Explanation

The description follows the required structure and clearly explains the problem, change, scope, approval context, verification results, evidence, environment, limitations, and agent usage. It provides an issue link and detailed test results. It does not include an explicit maintainer approval comment, but it states that the issue was triaged through the automated issue flow and explains the focused scope.

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR