Sign up
View stargazers13Sign up

fix(mobile): the pull requests tab's empty detail asks for a pull request#23145

merged1
duo/sheets
duo/followups
opened3d agobyJJulius Marminge
2 files changed
View on GitHubTwo-way sync enabledPR last imported 3d ago

On iPad and the iPhone Duo, the pull requests tab's empty detail column said "Select a thread" and could offer New Task. It now asks for a pull request, as Android already does, and leaves out the task action.

Verification

  • Mobile typecheck passes on this layer.
  • The unfolded Duo's pull requests tab with no pull request open, at this PR's base fe16f614bef and head 90514c987ad (pre-restack commits, Screens t3.31 dev client with a matching fingerprint):
BeforeAfter
Before: the empty pull request detail says Select a threadAfter: the empty pull request detail asks for a pull request

Implemented with Claude Opus 5.5 in Claude Code, running in T3 Code.

🤖 Generated with Claude Code

Checks

All checks passed
MmacroscopeappBot3d ago
Synced from GitHub

Approvability

Verdict: Approved at c3b53cb

Macroscope's review found this PR approvable — This small mobile UI fix supplies the pull-request tab to the empty detail so it displays appropriate copy and omits the unrelated new-task action. Existing thread empty states remain unchanged, and the change has no broader runtime or data impact.

No code changes detected at c23590a. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot3d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: e148fd2c-29af-470a-9588-d124d0605a82
📥 Commits

Reviewing files that changed from the base of the PR and between c3b53cbaf4eb9a5c0203aea89e20d5c0a170a19a and c23590a93552b91c4f527ffb31062cdae1c71107.

📒 Files selected for processing: 1
  • apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

WorkspaceEmptyDetail now receives the selected workspace tab. For the pull-requests tab, it displays pull-request guidance and hides the start-new-thread or task action. Other tabs retain their existing behavior.

Changes: Workspace Empty State

Layer / File(s)Summary
Tab-aware empty-state content
apps/mobile/src/features/layout/WorkspaceEmptyDetail.tsx, apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx		The navigator passes the selected tab to WorkspaceEmptyDetail. For the pull-requests tab, the component displays pull-request text and hides the start action. Other tabs retain their existing messaging and platform-specific action behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: pixpmusic

Merge Risk: ⚪ Minimal · up to c2359

The pull-request empty state is appropriately specialized without introducing merge-blocking risk.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check nameStatusExplanationResolution
Description checkWarningThe description explains the problem, the implemented change, and verification results with before-and-after screenshots. It does not include the required Scope and approval section, and it does not e…Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused, obvious bug fix qualifies without prior approval. Add explicit Problem and Change headings if the repository requires the template…
Passed Passed checks: 3 passed
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely describes the main change: correcting the empty state in the mobile pull requests tab.
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the implemented change, and verification results with before-and-after screenshots. It does not include the required Scope and approval section, and it does not explicitly separate the Problem and Change sections.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused, obvious bug fix qualifies without prior approval. Add explicit Problem and Change headings if the repository requires the template structure.

✨ Finishing Touches: 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Comment @coderabbitai help to get the list of available commands.

Added 1 commit

  • fix(mobile): the pull requests tab's empty detail asks for a pull requestc23590a
Ggithub-actionsBot3d ago
Synced from GitHub

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for c23590a.

This comment will update automatically after the next completed run.