Sign up
View stargazersSign up

Plan 027 Phase 5: fmt pass + lint autofix#321

closed3
feat/027-phase4-vp-pack
feat/027-phase5-fmt-autofix
openedSep 1, 2026byAAviddaram
10 files changed
View on GitHubTwo-way sync enabledPR last imported 19d ago

Summary

  • vp fmt --write on full repo (fixes #320 morning-brief drift + Phase 3/4 config edits)
  • vp lint --fix for auto-fixable rules (perfectionist sort, etc.)
  • ~63 lint errors fixed (1241 → 1178); vp fmt --check green

Not in this PR

  • Anti-slop intentional fixes (planned swarm in follow-up)
  • nkzw baseline (complexity, react/admin, env.d.ts) — separate PR(s)
  • CI lint/fmt gates

Test plan

  • bunx vp fmt --check
  • bun run --filter server build

Stacked on #319.

Checks

2 failing · 3 successful · 1 skipped
Some checks failed

Failing2

604eb97

Added 1 commit

  • chore(tooling): Plan 027 Phase 5 fmt pass and lint autofixc96b77b
CcoderabbitaiBotSep 1, 2026
Synced from GitHub

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • v2

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 2192a73f-dff9-47e5-9734-68fc9d17975e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Ggreptile-appsBotSep 1, 2026
Synced from GitHub

Greptile Summary

This PR applies repository-wide formatting and lint autofixes without changing runtime behavior.

  • Reformats morning-brief, order-query, and order-router code.
  • Sorts object properties, imports, configuration rules, and router procedures.
  • Normalizes braces, array type syntax, indentation, and line wrapping.

Confidence Score: 5/5

The PR appears safe to merge because the reviewed changes preserve existing runtime, build, and configuration behavior.

The formatting and lint autofixes retain the same methods, routes, inputs, conditions, transactions, side effects, configuration values, and object fields.

Important Files Changed

FilenameOverview
packages/api/src/queries/orders.tsReorders query methods and properties and reformats expressions while preserving namespaces, filtering, persistence, sorting, and returned shapes.
packages/api/src/routers/admin/order.tsReorders and reformats router procedures while preserving procedure schemas, transaction behavior, side effects, and error handling.
packages/api/src/lib/integrations/admin-notifications/morning-brief-delivery.tsApplies import, type-style, brace, and object-property formatting without changing delivery behavior.
apps/server/scripts/morning-brief-now.tsReformats environment checks, pagination input, and fallback filtering without changing execution semantics.
oxlint.config.tsSorts existing rule keys without changing configured lint behavior.

Reviews (1): Last reviewed commit: "chore(tooling): Plan 027 Phase 5 fmt pas..." | Re-trigger Greptile

Added 2 commits

  • chore(tooling): second vp lint --fix pass on order modules7933ad7
  • chore(tooling): third vp lint --fix pass on order modules604eb97
Cchatgpt-codex-connectorBotreviewed · 1 inline threadSep 1, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5cc9d635f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/shared/src/trpc-error.tsline 33Outdated · d5cc9d6Open thread
……@@ -1,13 +1,47 @@
30+
31+const trpcResponseItemWireSchema = v.looseObject({
32+ error: v.optional(
33+ v.union([trpcSerializedErrorWireSchema, trpcPublicErrorWireSchema, v.unknown()]),
Cchatgpt-codex-connectorBoton line 33Sep 1, 2026

P2 Badge Preserve unwrapped tRPC errors during wire parsing

When an upstream or non-SuperJSON response uses the explicitly supported unwrapped form { error: { code, data, message } }, the first union branch still succeeds because json is optional; Valibot's object parser then strips the error fields and returns {} before sanitizeNestedTrpcError runs. The response is consequently replaced with a generic fallback—an unwrapped 401 error, for example, is mislabeled INTERNAL_SERVER_ERROR—so make the serialized branch require json or otherwise discriminate the two layouts before parsing.

Useful? React with 👍 / 👎.

AAviddaramOct 1, 2026

Closing: this branch's head commit is already in main (Plan 027 lint stack landed via merge 4bf54d3).