Sign up
View stargazersSign up

Plan 027 Phase 2b: enable anti-slop + nkzw lint overrides#318

closed2
feat/027-phase3-vp-run
feat/027-phase2b-anti-slop
openedSep 1, 2026byAAviddaram
3 files changed
View on GitHubTwo-way sync enabledPR last imported 20d ago

Summary

  • Enable all vendored anti-slop rules in oxlint.config.ts (store-kit parity)
  • Add vit-store overrides: Astro env, Solid/storev2 react-off, node package relaxations, alchemy.run/env.d.ts carve-outs
  • Ignore generated packages/api/src/db/schema.d.ts (vp pack artifact — was inflating lint to ~3k errors)

Migration speed (wall clock, local, errors ignored)

CommandPre-027 (main)Phase 3 (nkzw only)Phase 2b (+ anti-slop)store-kit ref
Lintbiome lint 1s + oxlint <1svp lint 8svp lint 7–9svp lint 64s
Format check(via biome)—vp fmt --check 5–8s—
Typecheckturbo check-types 28s10s6sn/a
Combined——vp check 7s—

Anti-slop adds ~0s vs nkzw-only oxlint — cost is rule surface, not runtime. Typecheck got faster on the branch (turbo cache + fewer packages failing early). store-kit lint is slower despite fewer effective rules (monorepo layout / cold plugin load).

Baseline status

  • nkzw/non-anti-slop: ~163 errors remain (complexity, admin react rules, unused vars)
  • anti-slop: ~841 errors remain — mostly require-safety-comment-for-type-assertion, no-unknown-parameters, no-runtime-typeof
  • Follow-up pass needed before vp lint is CI-green

Review bot feedback

BotFindingAction
Greptile P2**/worker.mjs ignore skips hand-authored apps/storev2/worker.mjsRemove broad ignore — fix pending
Codex P2Same worker.mjs ignore too broadSame fix
CodeRabbitSkipped (non-default base branch)—

Test plan

  • bunx vp lint runs (config loads)
  • bunx vp fmt --check
  • bun run --filter admin build

Stacked on #317.

Checks

2 failing · 3 successful · 1 skipped
Some checks failed

Failing2

34081c2
CcoderabbitaiBotSep 1, 2026
Synced from GitHub

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • v2

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 3d44b28f-315a-417b-a5fb-e78beb170bad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Ggreptile-appsBotSep 1, 2026
Synced from GitHub

Greptile Summary

This PR enables the vendored anti-slop lint rules and adds application-specific lint overrides and generated-file exclusions. It also reorganizes the Vite+ task configuration without changing the task commands.

  • Registers and enables all vendored anti-slop rules.
  • Adds Astro, Storev2, Node-package, declaration-file, Alchemy, and admin lint overrides.
  • Ignores schema declarations and Worker files, although the Worker pattern also excludes handwritten deployment source.
  • Reorders Vite+ task and staged-check configuration.

Confidence Score: 4/5

The PR appears safe to merge, but the Worker exclusion should be narrowed or removed so handwritten deployment code remains linted.

The configuration loads and no blocking failure was established, but the broad Worker ignore disables lint coverage for the tracked Storev2 Cloudflare Worker entrypoint and any future file with that basename.

Files Needing Attention: oxlint.config.ts

Important Files Changed

FilenameOverview
oxlint.config.tsEnables anti-slop and broadens lint overrides; the new Worker glob incorrectly excludes a handwritten deployment entrypoint.
packages/api/.gitignoreIgnores schema.d.ts artifacts; no repository consumer or tracked artifact was found that would be affected.
vite.config.tsReorders existing task fields and restores the staged check block without changing command behavior.

Reviews (1): Last reviewed commit: "chore(tooling): Plan 027 Phase 2b enable..." | Re-trigger Greptile

oxlint.config.tsline 53Outdated · 4cdff1eOpen thread
……@@ -12,35 +48,59 @@ export default defineConfig({
1450 "**/.cursor/**",
51+ "apps/agent/.flue/**",
52+ "packages/api/src/db/schema.d.ts",
53+ "**/worker.mjs",
Ggreptile-appsBoton line 53Sep 1, 2026

P2 Handwritten worker bypasses lint

The **/worker.mjs pattern excludes apps/storev2/worker.mjs, a tracked Cloudflare Worker entrypoint containing request and cache-purge logic, so changes to deployed source permanently bypass the newly enabled anti-slop and other lint rules. Remove this exclusion or replace it with a pattern that targets only actual generated artifacts.

suggestion
1

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Cchatgpt-codex-connectorBotreviewed · 1 inline threadSep 1, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4cdff1ed81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

oxlint.config.tsline 53Outdated · 4cdff1eOpen thread
……@@ -12,35 +48,59 @@ export default defineConfig({
1450 "**/.cursor/**",
51+ "apps/agent/.flue/**",
52+ "packages/api/src/db/schema.d.ts",
53+ "**/worker.mjs",
Cchatgpt-codex-connectorBoton line 53Sep 1, 2026

P2 Badge Keep the storefront worker entrypoint under lint

Narrow this ignore to the generated artifact path instead of matching every worker.mjs. The repository already contains the tracked, hand-authored apps/storev2/worker.mjs, and apps/storev2/alchemy.run.ts selects it as the production entrypoint, so this pattern silently exempts deployment-critical request and cache-purge code from all existing and newly enabled lint rules.

Useful? React with 👍 / 👎.

Added 2 commits

  • chore(tooling): Plan 027 Phase 2b enable anti-slop and nkzw overridesee27f27
  • fix(tooling): lint tracked storev2 worker.mjs entrypoint34081c2
AAviddaramOct 1, 2026

Closing: this branch's head commit is already in main (Plan 027 lint stack landed via merge 4bf54d3).