Sign up
View stargazersSign up

chore(tooling): Plan 027 Phase 3 vp run tasks#317

closed2
feat/027-phase2-lint-fmt
feat/027-phase3-vp-run
openedSep 1, 2026byAAviddaram
3 files changed
View on GitHubTwo-way sync enabledPR last imported 20d ago

Summary

  • Add run.tasks for admin/server/storev2 alchemy dev and db generate/migrate-local
  • Root dev uses vp run --parallel; dev:turbo keeps turbo fallback

Test plan

  • vp run admin:dev (manual)
  • Config parses (vp lint loads vite.config.ts)

Stack

Stacks on #316.

Checks

2 failing · 3 successful · 1 skipped
Some checks failed

Failing2

c703116
CcoderabbitaiBotSep 1, 2026
Synced from GitHub

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • v2

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 020238dc-0ea0-425b-8553-e5a0d001fa05

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Ggreptile-appsBotSep 1, 2026
Synced from GitHub

Greptile Summary

The PR migrates the default multi-application development command to Vite Plus while retaining Turbo as a fallback.

  • Adds Vite Plus run tasks for the admin, server, and storefront development processes.
  • Adds Vite Plus task aliases for Drizzle schema generation and local migration.
  • Changes the root dev script to launch the three application tasks in parallel and adds dev:turbo.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable changed-code defect established.

The new task definitions match existing workspace commands, and the potentially problematic database and TLS behaviors already exist in equivalent scripts rather than being introduced or materially worsened here.

Important Files Changed

FilenameOverview
package.jsonReplaces the default Turbo development command with parallel Vite Plus tasks and preserves Turbo under a fallback script.
vite.config.tsDefines uncached development and database tasks with workspace-specific commands and working directories.

Reviews (1): Last reviewed commit: "chore(tooling): Plan 027 Phase 3 vp run ..." | Re-trigger Greptile

Cchatgpt-codex-connectorBotreviewed · 1 inline threadSep 1, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb02a82db0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

package.jsonline 37Outdated · cb02a82Open thread
……@@ -34,7 +34,8 @@
3535 "deps:check:minor": "bunx taze -r minor --group",
3636 "knip": "BUN_INSTALL=.bun BUN_TMPDIR=tmp bunx knip --workspace apps/admin --workspace apps/storev2 --workspace apps/server --workspace packages/api --workspace packages/shared --reporter compact --no-config-hints --include files,dependencies,exports",
37- "dev": "turbo dev",
37+ "dev": "vp run --parallel admin:dev server:dev storev2:dev",
Cchatgpt-codex-connectorBoton line 37Sep 1, 2026

P2 Badge Keep the agent in the root development command

When developers run the documented bun dev command, this explicit task list starts only admin, server, and storev2, so the apps/agent Wrangler worker no longer starts even though README.md describes the command as starting all apps and apps/agent/package.json defines a dev script. Add an agent development task to this invocation, or preserve the previous all-workspace behavior.

Useful? React with 👍 / 👎.

Added 2 commits

  • chore(tooling): Plan 027 Phase 3 vp run dev and db tasksc27f483
  • docs: update Plan 027 status for stacked PRsc703116
Cchatgpt-codex-connectorBotreviewed · 1 inline threadSep 1, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c70311663f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vite.config.tsline 49Open thread
……@@ -22,4 +22,34 @@ export default defineConfig({
46+ },
47+ "db:migrate:local": {
48+ command:
49+ "vp exec drizzle-kit migrate --config=../../packages/api/drizzle.local.config.ts",
Cchatgpt-codex-connectorBoton line 49Sep 1, 2026

P2 Badge Point the local migration task at a usable config

Invoking the newly added vp run db:migrate:local task passes packages/api/drizzle.local.config.ts, but that module consists entirely of comments and exports no Drizzle configuration. Drizzle Kit therefore cannot obtain the required dialect, credentials, schema, or migrations path, so this task cannot perform a local migration; activate a valid local config or defer exposing the task until one exists.

Useful? React with 👍 / 👎.

AAviddaramOct 1, 2026

Closing: this branch's head commit is already in main (Plan 027 lint stack landed via merge 4bf54d3).