fix(mobile): defer thread detail reads until creation completes#24345

Approvability

Verdict: Approved at a8cad86

Macroscope's review found this PR approvable — This is a localized mobile bug fix that defers one workflow detail subscription until optimistic thread creation is delivered, preventing stale not-found state while preserving existing delivered-thread behavior. It includes focused regression coverage and only test-harness configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Seeing this too on an iPhone connected to a Mac host over Tailscale. The server traces show the phone's /bounded request failing with thread_not_found 50-80ms before thread.create arrives. I cherry-picked this PR into my build, and the new test fails without the fix and passes with it.

One more spot to cover when this gets rebased. #24104 added a useThreadGuestShare call to ThreadFeed with a ref built from props.threadId, and guestShareAtom reads environmentThreadDetails.threadAtom(ref), so on current main that hook makes the same early request for a new thread. I think it needs the same threadDetailReady gate.

thanks @brandon-julio-t. the shared readiness gate covers both premature readers, and the empty parent atom preserves workflow metadata without bypassing the gate.

merged current main (cc0b86ddf1) into your branch in d6133c764b, keeping every original commit. the only conflict was the mobile react test list; both additions are preserved. no production changes or coverage were dropped: the existing fix is already focused.

verification on this head:

• restoring main's workflow and guest readers makes exactly two regressions fail with premature new-thread and pending-thread loads; restoring the fix passes all 93 tests.
• blacksmith vp run check:changed passes formatting, lint, both knip checks, affected typechecks and adjacent tests.
• two independent read-only sol reviews found no blocker or should-fix findings on this head.
• gitcafe reports no conflicts and seven successful check contexts. however, github's actual CI run and preview workflows report action_required, so full hosted CI still needs approval. coderabbit's new review was rate-limited; its earlier review covered the unchanged fix.

unverified: native creation/navigation and fresh before/after captures. this vm has no connected android device, and ios cannot run here. the default dev server booted and was stopped; the web client cannot demonstrate the separate native reader. existing incident evidence remains in the pr body. no merge-ready integration claim until hosted CI and native confirmation are available.

pushed d4050477e9: merged current main without rebasing and preserved its nullable detail-reference implementation. main now contains the production fix in #25477; the remaining pr diff is three test/config files (232 additions, 2 deletions). both premature-reader regression tests now use that reference. the previously fixed guest-reader finding is resolved.

blacksmith vp run check:changed passed format, lint, both knip checks, affected typechecks, and all 93 tests. two independent read-only sol reviews found no blocker or should-fix findings. github reports mergeable with no conflicts.

hosted CI and preview runs on this head report action_required; CI has no jobs or failed logs yet. native creation/navigation remains unverified because this vm has no connected android device. pending bot checks and hosted workflow approval prevent an all-green readiness claim. no merge performed.

the additional coverage suggestion identifies a known integration-test limit, not a verified regression. pending-thread-creation.test.ts:143 already covers queued/failed creation yielding a null detail reference and delivery releasing it. ThreadDetailScreen.tsx:1294 forwards that reference unchanged. this pr's tests cover the workflow and guest readers consuming it. production source matches merged main; keeping this focused pass unchanged rather than adding a broader screen harness. native end-to-end confirmation remains explicitly unverified.

all seven reported checks now pass on d4050477e9, and github confirms no conflicts. hosted CI and preview workflows still report action_required, so this is waiting for workflow approval, not fully verified merge readiness.

pushed 93f6ef418b: merged github/main (32bf48f428) without rebasing. the only conflict was the mobile react test registration; both additions are preserved. github confirms mergeable. the pr remains three test/config files, 232 additions and 2 deletions, with no production changes.

blacksmith vp run check:changed passed format, lint (zero warnings/errors), both knip checks, mobile/scripts typechecks, and all 93 tests. two independent read-only sol reviews found no blocker or should-fix findings on this head. the real guest-reader finding is already fixed and resolved; the broader handoff coverage suggestion was already answered and does not justify expanding this pass.

hosted checks are still reporting. the previous head's CI required approval and had no jobs or failed logs. native creation/navigation remains unverified: adb devices is empty on this vm. no native evidence or full integration claim. no merge performed.