fix(mobile): models stay visible in the picker with Android animations removed#23888

Approvability

Verdict: Approved at 97b2958

Macroscope's review found this PR approvable — The model picker now uses live reduced-motion settings to suppress row fades while retaining its existing animation guards. The change is confined to presentation, with no changes to model selection or saved settings.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 1
• Charged: $0.25
• View usage details

_{Comment @coderabbitai help to get the list of available commands.}

Verified in a real dev environment

No changed runtime behavior could be verified on this Linux Boat VM. I inspected the description, full diff, commits, discussion and inline review at head dca2654bbf5f2572867fce174499bf863d891ff0. The PR is open and contains no commits by juliusmarminge or t3dotgg. Git.cafe maps it to #23888. Its status reports 27 successful checks, zero failing and zero pending; these are existing CI results, not runtime proof.

Environment probe:

Not verified

The only changed file is the native React Native ThreadSettingsSheet.tsx. The Android Remove animations bug cannot be exercised through the desktop web client. The mobile verification skill requires stopping when T3 device access is unavailable, so I did not substitute web screenshots or mock data for native evidence.

Not reproduced on github/main or re-verified on the PR: invisible-but-tappable model rows while scrolling with Remove animations enabled; model selection and save; normal-motion fades; toggling Remove animations while the app remains alive (also raised in the existing review). Native iOS behavior is unverified as well. No screenshots or recordings were captured, and no real Codex provider turns were run. No worktrees, dependency installs or dev servers were started because no supported native client was available to exercise the changed behavior. No code, branch, labels or PR metadata were changed.

Result: unverifiable here. Requires an accessible Android device/emulator with the real native client, a real provider catalog, and before/after runs after restarting the app for each accessibility setting.

Verified in a real dev environment

no changed runtime behavior could be verified on this linux boat vm at head b64f119dca277d3502638192ad39c2c916fe09f1.

i inspected the description, diff, commits, discussion, inline review and checks. the pr is open, contains no commits by juliusmarminge or t3dotgg, and maps to https://git.cafe/pingdotgg/t3code/pulls/23888. the only changed file is the native mobile ThreadSettingsSheet.tsx: it gates model-row and option fades on list loading and reanimated's reduced-motion setting.

runtime environment probe:

git.cafe reports 29 successful checks, zero failing and zero pending at this head. it also reports a merge conflict with current main. those ci results do not prove the native behavior.

Not verified

main reproduction and pr verification remain blocked by unavailable native device access. the mobile verification skill explicitly requires stopping when device tools are unavailable. chrome and playwright cannot exercise this native react-native/reanimated picker or android's accessibility setting.

unverified: scrolling model rows with remove animations enabled after an app restart; model selection and persistence; search/filter behavior; normal-motion fades with remove animations disabled; changing the setting without restarting; native ios behavior. the description documents the restart requirement, and the existing inline review raises the live-setting limitation.

no screenshots or recordings were captured, no provider turns were run, and no worktrees, installs or dev servers were started. no code, branches, labels or pr metadata were changed. this run is unverifiable, not verified or broken. an accessible android device/emulator is needed for the before/after native flow with real project, thread and codex gpt-6.1-sol data.

head 97b2958d802b180c7224c58f71557dbbe72e1eba has 31 successful checks, no pending or failing checks, and no merge conflicts. merged current main with a merge commit and addressed the live reduced-motion finding using the existing native store while preserving the startup gate. the remaining diff is one file, three additions and one deletion.

blacksmith passed vp run check:changed (format, lint, knip, affected typechecks and react compiler checks) and vp test run apps/mobile/src/lib/appState.test.ts (two tests). two independent source reviews found no remaining code issues.

native interaction and new evidence remain unverified: device access is disabled in this environment. chrome/playwright cannot exercise the native android picker. no dev servers remain running. no merge was performed.