feat(web): edit usage prices across selected environments#9861

Unwritable envs block valid price saves

Medium Severity

The save-blocking errors map keeps validation failures from every selected environment with loaded prices, including ones already marked unavailable (offline, read-only, old server). A single-field edit of an existing override then fails validation on those destinations because they still need a complete price to create one. Save stays disabled, and Apply to is frozen once drafts exist, so writable environments cannot receive the change without discarding and deselecting first.

^{Reviewed by Cursor Bugbot for commit 0d1c2ef4d8475dbadac7a383bbdef20020d425cf. Configure here.}

Fixed in f3f881b61. Only writable destinations contribute save-blocking validation; unavailable destinations still receive their own Not saved result. Regression tests cover offline, read-only, and older servers without an existing override while another environment can accept a single-column edit. All 33 focused tests and web typecheck pass.

🟠 High usage/usagePriceTable.ts:26

usagePriceCell crashes while rendering a model named toString (or another inherited Object.prototype key): target.prices?.[model] returns the inherited function, and usagePriceForm then dereferences missing price fields. Require an own property before reading the price record.

Fixed in e540d908c. All table price lookups now require an own record property, including display, edits, and reset. Regression tests cover constructor, toString, and proto as exact model IDs, both before and after a custom price exists. The focused tests, web typecheck, and scoped lint pass.

Empty rows silently block saving

Medium Severity

Adding a model with the plus button inserts an empty draft that is treated as invalid, so Save changes stays disabled. The Enter a model ID message is hidden until the row has content, and Apply to also locks because hasChanges is already true. Other staged edits cannot be saved until that blank row is filled or removed.

^{Reviewed by Cursor Bugbot for commit 32c1d4cb358ac90234d659844bc8ae7eed039f22. Configure here.}

Fixed in ef877f722. Completely empty new rows no longer count as staged changes or save-blocking errors. Partially filled rows still validate. A regression test covers valid edits alongside an empty row and a nameless row with an explicit zero. Browser verification confirms Apply to stays available for an empty row and existing edits remain saveable.

usage/UsagePriceOverrides.tsx:263

Shared primitives: rather than reapplying buttonVariants as a class string, MenuTrigger should compose Button from ui/ via render, which is the convention at the other menu call sites (PreviewMoreMenu.tsx, CompactComposerControlsMenu.tsx).

(buttonVariants can then be dropped from the ../ui/button import.)

No longer relevant as of ef877f722c22f41122711c3a2bf1d2675c12160e

Fixed in ef877f722. The menu trigger now composes Button through render. Verified the environment dropdown still opens and selects normally; web typecheck and scoped lint pass.

usage/UsagePriceOverrides.tsx:430

Shared primitives: bg-transparent shadow-none overrides the Input primitive's base chrome from the call site. Input already supports opting out (unstyled), and InputGroup variant="ghost" is the existing borderless treatment — prefer one of those, or add a ghost variant to Input, instead of an ad hoc class override on every cell.

No longer relevant as of ef877f722c22f41122711c3a2bf1d2675c12160e

Fixed in ef877f722. Removed the background and shadow overrides so table cells use the standard compact Input styling and keep its focus and disabled states.

Retry lock blocks completing prices

Medium Severity

A single-column edit can save on a writable destination while an unavailable one is skipped. After that destination becomes writable without a full override, retry treats the missing required rate as a failed save and locked keeps the table read-only, so the incomplete fields cannot be filled. Discard is the only way out, and it drops the staged change instead of finishing the documented retry.

^{Reviewed by Cursor Bugbot for commit ef877f722c22f41122711c3a2bf1d2675c12160e. Configure here.}

Retry deliberately replays the original batch only on failed destinations. The table stays locked after a partial save so changing its values cannot silently alter that batch or write again to successful destinations. An environment without an existing override needs both required rates; a single-column edit cannot create that override. That case reports the missing rate and requires discarding the pending batch, selecting that environment, and entering a complete price. Successful writes remain persisted. I am keeping this explicit recovery path within the approved flow rather than making Retry edit an already partially applied batch.