Sign up
View stargazers13Sign up

fix(desktop): wait for the local server to exit when quitting#22999

open5
main
fix/issue-22983
opened4d agobyJJulius Marminge
7 files changed
View on GitHubTwo-way sync enabledPR last imported 3d ago
4 unresolved threads · Jump to file
Selected thread: apps/desktop/scripts/quit-lock-evidence.sh:158 — 🟡 **Medium** `scripts/quit-lock-evidence.sh:158` An unknown `FIXTURE` exits with status 2 but leaves the already-launched Electron main process, backend, and `headless-desktop` wrapper running, so they continue holding the isolated home’s lock. The rejection at line 186 happens after `launch primary`; validate the fixture before launching. ```diff +case "$FIXTURE" in + F1|F2|F3|F4|F12) ;; + *) echo "unknown fixture $FIXTURE" >&2; exit 2 ;; +esac ``` <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary> ```text In file @apps/desktop/scripts/quit-lock-evidence.sh around line 158: An unknown `FIXTURE` exits with status 2 but leaves the already-launched Electron main process, backend, and `headless-desktop` wrapper running, so they continue holding the isolated home’s lock. The rejection at line 186 happens after `launch primary`; validate the fixture before launching. ``` </details> <!-- macroscope-meta: {"kind":"code_review","variant":"dbca4b5e98da5ade3401563e99690a04"} -->
0 / 7 viewed7 files changedLine totals unavailable