No actionable comments were generated in the recent review.
Walkthrough
-
The workspace layout now publishes hinge and pane-settling state. Android anchored menus remeasure their anchors when they open and when panes settle, then use the hinge captured with the anchor for placement.
Changes: Android menu anchoring
Layer / File(s) Summary Publish pane settling in hinge context
apps/mobile/src/native/window-hinge-context.ts,apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsxThe context now provides the hinge and a pane-settling counter. Pane sizing updates the counter after animations settle and for hinge changes that do not resize the sidebar. List-pane revision advances only for viewport, workspace-page, sidebar-visibility, or list-target changes. Refresh open menu anchor and placement
apps/mobile/src/components/ui/AndroidAnchoredMenu.android.tsxMenus measure the anchor when opening and when panes settle. The anchor snapshot includes the hinge, which is used for horizontal placement and popup adjustment. Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix · Severity of issue fixed: Low
Suggested reviewers:
juliusmarminge
Merge Risk: External image Low · up to 0d3b3
-
An open thread-filter menu may briefly remain detached from its button if the viewport changes during a hinge-driven sidebar resize. This is a bounded edge case and is suitable for follow-up.
Security architecture risk: External image Minimal · up to 3fa97
-
The change remains within Android menu positioning. The reviewed changes do not add permissions, remote entrypoints, data access, or persistent state, and no material security risk was identified.
Retained concerns No architecture-level concerns identified.
Security review details
-
Security Blast Radius
- inferred — The demonstrated changed exposure is local to Android anchored-menu placement under the workspace provider. The public-entrypoint routing does not correspond to a new attacker-facing service or an expansion of menu action authority.
-
Pre-merge checks: Passed 4
-
Check name Status Explanation Title check Passed The title clearly and concisely describes the primary fix: Android menus follow their buttons when a foldable hinge changes the split. Description check Passed The description includes complete Problem, Change, Scope and approval, and Verification sections. It provides reproduction steps, implementation details, linked issue context, test results, device val… Linked Issues check Passed [ #21962] requires open Android anchored menus in the workspace layout to remain attached to their buttons after a hinge-driven split change.AndroidAnchoredMenuremeasures its anchor when `panesSett…Out of Scope Changes check Passed The whole-PR changes are limited to AndroidAnchoredMenu.android.tsx,AdaptiveWorkspaceLayout.tsx, andwindow-hinge-context.ts. The menu changes implement hinge-aware anchor snapshots and settle-…Full details: Description check
-
Explanation
The description includes complete Problem, Change, Scope and approval, and Verification sections. It provides reproduction steps, implementation details, linked issue context, test results, device validation, limitations, screenshots, and recordings.
Full details: Linked Issues check
-
Explanation
[
#21962] requires open Android anchored menus in the workspace layout to remain attached to their buttons after a hinge-driven split change.AndroidAnchoredMenuremeasures its anchor whenpanesSettledchanges, stores the matching hinge inAnchorSnapshot, and uses that snapshot for placement.AdaptiveWorkspaceLayoutadvancespanesSettledafter real pane movement and for hinge changes without a pane slide. The open-time keyboard snapshot remains unchanged. The reported typecheck, focused tests, lint, andcheck:changedchecks pass. The reported emulator and device tests show re-anchoring after pane settling.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR changes are limited to
AndroidAnchoredMenu.android.tsx,AdaptiveWorkspaceLayout.tsx, andwindow-hinge-context.ts. The menu changes implement hinge-aware anchor snapshots and settle-triggered measurement. The layout changes provide the required pane-settle count. The context changes expose the hinge and count to workspace overlays. These changes directly support [#21962]. No unrelated feature, setting, or behavior appears in the reviewed changes.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
External image Recent review info
-
External image Run configuration
-
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: main
- File: .coderabbit.config.ts
- Commit: c82e1ba
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
7baf86aa-b283-4af5-bc7d-bf4076f3ca9d
External image Commits
-
Reviewing files that changed from the base of the PR and between 95fd7c52f57c3b49f5dba1e8c064292d6590b516 and 0d3b321a9a1efa3e4cb8ba70fc3564bb5ab64d67.
External image Files selected for processing: 2
-
apps/mobile/src/components/ui/AndroidAnchoredMenu.android.tsxapps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
External image Recent review info
-
External image Run configuration
-
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: main
- File: .coderabbit.config.ts
- Commit: c82e1ba
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
7baf86aa-b283-4af5-bc7d-bf4076f3ca9d
External image Commits
-
Reviewing files that changed from the base of the PR and between 95fd7c52f57c3b49f5dba1e8c064292d6590b516 and 0d3b321a9a1efa3e4cb8ba70fc3564bb5ab64d67.
External image Files selected for processing: 2
-
apps/mobile/src/components/ui/AndroidAnchoredMenu.android.tsxapps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
-