fix(claude): preserve subagent task context snapshots #21644 · pingdotgg/t3code

Added 2 commits5d ago

fix(claude): preserve subagent task context snapshots5befc57
fix(claude): keep workflow totals separate from task context93c22b6

MmacroscopeappBotapproved these changes5d ago

Approvability

Verdict: Approved at 93c22b6

Macroscope's review found this PR approvable — This is a narrowly scoped Claude adapter bug fix that populates an existing subagent context-usage field while preserving snapshot and resume semantics. Targeted tests cover idle completion, stale snapshot clearing, decreasing values, zero values, and separation from workflow totals.

^{You can add or adjust custom eligibility rules. Learn more.}

Ggithub-actionsBot5d ago

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Codex	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Codex	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Codex	Live turn WebSocket decoded	—	20.9 KiB	—	29.3 KiB	✅
Codex	Live turn messages	—	2	—	8	✅
Claude	Total thread wire	—	5.0 KiB	—	6.8 KiB	✅
Claude	Thread snapshot wire	—	3.8 KiB	—	4.9 KiB	✅
Claude	Live turn WebSocket wire	—	1.2 KiB	—	2.0 KiB	✅
Claude	Live turn WebSocket decoded	—	21.2 KiB	—	29.3 KiB	✅
Claude	Live turn messages	—	2	—	8	✅

Baseline: unavailable · PR result: 93c22b6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

CcoderabbitaiBot5d ago

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Team
Run ID: 6898c358-69eb-4ae4-896b-55a33cbf74a1

📥 Commits

Reviewing files that changed from the base of the PR and between 90df6f1425d462c234423abeab9b51783340ed0e and 93c22b64a6ef44dd0a6b714a1cbcb40e317be9d0.

📒 Files selected for processing: 2

apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The Claude adapter now forwards usage totals from subagent progress and completion updates, clears usage when tasks are reopened, and updates workflow totals from workflow snapshots without assigning usage to workflow coordinators.

Changes: Claude usage tracking

Layer / File(s)	Summary
Subagent usage lifecycle `apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts`, `apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts`	Subagent progress and completion updates store token and tool-use counts. Reopened tasks clear previous progress and usage. Tests cover usage updates, empty progress descriptions, and resumed tasks.
Workflow usage totals `apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts`, `apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts`	Workflow completion forwards usage, and workflow snapshot tests verify updated workflow totals while coordinator usage remains undefined.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 93c22

This change forwards subagent context usage and clears it on reopen. No actionable merge-blocking issues remain.

Pre-merge checks: ^Passed 4

Check name	Status	Explanation
Title check	Passed	The title clearly identifies the main change: preserving Claude subagent task context snapshots.
Description check	Passed	The description explains the problem, implementation, scope, dependencies, verification results, review coverage, and verification limits. It does not use the template headings or provide explicit mai…
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, scope, dependencies, verification results, review coverage, and verification limits. It does not use the template headings or provide explicit maintainer approval, but the required information is substantially present.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Mode: Continue automatically
Reviewed files: 2
Charged: $0.50
View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

_{Comment @coderabbitai help to get the list of available commands.}

JJulius Marminge5d ago

Validated current head 93c22b6 over #21643: current-head CI is green, with normal skipped jobs. The cancelled native fingerprint job was superseded by a successful run of the same workflow/head. Macroscope approved this head; CodeRabbit found no actionable comments, and there are no review threads. Both independent second-round full-stack reviews are clean. Provider/native/remote verification limits are explicit in the description. Ready for maintainer review; unmerged.

fix(claude): preserve subagent task context snapshots#21644

Checks

Approvability

Thread transfer impact

Usage-based review receipt