refactor(server): share scheduling for tasks and limit recovery#12795

🟡 Medium scheduling/Scheduler.ts:60

The scheduler performs no work for the first five seconds after startup, so overdue tasks and due usage-limit recoveries are unnecessarily delayed. Line 60 enters sleep before the first tick; run tick once before starting the sleeping loop.

No longer relevant as of f5cc6ed2573c9e2c9aa81a6d69bd11530fe3a768

Fixed in b875b89: each source checks due work immediately when it registers, then uses the shared five-second scheduler. A tick during scheduler construction would run before sources exist, so registration is the useful startup trigger. The focused tests now wait for startup receipts before advancing the clock; all 50 scheduler/task tests and the server typecheck pass.

This service module owns construction, so expose a real make before layer rather than constructing it inline in Layer.effect. Extract the current construction effect as export const make = Effect.gen(...), then define export const layer = Layer.effect(Scheduler, make).

No diff: this requires moving the construction body and changing the layer declaration.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in 024025a: Scheduler exposes its construction as make, and all consumers use the Scheduler module namespace. The 50 focused scheduler/task tests, server typecheck, and targeted lint pass.

Import this service module as a namespace so the service boundary retains its public shape. Use import * as Scheduler from "../scheduling/Scheduler.ts", then acquire yield* Scheduler.Scheduler.

No diff: the import and consumer are in separate hunks.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in 024025a: Scheduler exposes its construction as make, and all consumers use the Scheduler module namespace. The 50 focused scheduler/task tests, server typecheck, and targeted lint pass.

Import this service module as a namespace so consumers use its public service boundary. Use import * as Scheduler from "../scheduling/Scheduler.ts", then acquire yield* Scheduler.Scheduler.

No diff: the import and consumer are in separate hunks.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in 024025a: Scheduler exposes its construction as make, and all consumers use the Scheduler module namespace. The 50 focused scheduler/task tests, server typecheck, and targeted lint pass.

orchestration-v2/runtimeLayer.ts:2

Import the service module as a namespace rather than aliasing its layer export. Use import * as Scheduler from "../scheduling/Scheduler.ts" and provide Scheduler.layer.

No diff: the import and use are in separate hunks.

No longer relevant as of 024025a0145ebd899e775f24af2550ad1bda64a2

Fixed in 024025a: Scheduler exposes its construction as make, and all consumers use the Scheduler module namespace. The 50 focused scheduler/task tests, server typecheck, and targeted lint pass.

orchestration-v2/runtimeLayer.ts:1

Import this Effect worker module as a namespace so its public boundary remains visible: use import * as UsageLimitRecoveryService from "./UsageLimitRecoveryService.ts", then reference UsageLimitRecoveryService.workerLive.

No diff: the import and consumer are in separate hunks.

No longer relevant as of 62c0cf705d7f3212cc3dff4f048c64681199cf17

Already fixed in the current integrated head 62c0cf705d7: runtimeLayer imports UsageLimitRecoveryService as a namespace and references UsageLimitRecoveryService.workerLive. Scoped server typecheck and lint pass.

make has regressed to a private constructor even though this module owns the service construction. Export it as the canonical service constructor.

^{Posted via Macroscope — Effect Service Conventions}

Keeping make private because required CI knip explicitly failed on this unused export. Both production consumers use Scheduler.layer, which owns construction and exposes the service requirements; there is no external consumer of a direct constructor. Exporting an unused API or suppressing the unused-export check would add no functionality. The five scheduler lifecycle/integration tests and scoped server typecheck pass.