Synced from GitHub
🚅 Environment ployz-pr-1885 in Ployz Dashboard has no services deployed.
Drop stale applied-line match from the faults recovery check#1885
The faults scenario checked that the resumed Cloud deploy printed of verify/production: applied. The Deploy output no longer prints that line, so the check failed on runs where recovery worked. It now asserts only that the deploy exits 0 and that deployment ls shows the Deployment completed.
The check still fails when recovery fails. Baseline runs on main bde2b7430 hit both failure kinds. Run 4c60a448b3 exited 3 with 1 unknown. Run 420c04868c timed out after about 600 s with Deployment #2 did not complete. Those are product recovery failures, and this PR leaves them failing.
There are no timing numbers here. This is a correctness fix that lets the faults scenario pass when the product recovers.
Tests: python3 -m unittest test_cloud_recovery passes.
Checks
1 pending · 15 successful · 2 skipped
In progress1
- In progress
Added 1 commit
- Drop stale applied-line match from the faults recovery check5e39360
Synced from GitHub
Note
Currently processing new changes in this PR. This may take a few minutes, please wait...
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
d04a7bcf-267a-4e1e-a3af-3eacb96ed1ba
📥 Commits
Reviewing files that changed from the base of the PR and between 3f1e4155c4cba52fb2dc768f33bd15d913684162 and 5e3936074b549fbe2b0d7e6c35da0a65a53f5d39.
📒 Files selected for processing: 2
core/scripts/verify/cloud_recovery.pycore/scripts/verify/test_cloud_recovery.py
ascii
| 1 | ______________________________________________ |
| 2 | < Plot twist: The bug was a feature all along. > |
| 3 | ---------------------------------------------- |
| 4 | \ |
| 5 | \ \ |
| 6 | \ /\ |
| 7 | ( ) |
| 8 | .( o ). |
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Synced from GitHub
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.