Build verify binaries without debuginfo#1807

merged1
main
verify-fast/a1-debuginfo-off
openedOct 13, 2026byNNick
View on GitHubGitHub import enabledPR last imported 21d ago

verify-cluster strips DWARF from ployz and ployzd right after compiling them, so the harness's dev build now skips it. Measured on this host, a one-line ployz-core rebuild took 31% less time and the two binaries shrank from 1.33 GB to 345 MB before stripping. CI already builds with CARGO_PROFILE_DEV_DEBUG=0.

Checks

16 successful Ā· 1 skipped
All checks passed
c6024d5
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review. šŸŽ‰

ā„¹ļø Recent review info
āš™ļø Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1b5fa4cb-8d6a-4c0c-9a7d-2d7f555647a8
šŸ“„ Commits

Reviewing files that changed from the base of the PR and between 120f54531c5107aedee6d42c3a8cd57e8143600c and c6024d591f19743cfcbc1931cd3634c14e4d58cf.

šŸ“’ Files selected for processing: 1
  • core/scripts/verify-cluster

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

šŸ“ Summary

Summary by CodeRabbit

  • Chores
    • Development-profile builds now omit debug information.

The cluster verification build now sets CARGO_PROFILE_DEV_DEBUG=0 for Cargo. It retains the existing build arguments and timeout.

Changes: Cluster verification build

Layer / File(s)Summary
Set build environment
core/scripts/verify-cluster
The build function sets CARGO_PROFILE_DEV_DEBUG=0. Comments state that binaries are stripped and CI uses the same setting.

Priority: ā¬‡ļø Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c6024

This change disables development debug information for the verification build, matching cluster CI. No merge-blocking risk is evident.

### Architecture Summary

Architecture risk: šŸ”µ Low Ā· up to c6024

The change affects 1 system.

Changed systems: core

Architecture concerns No architecture-level concerns identified.

Review details

Systems and components

  • observed — core (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in core/scripts/verify-cluster: build now passes CARGO_PROFILE_DEV_DEBUG=0 to Cargo while retaining the existing build arguments and timeout; the added comments state that binaries are stripped and CI uses the same setting.
Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely describes the main change: disabling debuginfo when building verification binaries.
Description checkPassedThe description explains that the verification build skips debuginfo because the binaries are stripped after compilation, and it provides performance and size measurements.
Docstring CoveragePassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix Ā· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Synced from GitHub

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
šŸ“ Code Reviewāœ… Completed 2026-10-13T23:29:11.821148Zc6024d5New commits
ā„¹ļø About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with šŸ‘€ while any review is running, comments if it has suggestions, and reacts with šŸ‘ once all reviews finish with no findings.

Added 1 commit

  • Build verify binaries without debuginfoc6024d5