Sign up
View stargazersSign up

Check the Docker log decoder against the latest Docker on main pushes only#1675

merged1
ci/narrow-release-contracts
ci/docker-decoder-nightly
openedOct 12, 2026byNNick
1 files changed
View on GitHubGitHub import enabledPR last imported 21d ago

The step installs the newest Docker and pulls an image on every rust-tests run, about 2 minutes. What it mostly catches is drift in Docker's log format, which has nothing to do with the pull request under review. Main pushes still run it, so a decoder regression shows up right after merge.

Checks

2 failing · 14 successful · 1 skipped
Some checks failed

Failing2

913ca81
CcoderabbitaiBotOct 12, 2026
Synced from GitHub

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 07225ea6-928a-42f6-a142-a9d36b82c98a
📥 Commits

Reviewing files that changed from the base of the PR and between 65040cbfc4ffaac9cf2adcd485aaf5987fcf8607 and 913ca8131686e2fd33a5a2b3620413eede529a55.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 280f0c23-0c05-4dde-983b-283042ce9938
📥 Commits

Reviewing files that changed from the base of the PR and between 3bd639e08a01142521d8334719dbadc8d784d79a and 7002dcecea0a56b3bada31a1a326f148bdf8ea91.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Tests
    • The Docker log-decoding integration test now runs on push events only. It no longer runs for other event types, reducing the time spent on those CI runs. The test continues to run on pushes and takes about two minutes.
📝 Summary
📝 Summary
📝 Summary

Walkthrough

The CI workflow now runs the Docker log-decoding integration step only on push events. A comment describes the step as intended for main pushes and notes its approximate runtime.

Changes

CI test gating

Layer / File(s)Summary
Gate the Docker test on push events
.github/workflows/ci.yml		The Docker log-decoding integration step now runs only when github.event_name == 'push'. A comment notes that it is intended for main pushes and takes about two minutes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 7002d

The Docker check is skipped on pull requests and manual runs but remains enabled on main pushes, as intended. No merge-blocking issue is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 7002d

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/ci.yml: The Docker log-decoding step is now guarded by github.event_name == 'push'; it previously had no event condition. A new comment describes the step as intended for main pushes and notes its approximate runtime.
Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title checkPassedThe title clearly and specifically describes the main change: limiting Docker log decoder checks to main pushes.
Description checkPassedThe description explains why the check runs only on main pushes and confirms that main pushes still run the check.
Docstring CoveragePassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Cchatgpt-codex-connectorBotOct 12, 2026
Synced from GitHub

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code Review✅ Completed 2026-10-12T16:24:10.942711Z913ca81New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

NNickOct 12, 2026

Independent verification

PASS at 3bd639e08

  • ci.yml:155: github.event_name == 'push' equals "main push", because push is limited to main. PRs and workflow_dispatch skip the step. The implicit success() is kept. Nothing after it depends on Docker; only upload-artifact follows. The test is --run-ignored only, so the normal nextest run doesn't need Docker.
  • Note: the step runs only on main pushes that select rust-tests. Dashboard-only pushes never check Docker drift, and manual dispatch can't run it.
  • actionlint clean. No CI failures; rust-tests was still pending.
NNickOct 12, 2026

Independent verification (delta)

PASS at 7002dcece. The new commit only merges #1674 (the #1673/#1674 changes above). The Docker step change is the same as before.

  • actionlint clean. test-ci.py OK. CI still pending, no failures.
NNickOct 12, 2026

Independent verification (delta 2)

PASS at 2d009af5f. The new commit only merges #1674 (fb3bb565d, verified there).

  • actionlint clean. test-ci.py OK.
NNickOct 12, 2026

Independent verification (delta 3)

PASS at 65040cbfc. The new commit only merges #1674 (b26efe065). The only remaining diff against it is the Docker step.

  • actionlint clean. test-ci.py OK.

Added 1 commit

  • Check the Docker log decoder against the latest Docker on main pushes only913ca81
Cchatgpt-codex-connectorBotreviewed · 1 inline threadOct 12, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 913ca81316

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.github/workflows/ci.ymlline 157Open thread
……@@ -152,7 +152,9 @@ jobs:
154154 # Last: installing Docker restarts dockerd, which stops the Postgres service.
155+ # Main pushes only: it mostly catches drift in the newest Docker release, and costs 2 minutes per run.
155156 - name: Decode the latest Docker's local log files as docker logs prints them
157+ if: github.event_name == 'push'
Cchatgpt-codex-connectorBoton line 157Oct 12, 2026

P2 Badge Preserve the decoder check across canceled main builds

When a core-changing main push is followed quickly by a documentation-only push, the workflow-wide cancel-in-progress: true cancels the first run, while scripts/ci.py selects only contracts for the replacement run and therefore skips the entire rust-tests job. GitHub documents that a new run cancels in-progress runs in the same concurrency group. Because the PR run now always skips this step, that sequence leaves the decoder change entirely unchecked; move this check to a non-cancelable workflow/job or ensure the latest main run schedules it regardless of its own changed paths.

Useful? React with 👍 / 👎.