Sign up
View stargazersSign up

feat(dashboard): show and edit Configs on the canvas#1436

merged22
configs/c4-config-changes
configs/c5-canvas
openedOct 6, 2026byNNick
46 files changed
View on GitHubGitHub import enabledPR last imported 21d ago

Summary

Create and edit Configs from the dashboard. Config trays, Finder results, and creation open the Config inspector. The editor supports nested filenames, Service references, safe previews, and shared Service mounts.

Saving keeps newer text intact while earlier writes settle. Renaming a Config preserves local drafts, and switching files isolates undo history.

Typed references to unexported variables show their dependencies and secret status. Preview still masks secrets, and autocomplete still suggests only exported variables.

Scope covers authoring and mounts. C6 supplies full file comparisons in Environment changes.

Evidence

Before the fixes, an earlier save response could replace a queued newer edit, a rename could discard drafts, and Undo could cross file boundaries. Each defect was reproduced in the browser and fixed with a regression test.

The original C5 dashboard gate passes with 1,131 tests. The final diagnostic correction passes 42 focused tests and independent review. The integrated C6 pnpm pr:check passes all stages and 1,145 tests. Browser replays and reloads prove draft retention, isolated Undo, correct unexported reference labels, masked previews, persistent mounts, and deployment to actual read-only files.

Merge Danger

Door: Two-way.

Blast Radius: Authoring.

File edits remain staged until deployment. Config deletion removes its Service mounts on the next deployment and remains discardable beforehand.

Checks

10 successful · 6 skipped
All checks passed
d439bbf
Cchatgpt-codex-connectorBotOct 6, 2026
Synced from GitHub

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code Review✅ Completed 2026-10-06T05:56:13.734375Zd832601New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Cchatgpt-codex-connectorBotreviewed · 1 inline threadOct 6, 2026
Synced from GitHub

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d832601f49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dashboard/src/routes/_protected/cloud/$organizationSlug/_project/$projectSlug/$environmentSlug/-components/canvas/StoreConfigNode.tsxlines 21–22Outdated · d832601Open thread
……@@ -0,0 +1,53 @@
19+ return (
20+ <Link
21+ to={ENVIRONMENT_RESOURCE_ROUTE_TO}
22+ params={{ ...params, resourceId: config.id }}
Cchatgpt-codex-connectorBoton lines 21–22Oct 6, 2026

P1 Badge Render a Config inspector for Config resource routes

Clicking a Config node sends its UUID through the generic resource route, but that route still renders StoreVolumeDrawer, which only searches the volumes view by resourceId. Consequently no Config can match and users land on the Volume-not-found state; trays, Finder entries, and the post-create navigation all use this same destination, so the new Config UI cannot be edited.

Useful? React with 👍 / 👎.

Added 22 commits

  • docs: describe Config trays and the Config drawer for agents06e00cb
  • fix: retain latest Config save ownership through draft edits0af916f
  • fix(cloud): preserve Config edits during optimistic saves153cd7c
  • test(cloud): cover Config draft loss and nested filenames1930ed7
  • fix: guard Config drafts until pending saves persist23a73dd
  • refactor(dashboard): drop redundant Config comments and keep a refused mount's pick2f4d8be
  • fix(dashboard): preserve Config drawer identity through replacement3f91eaa
  • test: reproduce Config pending-save navigation data loss5074f95
  • test: reproduce unexported Config reference diagnostics7014e6a
  • test(cloud): cover Config editor draft ownership9c77d7a
  • fix(dashboard): show Config editor tooltips over the drawer and leave it after deletea06c2ff
  • fix(cloud): preserve Config editor state through saves and renamesaad52b3
  • feat(dashboard): add the Config file editor on CodeMirror 6c024797
  • feat(dashboard): find and preview ${{ }} references in Config filesc5770ab
  • perf(dashboard): prefetch a Config's files on hoverdd1b456
  • test: retain Config save ownership after editing back to submitted textdded6ed
  • feat(dashboard): Config Store queries, commands and trays for Configse82075c
  • feat(dashboard): edit Configs in a drawer and mount them from Service Storagee9d9a6c
  • feat(dashboard): Configs as trays and nodes on the canvas, created from the Create menueb41ce6
  • fix: classify Config references from all known variablesf4bea31
  • fix(dashboard): target Config optimism by Working identityc35f3ba
  • fix(dashboard): mark Config mount changes by identityd439bbf