Sign up
View stargazersSign up

fix(mobile): iOS rename prompt text field no longer overflows the dialog#22569

draft12
main
GitHub fork: fix/mobile-rename-dialog-input-overflow
opened20d agobySsaphid
9 files changed
View on GitHubTwo-way sync enabledPR last imported 10d ago

Problem

On an iPhone running iOS 26 (Nightly build), the Rename thread prompt rendered its text field shifted past the alert's trailing edge. On the simulator, the same overflow appears when the alert lays out again while open (see Evidence). The field's left edge sits inside the card, but its right side runs past the alert. Every iOS Dialog.prompt uses this alert: Rename thread (thread list context menu) and Link pull request (PR and git sheets). The iOS implementation used React Native's Alert.prompt, which is a stock UIAlertController with addTextFieldWithConfigurationHandler, so the layout comes from UIKit and we can't fix it from JS.

Repro: on iOS 26 (Nightly), long-press a thread on Home and choose Rename.

Expected: the input sits inside the dialog, like Android's Compose dialog.

Change

  • Dialog.tsx (iOS): prompt now hands the request to an in-app dialog in the new DialogHost.tsx, mounted at the app root where Dialog.Host was. Keeping the UI in DialogHost means modules that only call Dialog.alert don't pull native UI modules into their unit tests. The dialog is a transparent fade Modal with a GlassSurface card, an AppTextInput, and Cancel and primary buttons. These are the same building blocks and tokens the command palette uses. alert and confirm still use native Alert.
  • A React Native Modal presents from its nearest view controller, and the root controller can't present over a native form sheet. So hosts register as a stack: the most recently mounted one presents. ThreadPullRequestsSheet and GitOverviewSheet mount DialogSheetHost, because Link pull request opens from those sheets. On Android, DialogHost.android.tsx re-exports the existing Compose host and DialogSheetHost is a no-op because Compose dialogs open in their own window.
  • Robustness: a second tap can't confirm twice. Content scrolls when a long message and large text don't fit above the keyboard. Buttons stack vertically at large Dynamic Type sizes.

Scope and approval

No prior issue. I think this qualifies as a small, focused fix for an obvious visual bug in an existing control, with no change to product behavior. The prompts keep the same callers, options, and callback semantics. The sheet host is only there because the in-app prompt has to present over sheets.

Verification

  • Current integration (ea2f2e5, 2026-10-23): retained main's sheet headers/toolbars alongside the dialog sheet hosts and main's test pruning. All three retained dialog tests, mobile typecheck, scoped lint and formatting pass; required hosted checks pass on this commit. Native captures and broader test counts below belong to the explicitly identified earlier revisions. No new native session was run; this PR remains draft pending acceptance.
  • Full mobile suite (vp test run --project unit --project react): 289 files pass. The new DialogHost.test.tsx covers that an edited value is confirmed exactly once under a double tap, and that a mounted sheet host presents before the root host, falling back to the root host after the sheet unmounts. The existing Android dialog test still passes.
  • tsc-rs --noEmit in apps/mobile is clean. vp lint reports no new warnings. The web Cannot find module 'mermaid' typecheck error also reproduces on main without this change; #22570 and #22571 address it.
  • iOS Simulator run on an iPhone 17 Pro, dark appearance, against an isolated dev backend with synthetic fixture threads. Base is the merge base fe414eb and candidate is this PR's head 8253ac3, on the same dev client build with Metro switched between worktrees. See Evidence below.
  • Not checked: a physical iOS 26 device, the Link pull request entry in the Linked pull requests sheet (it needs a thread that already has a linked PR, and only the Git sheet entry was exercised), and Android.

Evidence

MP4s are real-time simctl recordVideo captures. GIFs are 8 fps derivatives, sped up as labelled. The long-press was sent as a pointer hold in the Simulator window, and the menu's Rename item was activated with an accessibility press. Thread data is synthetic.

Rename thread: normal flow (iOS 26.5 Simulator)

The simulator did not reproduce the overflow reported from iOS 26 Nightly on a device. On a fresh presentation, base renders Alert.prompt with the field inside the alert on both iOS 26.5 and iOS 27.0. On iOS 27.0 that also held at XXXL text size. These GIFs show the same flow on base and candidate: long-press, Rename, edit, confirm, title updated in the list. Candidate selects the current title on focus, so the full new title is typed instead of appended.

Before (base fe414eb): native Alert.prompt. No overflow on this simulator.

Before, base fe414eb, iOS 26.5 Simulator: long-press thread, Rename opens the native alert prompt, append " fix", Rename updates the list title

After (candidate 8253ac3): the in-app prompt opens from the long-press context menu after the menu dismisses, and the confirmed title shows in the list.

After, candidate 8253ac3, iOS 26.5 Simulator: long-press thread, Rename opens the in-app prompt, type the new title, Rename updates the list title

Before recording · After recording

Rename thread: field overflows after a relayout (iOS 27.0 Simulator)

The same overflow shows on the simulator when the alert lays out again while it's open. In this run the Dynamic Type size changes to XXXL and back with the prompt open (simctl ui content_size). This trigger is different from the reported one; the reported one didn't reproduce here.

Before (base fe414eb): after the size change, the UIAlertController text field shifts right and runs past the alert's trailing edge. It stays that way while typing and confirming.

Before, base fe414eb, iOS 27.0 Simulator: after a text size change the alert text field overflows the trailing edge

After (candidate 8253ac3): the same size change re-lays the in-app dialog, with stacked buttons at XXXL, and the field stays inside the card.

After, candidate 8253ac3, iOS 27.0 Simulator: the same text size change keeps the field inside the dialog

Field after the size change, full resolution:

Before detail: base alert text field extends past the right edge of the alert

After detail: candidate dialog text field sits inside the card with equal margins

Before recording · After recording

From thread → Git → More, tapping Link pull request presents the prompt on top of the native form sheet. Typing 42 works, and Cancel returns to the sheet. Nothing was linked.

Candidate 8253ac3: Link pull request prompt presents over the Git sheet, accepts input, Cancel returns to the sheet

Recording

Written with Claude Opus 5.5 in Claude Code (T3 Code harness).

🤖 Generated with Claude Code

Checks

20 successful · 9 skipped
All checks passed
ce20557

Added 6 commits

  • fix(mobile): keep Dialog imports light for unit tests8253ac3
  • fix(mobile): iOS rename prompt text field no longer overflows the dialog8617f93
  • chore(mobile): reconcile rename dialog with current sheet headersea2f2e5
  • chore(mobile): merge main into iOS prompt fixb040db4
  • fix(mobile): defer prompt callbacks until modal dismissal1a7e7f2
  • fix(mobile): keep hidden git inspectors out of prompt hosts4247310
Mmaria15d ago

Note

Written by gpt-6.1-sol on behalf of Maria

updated the original branch at 4247310e70028e2dcad15e3e951af580eb8dcb33, preserving @saphid's commits and prompt ui.

  • merged current main and resolved the dialog conflict without rebasing.
  • confirm/cancel callbacks now wait for native modal dismissal, so validation alerts and subsequent prompts can present. repeated taps and dismissal events still run the callback once.
  • restricted the git sheet's extra host to sheet presentation. a retained hidden inspector can no longer take ownership of later rename prompts.

verification: three callback-timing regression cases failed before the fix. all five dialog tests pass afterward, including the existing android host test. blacksmith vp run check:changed passed formatting, lint, both knip passes, affected typechecks, and focused tests. final-head ci has no failing or pending checks. two independent code reviews found no remaining code defects after the inspector fix. the draft review bot skipped review.

unverified: current-main native overflow reproduction, rename, both link-pr sheet prompts, dynamic type, rotation, and matching before/after screenshots/video. device discovery returned "Agent device access is turned off for this environment." the linux browser cannot reproduce UIKit's alert or native sheet lifecycle. no new native evidence was captured; the existing body evidence is from the contributor's older revisions. main still uses the affected Alert.prompt path, but that source check is not a fresh reproduction.

keeping this draft pending on-device verification and human approval. web/desktop and provider paths are unchanged; android retains its existing presenter. task-owned dev server and check workers have been stopped.

Added 1 commit

  • chore(mobile): merge main into rename dialog fix2c58482
Mmaria13d ago

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

none of the changed runtime behavior could be exercised on this linux boat vm. result: unverifiable, not a runtime pass.

inspected the description, full diff, discussion, authors, and current head 2c584827a1cbf665ead9a050cd41e13effc57de8. the pr is open as a draft; its listed commits have neither @juliusmarminge nor @t3dotgg as authors. git.cafe reports 28 successful checks, zero failing and zero pending. these checks do not prove native behavior.

runtime prerequisite transcript:

text
1uname: Linux x86_64
2xcrun: unavailable
3device_list: Agent device access is turned off for this environment.
4adb devices -l: no attached devices

Not verified

main's ios overflow reproduction; the current head's rename prompt, edit/confirm/cancel, repeated submission, keyboard and dynamic type layout, rotation, and link-pr prompts over both native sheets. native alerts/confirms and android presentation also remain unverified.

the change replaces ios UIKit Alert.prompt with a React Native Modal and native sheet hosts. desktop chrome, including a mobile viewport, cannot exercise these paths. no main/pr worktree installation, dev server, project/thread creation, or codex provider turn was attempted after discovering the missing native client prerequisite. no new screenshots or recordings were captured; older evidence in the description was not treated as verification of this head.

an ios-capable device host with device access enabled is needed for the requested before/after pass on main and this exact head, with real app-created threads and codex gpt-6.1-sol. no code, branch, labels, or pr state changed.

Mmaria13d ago

Note

Written by gpt-6.1-sol on behalf of Maria

Verified on Android emulator (API 35) against a real dev server

none. stopped at the brief's explicit step 1 condition: the changed prompt behavior is ios-only. this is not an android runtime pass.

read the full diff, description, discussion, and listed commit authors at head 2c584827a1cbf665ead9a050cd41e13effc57de8. the pr remains an open draft; neither @juliusmarminge nor @t3dotgg is among the listed commit authors. git.cafe's open-head filter returned no result because its draft state is separate; the draft-head filter identifies this mirror as #22569.

source evidence: Dialog.tsx replaces ios Alert.prompt with the in-app presenter; DialogHost.android.tsx re-exports the existing Dialog.android host and makes DialogSheetHost a no-op. the shared root import preserves that existing android presenter. an android run cannot reproduce UIKit overflow or validate ios modal dismissal and sheet presentation.

device discovery now reports android available with the t3 avd. ios reports: iOS Simulators need macOS with Xcode. no emulator, dev server, installation, codex turns, screenshots, or recordings were started after the required stop condition. no code, branch, labels, or pr state changed. git.cafe reports 28 successful checks, zero failing and zero pending; these are not native verification.

Not verified

ios cannot run on this linux vm. the original overflow, current-head rename confirm/cancel and repeated submission, keyboard, dynamic type, rotation, and link-pr prompts over both native sheets remain unverified. android regression behavior also remains unverified because the brief requires stopping for an ios-only change. current-head native evidence still requires an ios-capable host.

Added 3 commits

  • chore(mobile): merge main into rename dialog fix33582d9
  • fix(mobile): update prompt host effect lint directive5a8ba82
  • fix(mobile): preserve fullscreen prompts and orientation1beb1fe
Mmaria11d ago

Note

Written by gpt-6.1-sol on behalf of Maria

pushed 1beb1fec75b8853362fa6c1c790a97dbbd9ab1c5 to the original saphid branch without force. merged main, preserved its navigation changes, updated the effect lint directive, added the missing fullscreen-thread prompt host, and preserved iPad/Duo modal orientations. the original diff grew by three lines and one file.

blacksmith vp run check:changed 97e35bcf23e4dcf34c2dcffadd37c08db0e01e52 passed formatting, lint, both knip passes, affected typechecks, eight dialog tests, and selected React Compiler checks. two independent reviews found no remaining code findings at the final SHA. git.cafe reports 29 successful check contexts, zero failing/pending; github confirms no failed/pending jobs and no conflicts. skipped jobs remain skipped.

still unverified: current-head iOS rename, both sheet-link prompts, fullscreen save-plan, callback dismissal, keyboard/Dynamic Type, and rotation. this Linux VM has no Xcode/iOS runtime; Playwright with Chrome cannot exercise native UIKit presentation. no new UI evidence was captured. older body evidence does not verify this head. leaving the existing draft pending native verification. no dev servers were started; the task's blacksmith worker is stopped.

Mmaria11d ago

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

none of the changed runtime behavior could be exercised on this linux boat vm. result: unverifiable.

inspected the full diff, description, discussion, and commit authors at head 1beb1fec75b8853362fa6c1c790a97dbbd9ab1c5. the pr is an open draft, with no listed commits authored by @juliusmarminge or @t3dotgg. the requested git.cafe open-head query returned no results; its draft-head query identifies https://git.cafe/pingdotgg/t3code/pulls/22569. git.cafe currently reports 29 successful checks, zero failing and zero pending. this is CI status, not runtime proof.

runtime prerequisite checks this turn:

text
1uname -srm: Linux 6.8.0-117-generic x86_64
2xcrun: unavailable
3adb devices -l: no attached devices
4device_list: Agent device access is turned off for this environment.

Not verified

main overflow reproduction and current-head ios rename/edit/confirm/cancel; repeated submission and callbacks after native modal dismissal; keyboard, dynamic type and rotation; link-pr prompts over both native sheets; fullscreen save-plan prompts; neighboring native alerts/confirms and android presentation.

the diff replaces ios UIKit Alert.prompt with a React Native Modal and adds native sheet/fullscreen hosts. android keeps its existing Compose presenter. Playwright with Chrome cannot execute the changed UIKit path, even at a mobile viewport size. an ios-capable device host with device access enabled is required for the requested before/after pass.

no main/pr installation, dev server, app-created project/thread, or codex provider turn was attempted after confirming this prerequisite blocker. no screenshots or recordings were captured or uploaded, and older evidence in the description was not treated as current-head proof. no code, branch, labels, or pr state changed. no task-owned dev server is running.

Added 1 commit

  • chore(mobile): merge main into rename dialog fixacbb04b
Mmaria10d ago

Note

Written by gpt-6.1-sol on behalf of Maria

pushed acbb04bbab58515e5c53215e7f6c0226310873d9 to the original fork branch without force. merged current main and resolved the mobile test-list conflict by retaining both entries. no production changes were needed. the diff remains 9 files, 311 additions and 15 deletions.

blacksmith vp run check:changed 6d46336476941257d774be7c7733e9caf201fec2 passed formatting, lint, both knip passes, affected typechecks, all eight dialog tests, and selected compiler checks. two independent code reviews approved this head without blocking findings. fresh CI has no failing or pending checks; GitHub confirms no conflicts. skipped jobs remain skipped. there are no inline review findings to address.

native iOS presentation, rename confirm/cancel, sheet/fullscreen prompts, keyboard, Dynamic Type and rotation remain unverified on this Linux VM. Chrome cannot execute UIKit presentation. no new UI evidence was captured. leaving the existing draft pending native verification. no dev servers were started; the blacksmith worker is stopped. nothing was merged.

Added 1 commit

  • Merge commit 'bf8e1324391a570fbca298cfd0c97d39381666a3' into ready/mobile-22569ce20557