test(server): skip posix executable fixtures on a Windows host#9565

merged1
windows-tests/path-platform
windows-tests/posix-fixtures
openedSep 4, 2026byJJulius Marminge
View on GitHubTwo-way sync enabledPR last imported 4d ago

externalLauncher, providerMaintenance, AntigravityInstallation, and ResourceMonitorBinary write #!/bin/sh stubs (or chmod 0o755 files) into a real temp dir and resolve them under a linux/darwin platform mock. On a Windows host the temp path carries a drive letter, so the posix ':' PATH split shatters it, and NTFS never reports the exec bits the linux branch checks. Skip those tests there; the win32-mocked siblings already cover the Windows branches with .cmd fixtures.

Part of the Windows test-suite stack rooted at #9564; the manual Windows lane comes from #9538.

Model: Claude Fable 5 in Claude Code.

πŸ€– Generated with Claude Code

Note

Skip POSIX executable fixture tests on Windows host

Macroscope summarized ebe89b2.


Note

Low Risk Test-only conditional skips; no runtime behavior changes. Coverage for skipped paths still runs on non-Windows hosts and via existing win32-mocked tests where noted.

Overview Makes the server test suite pass on Windows CI/dev machines by skipping cases that cannot run there, without changing production code or altering assertions on macOS/Linux.

Each affected suite adds a windowsHost guard (HostProcessPlatform.defaultValue() === "win32") and wraps selected tests with it.effect.skipIf(windowsHost) / it.live.skipIf(windowsHost). Those tests still create real temp dirs with #!/bin/sh stubs (or chmod 0o755) and resolve them under a linux/darwin platform mock; on Windows the temp path’s drive letter breaks POSIX PATH splitting on :, and NTFS does not expose the exec bits the Linux branch checks.

externalLauncher.test.ts skips the bulk of macOS/Linux/WSL file-manager and xdg-mime scenarios; win32-mocked tests (e.g. .CMD fixtures, Explorer/PowerShell reveal) stay enabled. providerMaintenance.test.ts skips four PATH-walk capability tests that use shell stubs. AntigravityInstallation.test.ts skips one explicit-path resolve test. ResourceMonitorBinary.test.ts skips two override tests that depend on POSIX exec bits under a Linux mock.

Reviewed by Cursor Bugbot for commit ebe89b26382b49528fe5db4e4843d3c2d4b6e5df. Bugbot is set up for automated code reviews on this repo. Configure here.

Synced from GitHub

Thread transfer impact

βœ… Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wireβ€”13.6 KiBβ€”15.1 KiBβœ…
CodexThread snapshot wireβ€”7.0 KiBβ€”7.3 KiBβœ…
CodexLive turn WebSocket wireβ€”6.6 KiBβ€”7.8 KiBβœ…
CodexLive turn WebSocket decodedβ€”57.1 KiBβ€”66.4 KiBβœ…
CodexLive turn messagesβ€”10β€”21βœ…
ClaudeTotal thread wireβ€”13.6 KiBβ€”15.1 KiBβœ…
ClaudeThread snapshot wireβ€”7.0 KiBβ€”7.3 KiBβœ…
ClaudeLive turn WebSocket wireβ€”6.6 KiBβ€”7.8 KiBβœ…
ClaudeLive turn WebSocket decodedβ€”57.9 KiBβ€”66.4 KiBβœ…
ClaudeLive turn messagesβ€”10β€”21βœ…

Baseline: unavailable Β· PR result: ebe89b2 Β· Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Synced from GitHub

Approvability

Verdict: Approved at e359f23

Macroscope's review found this PR approvable β€” This is a localized test-only compatibility change across four test files, skipping POSIX fixture tests on Windows without modifying production code or customer-facing behavior. It adds no product-default changes or static-analysis suppressions.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

No code changes detected at ebe89b2. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Added 1 commit

  • test(server): skip posix executable fixtures on a Windows hostebe89b2