Sign up
View stargazersSign up

feat(web): mod+alt+e maximizes the right panel, even when it's closed#33801

open3
main
GitHub fork: feat/default-maximize-right-panel-shortcut
opened2d agoby00xtlt
6 files changed
View on GitHubTwo-way sync enabledPR last imported 1d ago

Problem

"Maximize panel" (rightPanel.toggleMaximized) has no default shortcut, unlike mod+alt+b (right panel) and mod+shift+b (thread panel). When bound, it does nothing while the right panel is closed.

Change

  • Adds mod+alt+e → rightPanel.toggleMaximized to the default keybindings, next to mod+alt+b. Existing users get it through the default backfill, unless that key or command is already bound.
  • With the panel closed, the command opens it straight into maximized (chat view and Pull requests page). The chat view reuses the store's existing requestMaximize.
  • The maximize button's tooltip shows the shortcut, like the neighbouring panel toggles.

Scope and approval

No prior maintainer approval. One default keybinding, making the existing command work from a closed panel, and showing it in the existing tooltip: no new command, setting or UI. mod+alt+e is free in the defaults and isn't a macOS system shortcut. AltGr+E (€) is already ignored by the resolver.

Verification

  • New test in apps/web/src/keybindings.test.ts: mod+alt+e resolves to rightPanel.toggleMaximized on macOS (Option+E dead key) and Linux. Fails without the change, passes with it.
  • vp run check:changed: format, lint, knip, typecheck, tests and React compiler pass.
  • Manual, web dev build on macOS, chat view, with a Files tab open in the panel: Cmd+Option+B opens the panel, tooltip "Maximize panel (⌥⌘E)" → Cmd+Option+E maximizes, tooltip "Restore panel size (⌥⌘E)" → Cmd+Option+E restores → Cmd+Option+B closes → Cmd+Option+E opens it maximized → Cmd+Option+E restores. The panel state was checked after each step. The recording overlays the keys pressed and is trimmed between steps.

https://github.com/user-attachments/assets/ccc99578-4053-46a9-9f14-cc0408f7fee5

  • Not checked by hand: the Pull requests page path.

Model: Claude Opus 5.5 (Claude Code)

Checks

23 successful · 9 skipped · 1 neutral
All checks passed
93311e0

Added 3 commits

  • feat(web): maximize opens a closed right panel straight into maximized1171bab
  • feat(web): bind mod+alt+e to maximize the right panel by default1d9c0ed
  • feat(web): the maximize panel tooltip shows its shortcut93311e0
MmacroscopeappBot2d ago
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This adds mod+alt+e as a default shortcut and lets it open a closed right panel directly into maximized mode. The new default keyboard interaction requires human review, although the visible changes are limited to panel behavior and shortcut tooltips.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot2d ago
Synced from GitHub

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds a default shortcut for maximizing the right panel, shows the shortcut in panel controls, and updates chat and pull request actions to open an available closed panel when maximizing.

Changes: Right-panel maximize shortcut and behavior

Layer / File(s)Summary
Shortcut and control labels
packages/shared/src/keybindings.ts, apps/web/src/keybindings.test.ts, apps/web/src/components/ChatView.tsx, apps/web/src/components/chat/PanelLayoutControls.tsx, apps/web/src/components/pullRequest/PullRequestsPage.tsx		Adds and tests the mod+alt+e shortcut. Chat and pull request panel controls display the shortcut label when one is available.
Closed-panel maximize behavior
apps/web/src/components/chat/useRightPanelActions.ts, apps/web/src/components/pullRequest/PullRequestsPage.tsx		When a thread or pull request surface is available, maximizing a closed panel opens it. The chat action focuses the panel workspace and requests maximization; the pull request action opens and maximizes the panel.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: juliusmarminge, bil0000

Merge Risk: External image Minimal · up to 93311

The shortcut and panel behavior are ready to merge after normal checks.

Pre-merge checks: Passed 4

Check nameStatusExplanation
Title checkPassedThe title clearly identifies the new shortcut and the behavior when the right panel is closed.
Description checkPassedThe description covers the problem, changes, scope rationale, and verification. It reports focused tests and manual chat-view checks, and states that the Pull requests page path was not checked by han…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, changes, scope rationale, and verification. It reports focused tests and manual chat-view checks, and states that the Pull requests page path was not checked by hand.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
External image Recent review info

External image Run configuration

External image Commits

Reviewing files that changed from the base of the PR and between bcee0f5d2872ba193c66ed9ba979bbe424f89ff9 and 93311e0972b7cfc16a650103e1c723097f73aeb1.

External image Files selected for processing: 6

  • apps/web/src/components/ChatView.tsx
  • apps/web/src/components/chat/PanelLayoutControls.tsx
  • apps/web/src/components/chat/useRightPanelActions.ts
  • apps/web/src/components/pullRequest/PullRequestsPage.tsx
  • apps/web/src/keybindings.test.ts
  • packages/shared/src/keybindings.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.