fix(web): clicked workspace areas no longer show the focus ring after a stray key #33525 · pingdotgg/t3code

Before (`main` 2da1b7431d)	After
Ring around the clicked conversation area	No ring around the clicked conversation area
`outline: solid 2px`	`outline: none`

MmacroscopeappBotapproved these changes17h ago

Approvability

Verdict: Approved at 2c706af

Macroscope's review found this PR approvable — Workspace focus rings and window-return focus now use an explicit keyboard-focus marker, avoiding stray rings after pointer interaction. The change is limited to transient UI focus behavior and preserves existing input and popup protections.

^{You can add or adjust custom eligibility rules. Learn more.}

CcoderabbitaiBot17h ago

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Workspace focus handling now marks areas reached by keyboard navigation. The focus-ring styling and composer-refocus eligibility use this marker instead of relying on :focus-visible for workspace areas.

Changes: Workspace focus behavior

Layer / File(s)	Summary
Track keyboard focus on workspace areas `apps/web/src/lib/workspaceFocus.ts`, `apps/web/src/lib/workspaceFocus.browser.test.ts`	The controller sets and clears a keyboard-focus marker during focus changes and pointer interaction. Browser tests cover focus-ring behavior for clicked and keyboard-reached areas.
Use the marker for focus display and refocus `apps/web/src/index.css`, `apps/web/src/components/ChatView.logic.ts`, `apps/web/src/components/ChatView.logic.browser.test.ts`	Workspace-area focus styling and composer-refocus eligibility use the marker. A browser test checks window-return eligibility around F6 navigation.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

pingdotgg/t3code#28191: Implements the same clicked-workspace focus-ring fix and shares marker, CSS, composer-refocus, and regression-test changes.
pingdotgg/t3code#19669: Establishes the workspace-area focus controller and F6 navigation used by this change.
pingdotgg/t3code#26457: Updates window-return eligibility for keyboard-focused timeline messages, a behavior also changed here for workspace areas.

Suggested reviewers: yash-singh1, nibarahmed, macroscopeapp

Merge Risk: External image Minimal · up to 2c706

The focus-ring change has no identified issue that needs resolution before merge; proceed with normal checks.

Pre-merge checks: ^Passed 4

Check name	Status	Explanation
Title check	Passed	The title clearly describes the main change: clicked workspace areas no longer show a focus ring after a stray key.
Description check	Passed	The description covers the problem, change, linked issue, scope, verification results, screenshots, and known limitations. It follows the required sections and provides specific test details.
Linked Issues check	Passed	Issue [`#28166`] requires no ring after non-keyboard focus and a ring for F6 navigation. `workspaceFocus.ts` marks an area only on keyboard-visible focus arrival and clears the mark on pointer input or …
Out of Scope Changes check	Passed	All changes support [`#28166`]. The controller and CSS implement the focus-ring behavior. The browser tests verify the behavior, and the `ChatView.logic.ts` change keeps window-return focus handling con…

Full details: Linked Issues check

Explanation

Issue [#28166] requires no ring after non-keyboard focus and a ring for F6 navigation. workspaceFocus.ts marks an area only on keyboard-visible focus arrival and clears the mark on pointer input or other focus. index.css draws the ring only for the marked focused area. Browser tests cover a click followed by bare Shift, simulated refocus, F6 navigation, and pointer clearing. ChatView.logic.ts uses the same mark for window-return composer refocus.

Full details: Out of Scope Changes check

Explanation

All changes support [#28166]. The controller and CSS implement the focus-ring behavior. The browser tests verify the behavior, and the ChatView.logic.ts change keeps window-return focus handling consistent with the new keyboard-focus marker. No unrelated changes appear in the pull request diff.

Finishing Touches

Generate docstrings

Commit to this branch
Create a new PR

Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

External image Recent review info

External image Run configuration

Source mode: Auto
Repository: pingdotgg/t3code
Branch: fix/workspace-area-focus-ring
File: .coderabbit.config.ts
Commit: 2c706af
Layers: Repository TS config
Review profile: CHILL
Plan: Team
Run ID: `78c2aa95-74b3-4558-84ef-fc2588822ad6`

External image Commits

Reviewing files that changed from the base of the PR and between 2da1b7431d07abeefe69c3cda4ae38d7f7c3df30 and 2c706af82964983a61defe1dbbce66499524b70e.

External image Files selected for processing: 5

`apps/web/src/components/ChatView.logic.browser.test.ts`
`apps/web/src/components/ChatView.logic.ts`
`apps/web/src/index.css`
`apps/web/src/lib/workspaceFocus.browser.test.ts`
`apps/web/src/lib/workspaceFocus.ts`

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Kkupiainenapproved these changes17h ago

fixes annoying "feature" that happens a lot to me.

fix(web): clicked workspace areas no longer show the focus ring after a stray key#33525

Problem

Change

Scope and approval

Verification

Checks

Approvability