fix(server): failed self-update names the step, HTTP status, and host#33270

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Self-update preparation failures now report the failed step and classify the cause. HTTP failures include the status and host, with retry guidance for timeouts and selected status codes. A test verifies reporting for a checksum request that returns HTTP 504.

Changes: Self-update error reporting

Layer / File(s)	Summary
Classify and report preparation failures apps/server/src/cloud/selfUpdate.ts, apps/server/src/cloud/selfUpdate.test.ts	Preparation failures now identify the failed step and provide cause-specific details, except for existing blocked-preflight and unpublished-mirror handling. The test harness can return a configured checksum status, and a test checks the 504 message and confirms that no update steps were recorded.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

• pingdotgg/t3code#29911: Both PRs change preparation-failure mapping in selfUpdate.ts, including the mirror-specific failure case.
• pingdotgg/t3code#33239: Both PRs add step, status, and host details for preparation failures and test a 504 download failure.

Suggested reviewers: t3dotgg, macroscopeapp

The update message’s retry guidance works on the inspected path, but the new test does not protect it from regression. This is a bounded follow-up rather than a merge blocker.

Check name	Status	Explanation
Title check	Passed	The title names the change: a failed self-update now reports the failed step, HTTP status, and host. The raw summary and objectives confirm the selfUpdate.ts reason-string change. The title follows co…
Description check	Passed	The description follows the template well. It has Problem, Change, Scope and approval, and Verification sections. It links issue #33233 and gives concrete test results, a before/after runtime transcri…
Linked Issues check	Passed	Issue #33233 is the only directly linked active issue. Its coding requirements are: (1) name the failed install step, (2) for HTTP errors, show the status and host, (3) indicate when a transient failu…
Out of Scope Changes check	Passed	The whole-PR diff (merge base c73b38b to head 743073ce) touches two files. apps/server/src/cloud/selfUpdate.ts adds the prepareFailureReason helper, its imports (Cause, HttpClientError), and the singl…

Full details: Title check

Explanation

The title names the change: a failed self-update now reports the failed step, HTTP status, and host. The raw summary and objectives confirm the selfUpdate.ts reason-string change. The title follows conventional commit format and is specific, so it passes.

Full details: Description check

Explanation

The description follows the template well. It has Problem, Change, Scope and approval, and Verification sections. It links issue #33233 and gives concrete test results, a before/after runtime transcript, and a note on what was not checked. Two gaps remain. The Scope and approval section gives only a bare issue link and does not state maintainer approval or the triage status, which the template asks for. The template also asks for a model and harness note when an agent was used. The description says it is AI-assisted, but it does not name the model or harness.

Resolution

Optional: in the Scope and approval section, state whether the linked issue #33233 has been triaged or approved by a maintainer, and add the approval comment link if one exists. At the end of the description, name the model and harness that did the work, as the template requests.

Full details: Linked Issues check

Explanation

Issue #33233 is the only directly linked active issue. Its coding requirements are: (1) name the failed install step, (2) for HTTP errors, show the status and host, (3) indicate when a transient failure is retryable. The reviewed head (743073ce) meets each requirement in apps/server/src/cloud/selfUpdate.ts. The new helper prepareFailureReason replaces the generic failWith(Could not prepare t3@X.) in the catch-all mapError after ensurePinnedRuntimeInstalled. It (a) always appends while ${error.step}, which names the step (for example, 'downloading the t3 release checksums'); (b) for HttpClientError, adds the host from URL.parse(cause.request.url).host, so no path, query or credentials appear, and adds HTTP ${status} for StatusCodeError; (c) adds 'Try again.' for status >= 500, 408, 429, for TransportError or DecodeError ('the connection to <host> failed'), and for Cause.TimeoutError (the stall timeout produces the step suffix '(timed out)'). A 504 on SHA256SUMS therefore yields '…while downloading the t3 release checksums: <host> answered HTTP 504. Try again.' The issue's reproduction scope (non-404 failure on SHA256SUMS) is covered. The 404 case on a non-mirror install also reaches the new reason and reports the status without retry advice. The mirror-unpublished and preflight-blocked branches are unchanged. A new test in selfUpdate.test.ts (checksumsStatus: 504) asserts that the reason contains 'checksums', '504' and 'github.com', and that no operations ran. The retry-safety claim relies on existing cleanup code in pinnedRuntime.ts (Effect.ensuring removes staging; an incomplete version directory is removed on the next attempt), which I confirmed by reading that file. Limits: the PR's runtime transcript names commit bac3a227cd, not the reviewed head 743073ce. I did not re-run the transcript or the test suite. The empty-body (204) transcript line ('…from <host>.') was not traced to a specific code path. These limits do not affect the code-level verdict, since the requirements do not cover that edge case.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff (merge base c73b38b to head 743073ce) touches two files. apps/server/src/cloud/selfUpdate.ts adds the prepareFailureReason helper, its imports (Cause, HttpClientError), and the single replaced failWith call for the prepare-failure reason. apps/server/src/cloud/selfUpdate.test.ts adds an optional checksumsStatus harness option, passes it to releaseHttpClient, and adds one test for the 504 case. Every change either builds the new reason string or supports the test that verifies it. No unrelated behavior, contract types, or other modules change. The public contract is unchanged, as the PR states, because only the reason string differs.

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR