Sign up
View stargazersSign up

fix(mobile): keep side chats readable over the conversation#32240

merged1
main
GitHub fork: fix/mobile-side-chat-readability
opened3d agobyAAlex
1 files changed
View on GitHubTwo-way sync enabledPR last imported 1d ago

Problem

The Side chats row is transparent above the composer, so conversation text scrolls beneath its label and chips. The overlapping text becomes illegible with larger fonts.

Change

Give the row an opaque background matching the conversation canvas on Android and the screen on iOS, with space above and below its controls. Side-chat navigation, badges, and horizontal scrolling keep their existing behavior.

Scope and approval

Alex reported the overlap and requested a separate fix. This is a small correction of an existing mobile overlay defect. Web, desktop, providers, server contracts, and connection behavior are unaffected.

Verification

  • vp run check:changed e455200077ce60806a01c8f28435b58860dcfc74 passed on a temporary verification branch integrating all four independent fixes, covering formatting, lint, both knip checks, affected typechecks, and compiler checks.
  • Verified the Android native client with demo fixtures, 18pt app text, and extra-large system text. Matched captures show an opaque Side chats row while conversation text scrolls behind it; opening the side chat and returning also worked. iOS runtime verification remains outstanding.

Before and after

Android native client, 18pt app text and extra-large system text.

BeforeAfter
Before: conversation text overlaps the Side chats rowAfter: opaque Side chats row stays readable

Model: GPT-6.1 Sol (xhigh reasoning) | Harness: Codex in T3 Code

Checks

24 successful · 14 skipped
All checks passed
06ac36e

Added 1 commit

  • fix(mobile): keep side chats readable above the conversation06ac36e
MmacroscopeappBot3d ago
Synced from GitHub

Approvability

Verdict: Approved at 06ac36e

Macroscope's review found this PR approvable — The mobile side-chat row gains padding and a background matching the conversation surface to keep it readable. Changes are limited to presentation, with navigation and data behavior unchanged.

You can add or adjust custom eligibility rules. Learn more.

CcoderabbitaiBot3d ago
Synced from GitHub

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ThreadSideChatsRow now applies a platform-specific background and vertical padding.

Changes: Thread row styling

Layer / File(s)Summary
Platform-specific row styling
apps/mobile/src/features/threads/ThreadSideChatsRow.tsx		The row uses bg-thread-canvas on Android and bg-screen on other platforms. Its container uses vertical padding instead of bottom padding.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#26901: Adds ThreadSideChatsRow, which this change updates with platform-specific background and spacing.

Suggested labels: bugfix

Suggested reviewers: t3dotgg

Merge Risk: External image Minimal · up to 06ac3

The row gains a matching background and padding. No concrete merge-blocking issue was found; iOS runtime verification remains outstanding.

Pre-merge checks: Passed 4

Check nameStatusExplanation
Title checkPassedThe title clearly describes the mobile side-chat readability fix.
Description checkPassedThe description covers the problem, change, scope, verification, and before-and-after screenshots. It notes that iOS runtime verification remains outstanding.
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
External image Recent review info

External image Run configuration

External image Commits

Reviewing files that changed from the base of the PR and between 25bf84ab07f53f141c20239c63e383823a9d5ea0 and 06ac36eecd78f789b3470a32b12a2ac87196505f.

External image Files selected for processing: 1

  • apps/mobile/src/features/threads/ThreadSideChatsRow.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.