New threads on a reused non-default branch inherit its latest merged or closed PR. Clearing the automatic association alone also leaves the toolbar and command palette showing the same historical PR through raw Git status.
Filter automatic discovery and saved-reference restoration when the PR completed before the thread was created. Include creation time in the narrow discovery snapshot, and share the open-only Git-status fallback across the toolbar and thread status indicators. Older threads and explicit PR links retain their historical context. Hosts without completion timestamps retain their existing association behavior.
Fixes #31896. This is a focused fix for the unresolved badge bug acknowledged in the maintainer follow-up.
Verification:
staging; both inherited the historical PR before the fix.vp run check:changed passed: formatting, lint, both knip checks, GraphQL validation, typechecking for four affected packages, 77 tests, and React compiler checks for both changed components.Written with GPT-6.1 Sol through the Codex harness in T3 Code.
Added 1 commit
Verdict: Approved at 1f472f0
Macroscope's review found this PR approvable — Prevents new threads from inheriting PRs that closed before the thread existed and limits unlinked branch badges to open PRs. The change is confined to thread associations and presentation, with existing synchronization safeguards retained.
You can add or adjust custom eligibility rules. Learn more.
The server now uses thread creation time when associating merged or closed pull requests. The web branch selector displays a Git-status pull request only when it is open.
Changes: Pull request handling
| Layer / File(s) | Summary |
|---|---|
Server association and snapshot apps/server/src/orchestration-v2/ProjectionStore.ts, apps/server/src/orchestration-v2/ThreadPullRequestService.ts, apps/server/src/orchestration-v2/ThreadPullRequestService.test.ts | Pull request snapshots now include thread creation time. The service does not associate a merged or closed pull request with a thread when its terminal timestamp predates the thread. Tests cover open, merged, and closed pull requests, saved associations, and the projected timestamp. |
Branch pull request display apps/web/src/components/ThreadStatusIndicators.tsx, apps/web/src/components/BranchToolbarBranchSelector.tsx, apps/web/src/components/ThreadStatusIndicators.test.ts | The branch selector uses the shared pull request resolver. The resolver accepts a Git-status pull request only when its state is open, and tests cover open, merged, and closed states. |
Estimated code review effort: 2 (Simple) | ~15 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related issues
Possibly related PRs
Suggested labels: bugfix
Suggested reviewers: juliusmarminge
1f472The reviewed changes have no established merge-blocking issue. The optional timestamp explanation need not delay merging.
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly describes the main change: preventing new threads from inheriting historical branch PRs. |
| Description check | Passed | The description covers the problem, change, scope, and verification. It omits the template headings and before-and-after screenshots for the UI changes. |
| Linked Issues check | Passed | [#31896] Automatic discovery and saved-reference restoration reject PRs completed before thread creation. Open PRs, older threads, explicit links, and hosts without completion timestamps retain their … |
| Out of Scope Changes check | Passed | [#31896] The projection timestamp, association filter, shared display fallback, and tests support the linked issue. No unrelated changes are identified. |
Explanation
[#31896] Automatic discovery and saved-reference restoration reject PRs completed before thread creation. Open PRs, older threads, explicit links, and hosts without completion timestamps retain their behavior. The toolbar and status indicators use an open-only Git-status fallback. Regression tests cover PR states, thread timing, saved references, explicit links, and the fallback.
apps/server/src/orchestration-v2/ThreadPullRequestService.ts: 1
53-64: External image Trivial · Maintainability & Code Quality · Low valueExternal image Unverified finding Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Handle unparseable terminal timestamps explicitly.
closedAtandmergedAtareSchema.StringinPullRequestSummary. They are notIsoDateTime. If a host returns a non-ISO string,Date.parsereturnsNaN. The comparisonNaN < nis false. The function then returnsfalse, so the PR is associated as before. This behavior is a safe fallback and matches the stated "no timestamp" behavior. Add a short comment to state that this fallback is intentional.
a25b5ffa-1e37-4063-aa68-dfef557ed0d7Reviewing files that changed from the base of the PR and between 9899b4724d14ad1911a228cfebeca35aa6cad8b1 and 1f472f0f17ce2e0ec0dddfdb3d1ff044d38e726f.
apps/server/src/orchestration-v2/ProjectionStore.tsapps/server/src/orchestration-v2/ThreadPullRequestService.test.tsapps/server/src/orchestration-v2/ThreadPullRequestService.tsapps/web/src/components/BranchToolbarBranchSelector.tsxapps/web/src/components/ThreadStatusIndicators.test.tsapps/web/src/components/ThreadStatusIndicators.tsxIncluded review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
Reviewed the optional timestamp note: missing or unparseable completion timestamps intentionally preserve existing associations, since they do not establish that a PR predates the thread. The PR description already documents this compatibility fallback. No behavior change is needed.