fix(web): restore effort picker keyboard typeahead#31400

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

The effort picker now supports type-ahead navigation by effort-level label. Browser tests cover focus behavior, selection, search, dismissal, and locked effort controls.

Changes: Effort picker type-ahead

Layer / File(s)	Summary
Add and validate effort-level type-ahead apps/web/src/components/chat/ComposerModelEffort.tsx, apps/web/src/components/chat/ComposerModelEffort.browser.test.tsx	Effort rows expose their labels for matching. Printable single-character keys move focus to matching enabled rows, with case-insensitive matching and wraparound. Browser tests cover keyboard focus, selection, search, dismissal, and locked controls.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested labels: bugfix, size:M

Suggested reviewers: t3dotgg, macroscopeapp

Typeahead restores keyboard focus navigation without changing selection. No material merge risk was identified.

Check name	Status	Explanation
Title check	Passed	The title "fix(web): restore effort picker keyboard typeahead" names the main change: first-letter typeahead in the effort picker, restored after a regression. It follows the conventional commit forma…
Linked Issues check	Passed	Issue #31371 is the only direct, active link. Its coding requirements are: (1) a printable letter moves focus to the next enabled effort level whose label starts with that letter; (2) matching uses th…
Out of Scope Changes check	Passed	The whole-PR diff against the merge base contains changes in ComposerModelEffort.tsx and ComposerModelEffort.browser.test.tsx. Both serve issue #31371. The source change is limited to: - The `data-ef…
Description check	Passed	The pull request description includes all required sections. It clearly explains the problem, change, scope and approval basis, focused verification results, limitations, screenshots, recordings, and …

Full details: Title check

Explanation

The title "fix(web): restore effort picker keyboard typeahead" names the main change: first-letter typeahead in the effort picker, restored after a regression. It follows the conventional commit format. The raw summary and objectives both describe this typeahead addition to the effort row handler, so the title matches the changeset.

Full details: Linked Issues check

Explanation

Issue #31371 is the only direct, active link. Its coding requirements are: (1) a printable letter moves focus to the next enabled effort level whose label starts with that letter; (2) matching uses the level label, not the full row text; (3) repeated letters cycle through matching levels and wrap; (4) Enter applies the focused level; (5) a browser test covers typing l to focus Low.

Head evidence in apps/web/src/components/chat/ComposerModelEffort.tsx:

• ColumnRow now sets data-effort-level to props.label. Typeahead matches against row.dataset.effortLevel, so the match uses the label, not textContent.
• moveBetweenRows handles single printable keys. It searches the enabled [data-effort-row] rows that come after the focused row, then wraps to the start. It uses a case-insensitive startsWith match, so repeated letters cycle.
• Arrow handling is unchanged.
• Enter selection uses the existing button behavior and was not changed.

The PR description reports browser tests for label-ID mismatch, uppercase matching, repeated-letter wrapping, disabled levels, and Enter selection. Those results are author-reported. I did not re-run them. The test file change is in the diff summary (+131 lines in ComposerModelEffort.browser.test.tsx).

No unmet coding requirement is visible in the reviewed code.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against the merge base contains changes in ComposerModelEffort.tsx and ComposerModelEffort.browser.test.tsx. Both serve issue #31371.

The source change is limited to:

• The data-effort-level value (from true to the label).
• The printable-key branch in moveBetweenRows, which has guards for whitespace, Ctrl, Alt, Meta, and IME composition.

The new guards and the typeahead search are part of the requested behavior, not extra features. The data-effort-level value change is safe for its known consumer. focusEffort in ProviderModelPicker.tsx selects [data-effort-level][aria-checked="true"] and [data-effort-level]. Neither selector compares the attribute value. I did not search the whole repository for other data-effort-level readers, so that check is limited to this file.

No unrelated behavior change is visible.

Full details: Description check

Explanation

The pull request description includes all required sections. It clearly explains the problem, change, scope and approval basis, focused verification results, limitations, screenshots, recordings, and the agent and harness used.

Generate unit tests (beta)

• Create a new PR