revert(web): working threads stay in the Working shelf when their environment disconnects#31269

merged1

main

t3/revert-working-shelf-disconnect-gate

View on GitHubTwo-way sync enabledPR last imported 4d ago

Reverts #26195.

A thread that says it is working belongs in the Working shelf. #26195 gated the shelf on the environment being connected and its shell fully synced, so after a remote box dropped (an OOM on cups here) its still-running threads moved back into the main list while their rows kept saying "Working 39m". The sidebar ended up contradicting itself.

This restores the previous rule: the shelf follows the thread's working state only.

Model: Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

Checks

1 failing · 23 successful · 15 skipped

Some checks failed

Failing1

CodeRabbitGitHub
Cancelled

Added 1 commit4d ago

revert(web): working threads stay in the Working shelf when their environment disconnects15146f4

MmacroscopeappBotapproved these changes4d ago

MmacroscopeappBot4d ago

Approvability

Verdict: Approved at 15146f4

Macroscope's review found this PR approvable — Working threads now stay in the Working shelf when their environment disconnects. This is a limited display-grouping change; existing settings and connection-based dragging safeguards remain unchanged.

Notes:

All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}