fix(web): add installable icons for Firefox on Android#30420

Approvability

Verdict: Approved at 5f2cae6

Macroscope's review found this PR approvable — Adds properly sized web app icons so Firefox on Android can install the existing standalone app experience. The changes are confined to branding assets and their generation/copy mappings, with reported head-specific installation verification.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

External image Recent review info

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: b183048
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 335febca-acb1-493e-9155-ab80bfd49243

External image Commits

Reviewing files that changed from the base of the PR and between b183048a823815175fd6991691f2acec456ea176 and 5f2cae603c3c0198e92f7a1c06139b20dc262331.

External image Files ignored due to path filters: 8

• apps/web/public/icon-192x192.png is excluded by !**/*.png
• apps/web/public/icon-512x512.png is excluded by !**/*.png
• assets/dev/blueprint-web-icon-192x192.png is excluded by !**/*.png
• assets/dev/blueprint-web-icon-512x512.png is excluded by !**/*.png
• assets/nightly/nightly-web-icon-192x192.png is excluded by !**/*.png
• assets/nightly/nightly-web-icon-512x512.png is excluded by !**/*.png
• assets/prod/t3-black-web-icon-192x192.png is excluded by !**/*.png
• assets/prod/t3-black-web-icon-512x512.png is excluded by !**/*.png

External image Files selected for processing: 5

• apps/web/public/manifest.webmanifest
• assets/README.md
• scripts/apply-web-brand-assets.test.ts
• scripts/export-brand-icons.ts
• scripts/lib/brand-assets.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Completed the two missing verification steps at head 5f2cae603c3c0198e92f7a1c06139b20dc262331. No source files or commits changed.

Actual exporter on shiv

Ran the exact-head scripts/export-brand-icons.ts on physical shiv, macOS 27.0.1, Node 26.12.1, Icon Composer 27.1 build 129, design generation 26. The source came from a pinned git archive; existing checkout dependencies were reused, including Effect and platform-node 4.1.2. The source and output lived in an isolated temporary directory, not the installed checkout.

The initial check is not a pass against the committed old assets. Comparing both runs proved the same 25 paths, committed hashes and regenerated hashes differ on the parent and head. None of the eight new PNGs drift. Unrelated assets remain unchanged in this PR.

Before running the normal head export, all eight new files were removed from the temporary snapshot. The actual exporter recreated all six brand assets and both development public copies. Every recreated PNG matches the committed bytes and declared dimensions; the primary session independently checked the returned files and hashes.

Comparison of the committed PNGs with the actual exporter output. The image includes dimensions and matching hashes for all six brand assets and both public copies.

Built and served production and nightly on corex

Built both variants from the unchanged head with the repository web build, then applied the existing brand-copy entry point to each output directory. Both builds and brand-copy commands exited 0.

Build output reported ✓ built in 17.72s for production and ✓ built in 15.66s for nightly. Served the built directories with Vite preview on corex ports 7151 and 7152. In real Browser panel tabs, fetched the manifest linked by each page, fetched both new icons, decoded them and computed their SHA-256 hashes. All four hashes equal their committed brand source files listed above. Visual inspection confirms black production artwork and purple nightly artwork.

Both manifests declare purpose: "any" for both new icons.

Production served PNG	Nightly served PNG

The Firefox Android installation proof remains embedded in the PR body at this same head. Not shown: installation on physical hardware or a deployed Vercel production/nightly build. These two variant checks used locally built output on corex.

[GPT-6.1 Sol][Codex] on behalf of shivam.

The previously pending Native fingerprint diff run completed successfully at the unchanged PR head. Verified directly through the check-run API and the job output:

Both fingerprint generation steps, comparison, and artifact upload succeeded. CHANGED_PLATFORMS is empty. The Git exit 128 warning occurs in the later Post Checkout cleanup for a vendored submodule; the fingerprint steps and overall job succeeded.

The live ready check also confirms all required checks pass, no unresolved review threads, an open non-draft PR, no conflicts, and auto-merge disabled. Head 5f2cae603c3c0198e92f7a1c06139b20dc262331, base b183048a823815175fd6991691f2acec456ea176. Exporter and served-variant evidence still covers this head. No code changes were needed.

Verified on Android emulator (API 35) against a real dev server

Verified unchanged head 5f2cae603c3c0198e92f7a1c06139b20dc262331 with Firefox 159.0.1 on the t3 x86_64 emulator. Both comparisons used real vp run dev servers with isolated state and temporary HTTPS tunnels.

On github/main (a445272c78), Firefox offers "Add to Home screen". I added the shortcut and launched it from the launcher: the address bar and tab controls remain visible. On the PR head, Firefox offers "Add app to Home screen". I installed it and launched it from the launcher: T3 renders standalone, without those browser controls. Dismissing the notification permission prompt leaves the paired app visible.

Before, launcher shortcut opens a browser tab:

Before: main shortcut opens with Firefox address bar and tabs

After, installed app opens standalone:

After: PR installation opens the paired app without browser controls

The matching Firefox installation menus:

Before: main offers Add to Home screen over HTTPS

After: PR offers Add app to Home screen over HTTPS

Animated copy of the installation and standalone-launch recording for GitHub. Idle and loading intervals were removed and playback accelerated; this is behavior evidence, not a timing measurement. Uploaded playback and seeking were checked.

Android installation and standalone launch recording

I also installed the matching native dev client from the shared cache, started Metro, and paired it with the isolated backend. Through the running server, I created a real project and two threads and completed two real Codex gpt-6.1-sol turns through the local proxy. In Firefox I opened the first reply, opened the thread list, switched to the second thread, and saw its completed reply. No mocks or replay data were used.

Real Codex reply rendered in Firefox on Android

Checks run here through Blacksmith: the focused icon-export/brand-copy tests passed (2 files, 3 tests), and vp run check:changed aee76a8b473694878e820ed642b4b4018991f378 passed format, lint, both knip checks, affected typechecks and focused tests. The explicit parent ref was necessary because the worker starts with shallow snapshot history. The PR status reported 29 successful checks, none pending or failing. No code changes were needed.

Not verified

• iOS cannot run on this Linux VM.
• Physical devices, deployed production/nightly installations, and the macOS Icon Composer exporter were not exercised here.
• Repeated cold-launch reliability remains unverified. The emulator had graphics freezes with SwiftShader and needed Lavapipe; some later launches stalled on a blank surface. I did not establish whether those stalls came from Firefox, the emulator renderer, or development loading. The successful standalone render above is from an actual launcher launch.