Muse threads offer Edit from here, but it always fails. The web shows the action unless the provider status says supportsConversationRollback: false. Muse's status never sets that flag, while the Muse adapter declares no rollback (canRollbackThread: false, providerCanRollbackConversation: false), so ensureRollback in CommandPolicy.ts refuses every Muse rollback.
Muse's status presentation now sets supportsConversationRollback: false, the same as Cursor's. The pending and probed Muse snapshots both build from that object, so the web stops offering Edit from here on Muse threads.
Fixes pingdotgg/t3code#30137
Triaged via the automated issue flow; GitCafe issue #30137.
vp test run packages/provider-muse/src/server/status.test.ts: the new test Muse status > does not offer conversation rollback, which the Muse adapter cannot perform fails on main (expected undefined to be false) and passes on this branch (4/4). vp test run packages/provider-muse: 96/96 pass.vp run check:changed: format, lint, knip, typecheck (10 packages), tests (2 files) pass.makePendingMuseProvider and checkMuseProviderStatus from packages/provider-muse, with a stub Muse SDK host for the ready path, before (main cefb544af3) and after (1de4009017):| 1 | ## before (main cefb544af3) |
| 2 | {"path":"pending","enabled":true,"status":"warning","supportsConversationRollback":"<absent>"} |
| 3 | {"path":"pending","enabled":false,"status":"disabled","supportsConversationRollback":"<absent>"} |
| 4 | {"path":"check disabled","status":"disabled","supportsConversationRollback":"<absent>"} |
| 5 | {"path":"check ready (stub SDK, node version probe)","status":"ready","supportsConversationRollback":"<absent>"} |
| 6 | ## after (1de4009017) |
| 7 | {"path":"pending","enabled":true,"status":"warning","supportsConversationRollback":false} |
| 8 | {"path":"pending","enabled":false,"status":"disabled","supportsConversationRollback":false} |
| 9 | {"path":"check disabled","status":"disabled","supportsConversationRollback":false} |
| 10 | {"path":"check ready (stub SDK, node version probe)","status":"ready","supportsConversationRollback":false} |
ChatView.tsx) is unchanged and already hides the action for Cursor's false.Model and harness: Claude Opus 5.5 (lead, red test, implementation, review B) and GPT-6.1 Sol (review A), run through Claude Code and Codex in T3 Code.
🤖 Generated with Claude Code
Added 2 commits
Verdict: Needs Human Approval
Macroscope's review found this PR requires human approval — Muse threads will stop offering Edit from here because provider status now explicitly disables conversation rollback. This is a narrow presentation correction, but removing the action by default requires human confirmation.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 5.0 KiB | 5.0 KiB | +35 B (+0.7%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.3 KiB | +35 B (+2.8%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 21.5 KiB | 21.6 KiB | +41 B (+0.2%) | 24.4 KiB | ✅ |
| Codex | Live turn messages | 1 | 2 | +1 (+100.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | 0 B (0.0%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | 0 B (0.0%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.9 KiB | 21.9 KiB | 0 B (0.0%) | 24.4 KiB | ✅ |
| Claude | Live turn messages | 2 | 2 | 0 (0.0%) | 8 | ✅ |
Baseline: cefb544 · PR result: 1de4009 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Muse provider status now reports that conversation rollback is unsupported. A test verifies this status for a pending Muse provider.
Changes: Muse rollback status
| Layer / File(s) | Summary |
|---|---|
Set and test rollback status packages/provider-muse/src/server/status.ts, packages/provider-muse/src/server/status.test.ts | MUSE_PRESENTATION sets supportsConversationRollback to false. A test checks that a pending Muse provider reports false. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix · Severity of issue fixed: Low
Suggested reviewers: maria-rcks, macroscopeapp
1de40Muse threads will no longer offer "Edit from here", which the server refuses for Muse. The remaining open point is whether the PR description should keep "Fixes #30137" given the issue's broader shared-rule request. This is a process question, not a behavior risk, and the change is low risk to merge.
Failed Failed checks: 1 warning
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check | Warning | The PR fixes the Muse mismatch by adding supportsConversationRollback: false to MUSE_PRESENTATION and testing the pending snapshot. Issue #30137 also requires the web action to match server rollba… | Derive supportsConversationRollback from the same adapter-capability predicate that ensureRollback uses. Remove the hand-set provider flags and add tests for the affected providers, including Muse, Grok, and Antigravity. |
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly and concisely describes the main change: Muse threads no longer offer the unsupported “Edit from here” action. |
| Description check | Passed | The description includes all required sections. It explains the problem, the implementation, scope and linked issue, focused verification results, and the unverified live-web limitation. |
| Out of Scope Changes check | Passed | The changed status presentation and the new Muse status test directly support issue #30137. The test verifies the pending snapshot that feeds provider status. No unrelated production behavior or unrel… |
Explanation
The changed status presentation and the new Muse status test directly support issue #30137. The test verifies the pending snapshot that feeds provider status. No unrelated production behavior or unrelated test change appears in the whole-PR diff.
Explanation
The PR fixes the Muse mismatch by adding supportsConversationRollback: false to MUSE_PRESENTATION and testing the pending snapshot. Issue #30137 also requires the web action to match server rollback acceptance through one rule. The PR changes no shared capability predicate, policy integration, or Grok and Antigravity status handling. The hand-set cross-provider flags therefore remain, so the linked issue is not fully implemented.
Resolution
Derive supportsConversationRollback from the same adapter-capability predicate that ensureRollback uses. Remove the hand-set provider flags and add tests for the affected providers, including Muse, Grok, and Antigravity.
packages/provider-muse/src/server/status.ts-25-25: 1
25-25: External image Major · Data Integrity & Integration · Heavy liftExternal image Unverified finding Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Align the linked issue scope before merge.
If this PR is intended to close
#30137, Line 25 fixes only the Muse mismatch. The linked issue requires rollback status to match server capability for every provider and calls for one shared rule. Grok and Antigravity remain outside this change. Narrow the issue scope or implement the shared capability-derived rule before claiming the issue is fixed.
de5d5e7b-4836-4cdc-a609-56d5688eac05Reviewing files that changed from the base of the PR and between cefb544af3c98224874419198c0359b652ca3c94 and 1de4009017f0bc0c8ab89d6122aef9acd277dec6.
packages/provider-muse/src/server/status.test.tspackages/provider-muse/src/server/status.tsIncluded review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.