Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
- Last reviewed commit: c191468550f3a84983ee2f30bd5d22a8652e1e26
- Latest commit, not reviewed: 5cf4c89de988d8d1e870288d451f3cfee2876b15
Use the following commands to manage reviews:
@coderabbitai resumeto resume automatic reviews.@coderabbitai reviewto trigger a single review.
Use the checkboxes below for quick actions:
- Resume reviews
- Trigger review
No actionable comments were generated in the recent review.
Walkthrough
-
The changes handle leading UTF-8 BOMs in workspace reads, Markdown processing, project-file parsing, and file editing. Regression tests cover BOM preservation, Markdown task edits and file-link copying, autolink parsing, and parsing BOM-prefixed JSON.
Changes: UTF-8 BOM handling
Layer / File(s) Summary Preserve BOM in workspace reads
apps/server/src/workspace/WorkspaceFileSystem.ts,apps/server/src/workspace/WorkspaceFileSystem.test.tsreadFilepreserves a leading UTF-8 BOM in decoded contents. The test checks that writing the contents to another file retains the BOM bytes.Adjust Markdown source offsets and autolink matching
apps/web/src/components/ChatMarkdown.tsx,apps/web/src/components/ChatMarkdown.browser.test.tsx,packages/shared/src/markdownPipeline.ts,packages/shared/src/markdownPipeline.test.tsTask-checkbox and file-link source offsets account for a leading BOM. Tests cover task edits with CRLF line endings and file-link copying with and without a BOM. Autolink suffix matching uses source text without a leading BOM; tests cover BOM-prefixed URLs. Parse BOM-prefixed project files
packages/shared/src/t3ProjectFile.ts,packages/shared/src/t3ProjectFile.test.tsparseT3ProjectFilestrips a leading BOM before decoding. The test checks parsing BOM-prefixed JSON.Preserve BOM during file editing
apps/web/src/components/files/FilePreviewPanel.tsx,apps/web/src/components/files/FilePreviewPanel.browser.test.tsxThe editor uses BOM-free draft contents and restores the BOM for project updates and saves. Comment content uses BOM-free editor contents. A browser test checks BOM retention after editing. Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Suggested reviewers:
dimamishchenko,t3dotgg,juliusmarminge
Merge Risk: External image Minimal · previous review c1914
-
The changes preserve BOMs during reading and editing and correct Markdown offsets. No actionable merge-blocking risk remains.
Pre-merge checks: Passed 4
-
Check name Status Explanation Title check Passed The title names the main change: reading a file keeps its UTF-8 BOM, so saving no longer strips it. The changeset matches this. WorkspaceFileSystem.readFile now decodes with ignoreBOM: true, and consu… Description check Passed The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the cause and a reproduction. The Change section lists… Linked Issues check Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: reading a file keeps its UTF-8 BOM, so saving no longer strips it. The changeset matches this. WorkspaceFileSystem.readFile now decodes with ignoreBOM: true, and consumers (parseT3ProjectFile, ChatMarkdown task checkboxes, FilePreviewPanel editor) were adjusted to handle the preserved BOM. The title uses the conventional commit format with a clear scope.
Full details: Description check
-
Explanation
The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the cause and a reproduction. The Change section lists the decode option and the three consumers that needed updates. The Scope section explains why the change is small and needs no prior issue. The Verification section includes focused test results with RED output, a passing check:changed run, and a runtime check on a dev build with before and after bytes. The template's Scope section asks for a linked issue or maintainer approval, or an explanation for a small obvious fix. The author gives that explanation. No issue link or approval comment is present, but the author justifies the exemption as an obvious data-integrity bug. The template also asks for a model and harness line, which the author includes. The description is mostly complete.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
External image Recent review info
-
External image Run configuration
-
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: main
- File: .coderabbit.config.ts
- Commit: 7b680b6
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
9fad6f88-4044-4e64-9e0c-401235b996d1
External image Commits
-
Reviewing files that changed from the base of the PR and between 5c9403d2a7e7d974fb3eff0bf9cb3d446c16b80a and c191468550f3a84983ee2f30bd5d22a8652e1e26.
External image Files selected for processing: 2
-
packages/shared/src/markdownPipeline.test.tspackages/shared/src/markdownPipeline.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
External image Recent review info
-
External image Run configuration
-
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: main
- File: .coderabbit.config.ts
- Commit: 7b680b6
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
9fad6f88-4044-4e64-9e0c-401235b996d1
External image Commits
-
Reviewing files that changed from the base of the PR and between 5c9403d2a7e7d974fb3eff0bf9cb3d446c16b80a and c191468550f3a84983ee2f30bd5d22a8652e1e26.
External image Files selected for processing: 2
-
packages/shared/src/markdownPipeline.test.tspackages/shared/src/markdownPipeline.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
-