fix(web): dialogs no longer flash away while scrolling on macOS#29325

open5
main
GitHub fork: fix/settings-scroll-flash
opened14d agobyIipanasenko
View on GitHubTwo-way sync enabledPR last imported 21h ago

Note

🤖 Written by Claude Opus 5.5 on behalf of Illia

Problem

On macOS displays above 60 Hz, scrolling inside Settings can make the open dialog vanish for one frame. The dialog, its dim and floating cards disappear, and the main window shows through at full brightness. Addresses #25552 and #23788.

Change

diff
1 @utility dialog-backdrop {
2 background: color-mix(in srgb, var(--background) 60%, transparent);
3- -webkit-backdrop-filter: blur(4px);
4- backdrop-filter: blur(4px);

This removes the full-window blur behind dialogs. The dim is unchanged, and dialog popups and the composer keep their glass.

The underlying defect looks like a Chromium compositor bug, so this avoids the trigger rather than fixing it. The blur was the narrowest thing we could remove that stopped the flash while keeping the app's look. The utility covers Settings, the command palette, alert dialogs and the Clerk modal.

Scope and approval

This is a one-line-sized fix for open bug reports #25552 and #23788. Neither issue has a triage label yet.

Verification

The flash could only be reproduced by hand with a trackpad on an affected setup: T3 Code Nightly 0.1.6 (Electron 44.10.0, Chromium 152) on macOS with an external 120 Hz display. It showed about 2 flashes per 30 seconds. Scripted wheel scrolling never reproduced it, so these results come from manual runs and are not a measured rate.

Glass removed via runtime overrideResult
All glassFlashes stopped
Everything outside #rootFlashes stopped, but dialogs turn transparent
Everything in #root, alwaysNo flashes in about 30 s, too short to be conclusive
Everything in #root, only while a dialog is openStill flashes, with the rule confirmed applied
Only the dialog backdrop blur (this PR)Flashes appeared to stop

In a dev build, computed backdrop-filter is none on dialog-backdrop and command-dialog-backdrop, and the command palette popup still has blur(12px) saturate(1.14). vp run check:changed passed.

Not checked:

  • The flash on a build of this branch. The manual runs applied the same change to the Nightly as a runtime override.
  • Alert dialogs and the Clerk modal, which were not opened. They use the same utility.
  • Other Chromium versions, including the Electron upgrade in #28123.

A workaround posted in #25552, --disable-features=VSyncAlignedPresentationForScrolling, keeps the blur and reports 0 flashes in about 126 scrolls against 11 in 158. It wasn't tested here, and it depends on a Chromium flag that may be removed.

The captures are synthetic demo data. "Before" is the same dev build with the removed rule added back at runtime. They show the visual change, not the one-frame flash.

Merge Danger

Door: two-way. Reverting restores the blur.

Blast Radius: visual. Content behind every dialog is sharper and a little easier to read, on web and desktop. Mobile is React Native and isn't affected.

Written by Claude Opus 5.5 in T3 Code. Reviewed by GPT-6.1-Sol.

Fixes pingdotgg/t3code#25552 Fixes pingdotgg/t3code#30759

Checks

22 successful · 16 skipped
All checks passed
f4eec8e

Added 1 commit

  • fix(web): dialogs no longer flash away while scrolling on macOS26678f7
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Removes dialog backdrop blur globally while retaining dimming and popup glass to avoid macOS scrolling flashes. A human should confirm the default visual tradeoff for all web and desktop users, including unaffected displays.

No code changes detected at f4eec8e. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Synced from GitHub

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

External image Run configuration

External image Commits

Reviewing files that changed from the base of the PR and between 78b03fa47f05e5ce970afa7049c5b8c958e15ce9 and f4eec8e36d5ae3df65589769d670abe1ccdc38d0.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The dialog-backdrop style no longer applies backdrop blur. Its light and dark background colors remain unchanged, and a comment documents the omission.

Changes: Dialog backdrop

Layer / File(s)Summary
Backdrop styling
apps/web/src/index.css
The dialog-backdrop style removes both backdrop-filter declarations. Its background colors remain unchanged. A comment documents the omission.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related issues

  • Issue 23788 in pingdotgg/t3code reports dialog flicker while scrolling on macOS. This change removes the shared dialog backdrop blur.
  • Issue 25552 in pingdotgg/t3code reports the Settings dialog and backdrop disappearing during macOS trackpad scrolling. This change removes the shared dialog backdrop blur.

Suggested reviewers: t3dotgg, flamboh

Merge Risk: External image Minimal · previous review 26678

The dialog backdrop retains its dimming behavior, and no actionable merge-blocking risk remains.

Pre-merge checks: Passed 4

Check nameStatusExplanation
Title checkPassedThe title is concise, uses the repository's conventional format, and clearly describes the main fix: preventing dialog flashes during macOS scrolling.
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Description checkPassedThe description covers the problem, change, scope, and verification. It explains that the fix is small and addresses open bug reports, reports test results and limitations, and includes before-and-aft…
Full details: Description check

Explanation

The description covers the problem, change, scope, and verification. It explains that the fix is small and addresses open bug reports, reports test results and limitations, and includes before-and-after UI evidence. It also identifies the model and harness used.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
External image Recent review info

External image Run configuration

External image Commits

Reviewing files that changed from the base of the PR and between 47f2c8d29e981c7723467efe137ee19e91df924e and 26678f72ca00434fda2e8fe964ead73806a5215e.

External image Files selected for processing: 1

  • apps/web/src/index.css

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Added 2 commits

  • Merge branch 'main' into fix/settings-scroll-flash644da6d
  • Merge remote-tracking branch 'origin/main' into fix/settings-scroll-flashed36d56
Synced from GitHub

Measurements from Linux supporting this change: beyond the macOS flash, the full-window dialog-backdrop blur makes scrolling in Settings and the command palette visibly laggy here.

Setup: T3 Code Desktop 0.1.9 (AppImage), Linux, AMD Radeon RX 6800 XT (RADV, Vulkan via ANGLE, GPU compositing enabled). Measured in an isolated second instance (separate T3CODE_HOME and profile), window 2560×1440, DPR 1. 4 s of CDP mouse-wheel scrolling over the dialog's scroller, two runs per condition, results matched within a few percent. Toggles were injected as CSS.

WhereConditionGPU main thread busy (of 4 s)Frames drawn / 4 sWheel ack median
Settings → Appearanceas shipped~3,970 ms (≈99 %)16831 ms
Settings → Appearancedialog blurs removed (backdrop + popup glass)~1,600 ms~26017 ms
Command paletteas shipped~3,460 ms (≈87 %)15228 ms
Command palettedialog blurs removed (backdrop + popup glass)~260 ms19017 ms
  • Glass opacity 100 % (current --glass-blur: 0px path) removes only the popup glass blur and made no measurable difference, so the cost is the fixed 4px full-window dialog-backdrop blur. #29525 would make that a usable workaround; this PR removes the cost for everyone.
  • Removing the scroll-fade masks (mask-image) on top only shaved a little more; the renderer main thread (React) stayed around 8 % busy in all conditions, so it is not the bottleneck.
  • Under software rendering (llvmpipe) the pattern is the same and much stronger (viz compositor ~88 % busy with the blur in Settings, ~23 % without).
  • Not covered: the user's real session is X11 with mixed 120 Hz / 60 Hz monitors, which likely makes it worse; the measurement display was a headless Weston/Xwayland session.

Related: #30759, #23788, #7766.

Measured and drafted by Claude Opus 5.5 (Claude Code, T3 Code triage session).

Added 2 commits

  • Merge branch 'main' into fix/settings-scroll-flash78b03fa
  • Merge branch 'main' into fix/settings-scroll-flashf4eec8e