fix(client): linked projects keep their shared title#29111

Approvability

Verdict: Approved at 8f14215

Macroscope's review found this PR approvable — Linked repository groups now prefer their shared project title, allowing shorter labels. The change affects presentation without changing group identity, membership or settings.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[GPT-6.1 Sol][Codex] on behalf of shivam.

Issue 26296 verification Head fcc964428dac7dedc033a8f684514817238319b1 Test base d890e5c40120769badcf18bff6d1ac983c8f40c7 Fetched main c65f8d552baca1b51e15b5fb4737f07e18cce177. Its 49 changed files do not overlap this branch's 20 changed files.

Boat job j_dajxt2xinr2cuqy3bhkm, stage check:changed, large plain-image VM bx_xqudzjwy, attempt 1, exit 0. Commands: vp run check:changed "$FLEET_SOURCE_BASE"; vp test run apps/mobile/src/features/threads/new-task-flow-state.test.ts; vp test run apps/web/src/components/CommandPalette.browser.test.tsx apps/web/src/shortcuts/commandPaletteCommands.browser.test.tsx. Passed format, lint, both knip stages, typecheck of seven affected packages/dependents, 40 nearby tests, 20 selected React Compiler checks, nine mobile new-task state tests, five Chromium browser tests. Earlier check on 3fa8185 failed the new-task provider test's native dependency import with DEV undefined. fcc9644 added the missing mocked source-control hook to that existing fixture; full changed checks then passed.

Independent Codex integration review on 3fa8185 against d890e5c: no new findings. R1 effective authenticated identity only, R2 Settings uses whole-group label, and R3 origin authorities preserve HTTP ports all resolved. Final fcc9644 changes only the test fixture, not behavior.

Corex browser: installed Playwright Chromium, real web client from fcc9644 served by isolated development backend. Primary environment plus an independently initialized and paired second backend on port 14297. Actual effective GitHub login shivamhwp in both. Own fixture has two local checkouts and one remote checkout. Assertions checked all three entries, including linked-b. No paid provider turn ran. Before comparison: fcc9644 app with only packages/client-runtime/src/state/projectGrouping.ts substituted from d890e5c. This is a baseline-module comparison, not a full main build. Settings index, overview and palette show shivamhwp/linked-label-demo. After comparison: exact restored fcc9644. Same views show linked-label-demo. Foreign example-owner/public-demo and Chosen project title remain unchanged. A separate pass confirmed all three checkout entries and opened a new thread from the palette; breadcrumb and draft headline use linked-label-demo. Source restored in finally; git diff --check and clean tracked status verified. Before/after MP4s were trimmed to the overview-to-palette interaction to exclude setup and pairing. Final frames held for two seconds for readability. Both MP4s decoded successfully with ffmpeg, and frames plus PNGs were inspected.

Earlier native verification: 7a24f2e787ce45b41766140f29dbf6c2098729c5 on Android POCO F4/Android14 and shiv iPhone17e/iOS27 simulator. Both Settings scope/index/overview, home filter, new-task picker/headline passed using two checkouts in one environment. Native baseline substituted only the grouping module. These recordings predate the rebase and are not current-head device evidence. Current-head mobile source typechecks, unit tests and compiler checks passed on Boat.

Unproven: native device UI on the rebased head; live account switching; failed-transport identity clearing; enterprise provider integrations; physical iPhone. Earlier iOS Metro logged TypeError: undefined is not a function with no stack; its cause and impact remain unproven. Native label assertions themselves passed.

Explain Change →

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[GPT-6.1 Sol][Codex] on behalf of shivam.

R5, mobile discovery refresh: fixed in 326b98c35e91e44e2ae6c21f650da6f498b8f8b0. The mobile sign-in row now uses its parent discovery query's refresh callback after successful sign-in and sign-out, matching the web flow. Failed, cancelled and superseded sign-in attempts keep their existing handling.

R6, mixed-case display-name fallback: declined for this PR because it predates this change. I executed buildProjectGroups from base d890e5c40120769badcf18bff6d1ac983c8f40c7 and published head 9227e85b88dcb056c90172fb9f1979c79df4a296 with the same two linked remotes, EtanHey/orchestrator and etanhey/orchestrator. Both versions returned orchestrator for unknown, foreign and owner accounts. The repository-name fallback is unchanged. I am keeping that separate behavior out of the owner-qualified-label fix, as the review guidance asks us to avoid cleanup of untouched code. The PR description now limits its claim to the new shortening rule.

Validation on 326b98c35e91e44e2ae6c21f650da6f498b8f8b0: Boat job j_jbx7esjrdfw2suncncjr, stage check:changed, large VM bx_4mv8hhkr from the t3code template, attempt 1, exit 0. Format, lint, both knip stages, seven affected package typechecks, 65 nearby tests and 21 compiler checks passed.

Unverified: live GitHub OAuth completion or account switching on a native device. The existing device recordings cover label presentation, not this authentication flow.

Verified in a real dev environment

verified unchanged head 326b98c35e91e44e2ae6c21f650da6f498b8f8b0 on a disposable linux boat vm. baseline: github/main at 84537c4dd9, in a separate worktree. installed both with vp i and ran their dev servers sequentially in the background. playwright used the repository dependency and /usr/bin/google-chrome.

added two real local checkouts of maria-rcks/sb-boat-config-loader through add project → local folder. production github credentials authenticated as the repository owner; no mocked identity responses, fixtures, or demo data. main shows maria-rcks/sb-boat-config-loader; the pr shows sb-boat-config-loader in the project filter, command palette, new-thread screen, and settings. settings retains both checkout entries.

started real codex gpt-6.1-sol turns through the web composer on both revisions. on the pr, the turn ran directory, branch, and origin commands and returned PR-29111-REAL-PROVIDER sb-boat-config-loader. thread history remained usable. two checkouts of foreign repository octocat/Hello-World kept their qualified label. changing the owned group's name to Chosen project title updated its label; restoring its repository name worked. the recorded interaction reported zero page errors.

before, main settings:

main settings shows the owner-qualified label

after, pr settings with the same repository and checkouts:

pr settings shows the short repository label

custom and foreign labels remain intact beside the real codex reply

11-second recording: project filter → command palette → settings → custom name → project filter. startup frames were trimmed. the corresponding mp4 was played and seeked successfully in t3's browser player.

recorded project-label interactions

Not verified

native ios/android and electron clients, including mobile sign-in/sign-out refresh; this run used linux web. cross-environment pairing and conflicting accounts on separate servers were not exercised: both checkouts belonged to one environment. non-github and enterprise authentication were not exercised. no code changes or pushes were needed. task-owned dev servers and the blacksmith worker were stopped.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Reassessed against current main and rebased to 40c81b1cb4bef26b0e4399d37794c1767d75f479, base cefb544af3c98224874419198c0359b652ca3c94. Main still reproduces the automatic-label bug; neither overlapping rename PR supersedes this fix. Fresh review found no new confirmed defect, and no unresolved GitHub review threads remain.

Boat j_5uackpwnv5lhkpjd3far succeeded with exit 0: check:changed passed 65 nearby tests and 21 applicable compiler checks, the focused Chromium run passed 5 tests, and desktop/server/web builds passed. All live CI checks are green. Commands and result excerpts appear below. Routine dependency and build chatter is omitted.

Real native GitHub App sign-out/sign-in remains unproven. The retry returns enabled: false, unsupported: "This server is not set up to sign in with T3 Code for GitHub." The public client ID remains unset on corex and shiv. iOS Device-panel boot failed twice; the F4 client was compatible, but device transport failed before a current-head run could be established. Desktop CLI/token switching and Boat cannot exercise the native App callback. No synthetic response is presented as real authorization.

The assessment and alternatives appear below. Existing recordings below remain evidence for their stated earlier commits. Current-head linked-environment desktop/mobile recordings and real native authorization remain unverified. The PR stays open with auto-merge disabled; it is not ready to merge.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Rebased onto main 521ac7c218b3faa74281fb72fc36ce74a0951fb3; live head is d7730a17326b75e85ae4becef21223abac21f488. Mechanical conflict resolution preserves main's legacy plan-mode removal and Settings menu layout, alongside this PR's account hook. A fresh independent Codex review found no integration defects. Commits 3–11 are unchanged in the range-diff; the first two differ only in context.

Boat vftovzwenop7kaan passed the repo's exact-head check, exit 0. VM bx_q93bsrt6 is confirmed deleted. This supersedes the earlier-head validation attribution; historical desktop recordings remain attributed to their recorded commits.

Native evidence remains blocked. Fresh corex process probe read 199 environments and found zero nonempty T3CODE_GITHUB_APP_CLIENT_ID values. The production source disables App sign-in without it. Shiv SSH timed out, so no fresh shiv configuration result is claimed. Device discovery reports no simulator-pool devices and shiv unreachable. App metadata still returns 404. No unchanged failed device routes were retried, no test environment was signed into a personal account, and no external identity response was fabricated. Current-head native label/discovery/filter/title-save and genuine App sign-out/sign-in evidence remain unverified. This is not a ready report.