Synced from GitHub
test: remove unreachable github cli decoding test#28115
problem
one complete test still exercises the retired github cli list-json ingestion path, not the current graphql production path. this focused test-pruning audit removes that case, with no production changes.
removal and evidence
- remove
skips rows that do not decode and trims the ones that dofrompackages/source-control-github/src/server/gitHubPullRequests.test.ts(36 lines). - on base
79f1fadfc602, a repository-wide tracked-source search findsdecodeGitHubPullRequestListJsononly in its declaration and this test file. its privatedecodeGitHubPullRequestEntries/decodeGitHubPullRequestEntryschema-decoding chain is used only by that exported decoder. the package exports only./shared/definitionand./server/driver, not this decoder. - side by side: the removed test feeds a serialized array through the obsolete schema decoder to reject an invalid row and trim strings. the live
GitHubSourceControlProvider.ts:409-424instead receives a typed graphqlPullRequestNode, explicitly trims and validates its fields intoPullRequestRecord, then callsnormalizeGitHubPullRequestRecord. the removed test never reaches that ingestion boundary and cannot catch regressions in its validation or trimming. - retain both neighboring tests: fork-owner fallback and state normalization still exercise
normalizeGitHubPullRequestRecord, which has a real production caller. retain the entire provider suite and other distinct provider/client coverage. - broader inspection included mobile/web helpers, timeline and activity-filter coverage, source-control decoders, and existing open audit prs. similar-looking tests for distinct implementations or branches were retained; existing sidebar/onboarding/browser audit changes were not duplicated. no entire file met the same confidence bar in this run.
verification
- before:
./node_modules/.bin/vp test run packages/source-control-github/src/server/gitHubPullRequests.test.ts packages/source-control-github/src/server/GitHubSourceControlProvider.test.ts: 2 files, 40 tests passed. - after: same command: 2 files, 39 tests passed.
vp run check:changed --concurrency 2: passed format, lint, both knip passes, graphql generation check, affected/dependent typechecks (11 packages, including cache replays for 2 packages), and adjacent tests (2 files, 3 tests).- the first changed-check run failed because this dedicated checkout had stale workspace dependency links.
vp install --frozen-lockfilerestored them; the complete changed-check rerun passed. an initial globalvp testinvocation also hit a global/local vite-plus mismatch; all reported passing test runs used the repository-local executable. git diff --check: passed. full diff reviewed: one complete test removed, no production edits, added secrets, or dependency-file changes. full suites and build are left to ci.
this is the t3code useless test audit cron automation, with no human co-author.
model: gpt-6.1-sol. harness: hermes agent.
Checks
23 successful · 14 skipped
Added 1 commit
- test: remove unreachable github cli decoding test986c538
Synced from GitHub
Approvability
Verdict: Approved at 986c538
Macroscope's review found this PR approvable — This removes a test for the retired GitHub CLI decoding path, with changes confined to an ignored test file. The described scope leaves production behavior and current provider coverage unchanged, with no material risk requiring human judgment.
Notes:
- No code objects were reviewed. Approvability was decided on eligibility alone.
You can add or adjust custom eligibility rules. Learn more.
Synced from GitHub
Thread transfer impact
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 5.0 KiB | 5.0 KiB | 0 B (0.0%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | 0 B (0.0%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 21.6 KiB | 21.6 KiB | 0 B (0.0%) | 24.4 KiB | ✅ |
| Codex | Live turn messages | 2 | 2 | 0 (0.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | −29 B (−0.6%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.3 KiB | 1.2 KiB | −29 B (−2.3%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.9 KiB | 21.9 KiB | −41 B (−0.2%) | 24.4 KiB | ✅ |
| Claude | Live turn messages | 2 | 1 | −1 (−50.0%) | 8 | ✅ |
Baseline: 79f1fad · PR result: 986c538 · Source CI: success
Scenario and decoded snapshot size
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
- Codex decoded thread snapshot: 108.5 KiB
- Claude decoded thread snapshot: 108.8 KiB
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Synced from GitHub
🤖 Automated review by Audit Bench Ai, not a personal review. It was posted through the GitHub account connected to Audit Bench Ai. Install the Audit Bench Ai GitHub App to have reviews posted by a separate bot account.
No actionable comments were generated in this review. 🎉
Merge risk: ⚪ Minimal · up to 986c538
This change only removes a test for an unexported, unused legacy decoding path, leaving production code and valid tests untouched.
Merge readiness: ✅ Ready to merge
Pre-merge checks: ✅ 9
✅ Passed checks: 9 passed
| Check name | Status | Explanation |
|---|---|---|
| Merge conflicts | ✅ | Merges cleanly into main. |
| CI checks | ✅ | All 30 passed. |
| Secrets | ✅ | No keys, passwords or tokens in the changed code. |
| Blocking issues | ✅ | No critical or high-severity issues in the changed lines. |
| PR size | ✅ | 36 lines changed. |
| Title check | ✅ | The title clearly states that an unreachable GitHub CLI decoding test is being removed. |
| Description check | ✅ | The description provides comprehensive context and verification details for the test removal. |
| Linked issues check | ✅ | No issues are linked or referenced in the PR description. |
| Out of scope changes check | ✅ | The changes are strictly limited to removing the specified unreachable test. |
📝 Walkthrough
This PR removes an obsolete test from gitHubPullRequests.test.ts that covered an unused GitHub CLI list-json decoding path. The production code has transitioned to a GraphQL-based implementation, making this test unreachable and redundant. No production code is modified.
| File | Changes |
|---|---|
packages/source-control-github/src/server/gitHubPullRequests.test.ts | Removes a test exercising the obsolete GitHub CLI list-json schema decoder. |
ℹ️ Review info
- Commit:
986c538 - Verdict: ✅ Pass
- Findings: none
- Review: local checks plus AI review of the changed lines
- Scope: Reviewed 1/1 selected files (of 1 total): 1 reviewed by AI, 0 from cache, 0 passed local checks with nothing risky enough to send to AI. Found 0 finding(s), No secrets found.
💬 Reply to any inline comment and Audit Bench Ai will recheck that code and answer in the thread. Mention @auditbench in the conversation to ask about the whole PR.
🛠️ Open the full report and fix with AI
Thanks for using Audit Bench Ai! Free pull request reviews for open source: paste any public PR at auditbenchai.com/scan.
Reviewed by Audit Bench Ai · AI code review for security, logic and performance · Review any public PR free
Note
Written by gpt-6.1-sol on behalf of Maria
Verified in a real dev environment
verified unchanged production behavior at 986c538e52baec0e13a80eae23ae4dc2d10c828a. this pr only deletes one legacy decoder test. there is no original user-visible bug to reproduce.
- ran
vp iand backgroundvp run devseparately ongithub/main(54c5f25249, worktree) and the exact pr head. stopped main before starting the pr. the final pr run used/home/user/pr28115-stateas its isolated home. - drove the actual web client with repository playwright and
/usr/bin/google-chrome. added a project pointing at a real github checkout through the app. github search returned #28115 with the correct title, open state, review/check indicators, and +0/-36 counts on both versions. - switched to merged results: #28115 disappeared and a real merged result appeared. switched back, refreshed, and opened #28115's detail panel. the captured websocket responses returned the expected states with no project errors. also exercised closed-result filtering on the pr.
- submitted real codex
gpt-6.1-solturns through the composer on both versions. both executed git commands and returnedVERIFICATION_OK, the github origin, and the expected branch. no mocks, fixtures, or replay provider were used. - blacksmith: both github suites passed, 39 tests.
vp run check:changed 79f1fadfc6020b820d541ca4691d2feebb15dd1bpassed format, lint, both knip passes, graphql generation, 11 package typechecks, and adjacent tests. the worker needed the shallow parent fetched before the changed-file check could run. existing ci reports 30 successful checks.
no source changes or pushes were needed. the first root startup selected the live home; it was stopped and excluded from this verification.
main: github search for #28115
pr: matching github search for #28115
pr: state filters, refresh, and opening details
Not verified
native ios/android, electron-specific behavior, macos/windows, remote/tunnel connections, and other agent providers were not exercised on this linux vm. live github data cannot reproduce the malformed legacy cli-json input from the deleted test; source inspection confirms that decoder has no production caller. no performance claim is made.